Mercurial > sdl-ios-xcode
annotate src/thread/win32/SDL_systhread.c @ 1258:b2283b0ded26
Date: Thu, 19 Jan 2006 20:02:29 +0200
From: Vassilis Virvilis <vasvir@iit.demokritos.gr>
Subject: [SDL] Request: Please reconsider adding tag in SDL_Event
Hi,
Patch in question:
--- include/SDL_events.h 20 Aug 2004 18:57:01 -0000 1.11
+++ include/SDL_events.h 19 Jan 2006 17:35:09 -0000
@@ -214,7 +214,7 @@
} SDL_SysWMEvent;
/* General event structure */
-typedef union {
+typedef union SDL_Event {
Uint8 type;
SDL_ActiveEvent active;
SDL_KeyboardEvent key;
Reasoning:
----------
1) Allows forward declaration of the SDL_Event union in C++. Please
note that in plain C it is possible to forward declare it.
2) Forward declaration is good because it allows encapsulation. It hides
the specific implementation and does not necessarily exposes SDL staff
to my appication's namespace
3) It can't harm plain C because tags are living in a different namespace
than typenames
4) It is already done like this in other places in SDL. Check for example
SDL_KeySym, and SDL_.*Event structures.
5) Right now I have to include SDL/event.h from a C++ header file. See 2)
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 20 Jan 2006 13:07:25 +0000 |
parents | 86d0d01290ea |
children | c9b51268668f |
rev | line source |
---|---|
0 | 1 /* |
2 SDL - Simple DirectMedia Layer | |
769
b8d311d90021
Updated copyright information for 2004 (Happy New Year!)
Sam Lantinga <slouken@libsdl.org>
parents:
297
diff
changeset
|
3 Copyright (C) 1997-2004 Sam Lantinga |
0 | 4 |
5 This library is free software; you can redistribute it and/or | |
6 modify it under the terms of the GNU Library General Public | |
7 License as published by the Free Software Foundation; either | |
8 version 2 of the License, or (at your option) any later version. | |
9 | |
10 This library is distributed in the hope that it will be useful, | |
11 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
12 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
13 Library General Public License for more details. | |
14 | |
15 You should have received a copy of the GNU Library General Public | |
16 License along with this library; if not, write to the Free | |
17 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
18 | |
19 Sam Lantinga | |
252
e8157fcb3114
Updated the source with the correct e-mail address
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
20 slouken@libsdl.org |
0 | 21 */ |
22 | |
23 #ifdef SAVE_RCSID | |
24 static char rcsid = | |
25 "@(#) $Id$"; | |
26 #endif | |
27 | |
28 /* Win32 thread management routines for SDL */ | |
29 | |
30 #include <stdio.h> | |
31 #include <stdlib.h> | |
32 #include <windows.h> | |
1251
86d0d01290ea
Updated Windows CE/PocketPC support...adds GAPI driver, landscape mode,
Ryan C. Gordon <icculus@icculus.org>
parents:
1225
diff
changeset
|
33 |
86d0d01290ea
Updated Windows CE/PocketPC support...adds GAPI driver, landscape mode,
Ryan C. Gordon <icculus@icculus.org>
parents:
1225
diff
changeset
|
34 #ifndef _WIN32_WCE |
1225
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
35 #include <process.h> |
1251
86d0d01290ea
Updated Windows CE/PocketPC support...adds GAPI driver, landscape mode,
Ryan C. Gordon <icculus@icculus.org>
parents:
1225
diff
changeset
|
36 #endif |
0 | 37 |
38 #include "SDL_error.h" | |
39 #include "SDL_thread.h" | |
40 #include "SDL_systhread.h" | |
41 | |
42 | |
1225
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
43 static unsigned __stdcall RunThread(void *data) |
0 | 44 { |
45 SDL_RunThread(data); | |
46 return(0); | |
47 } | |
48 | |
49 int SDL_SYS_CreateThread(SDL_Thread *thread, void *args) | |
50 { | |
1225
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
51 unsigned threadid; |
0 | 52 |
1225
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
53 /* |
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
54 * Avoid CreateThread: https://bugzilla.libsdl.org/show_bug.cgi?id=22 |
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
55 * |
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
56 * have to use _beginthreadex if we want the returned handle |
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
57 * to be accessible after the thread exits |
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
58 * threads created with _beginthread auto-close the handle |
1251
86d0d01290ea
Updated Windows CE/PocketPC support...adds GAPI driver, landscape mode,
Ryan C. Gordon <icculus@icculus.org>
parents:
1225
diff
changeset
|
59 * Windows CE still use CreateThread. |
1225
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
60 */ |
1251
86d0d01290ea
Updated Windows CE/PocketPC support...adds GAPI driver, landscape mode,
Ryan C. Gordon <icculus@icculus.org>
parents:
1225
diff
changeset
|
61 #ifdef _WIN32_WCE |
86d0d01290ea
Updated Windows CE/PocketPC support...adds GAPI driver, landscape mode,
Ryan C. Gordon <icculus@icculus.org>
parents:
1225
diff
changeset
|
62 thread->handle = CreateThread(NULL, 0, RunThread, args, 0, &threadid); |
86d0d01290ea
Updated Windows CE/PocketPC support...adds GAPI driver, landscape mode,
Ryan C. Gordon <icculus@icculus.org>
parents:
1225
diff
changeset
|
63 #else |
1225
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
64 thread->handle = (SYS_ThreadHandle) _beginthreadex(NULL, 0, RunThread, |
09bc22169702
Windows should use _beginthreadex() instead of CreateThread(), to avoid a
Ryan C. Gordon <icculus@icculus.org>
parents:
769
diff
changeset
|
65 args, 0, &threadid); |
1251
86d0d01290ea
Updated Windows CE/PocketPC support...adds GAPI driver, landscape mode,
Ryan C. Gordon <icculus@icculus.org>
parents:
1225
diff
changeset
|
66 #endif |
0 | 67 if (thread->handle == NULL) { |
68 SDL_SetError("Not enough resources to create thread"); | |
69 return(-1); | |
70 } | |
71 return(0); | |
72 } | |
73 | |
74 void SDL_SYS_SetupThread(void) | |
75 { | |
76 return; | |
77 } | |
78 | |
79 Uint32 SDL_ThreadID(void) | |
80 { | |
81 return((Uint32)GetCurrentThreadId()); | |
82 } | |
83 | |
84 void SDL_SYS_WaitThread(SDL_Thread *thread) | |
85 { | |
86 WaitForSingleObject(thread->handle, INFINITE); | |
87 CloseHandle(thread->handle); | |
88 } | |
89 | |
90 /* WARNING: This function is really a last resort. | |
91 * Threads should be signaled and then exit by themselves. | |
92 * TerminateThread() doesn't perform stack and DLL cleanup. | |
93 */ | |
94 void SDL_SYS_KillThread(SDL_Thread *thread) | |
95 { | |
96 TerminateThread(thread->handle, FALSE); | |
97 } |