annotate TODO @ 474:c66080364dff

Most decoders now report total sample play time, now. Technically, this breaks binary compatibility with the 1.0 branch, since it extends the Sound_Sample struct, but most (all?) programs are just passing pointers allocated by SDL_sound around, and might be okay. Source-level compatibility is not broken...yet! :) --ryan. -------- Original Message -------- Subject: SDL_sound patch: Finding total length of time of sound file. Date: Sun, 26 Jan 2003 09:31:17 -0800 (PST) Hi Ryan, I am working with Eric Wing and helping him modify SDL_sound. AS part of our efforts in improving and enhancing SDL_sound, we like to submit this patch. We modified the codecs to find the total time of a sound file. Below is the explanation of the patch. The patch is appended as an attachment to this email. * MOTIVATION: We needed the ability to get the total play time of a sample (And we noticed that we're not the only ones). Since SDL_sound blocks direct access to the specific decoders, there is no way for a user to know this information short of decoding the whole thing. Because of this, we believe this will be a useful addition, even though the accuracy may not be perfect (subject to each decoder) or the information may not always be available. * CONTRIBUTORS: Wesley Leong (modified the majority of the codecs and verified the results) Eric Wing (showed everyone how to do modify codec, modified mikmod) Wang Lam (modified a handful of codecs, researched into specs and int overflow) Ahilan Anantha (modified a few codecs and helped with integer math) * GENERAL ISSUES: We chose the value to be milliseconds as an Sint32. Milliseconds because that's what Sound_Seek takes as a parameter and -1 to allow for instances/codecs where the value could not be determined. We are not sure if this is the final convention you want, so we are willing to work with you on this. We also expect the total_time field to be set on open and never again modified by SDL_sound. Users may access it directly much like the sample buffer and buffer_size. We thought about recomputing the time on DecodeAll, but since users may seek or decode small chunks first, not all the data may be there. So this is better done by the user. This may be good information to document. Currently, all the main codecs are implemented except for QuickTime.
author Ryan C. Gordon <icculus@icculus.org>
date Sat, 08 May 2004 08:19:50 +0000
parents ff3ec3c6cdde
children 137c0b00ea4c
rev   line source
424
ff3ec3c6cdde Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 405
diff changeset
1 More immediate:
234
156df33fd7fc Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 230
diff changeset
2 - Fix the crappy rewind implementation in shn.c's SHN_rewind().
321
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
3 - Finish implementing seek() method in decoders, see below.
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
4 - Add a sdlsound-config script?
405
4ad617261a91 Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 356
diff changeset
5 - Make sure we can build shared libs on Cygwin, BeOS, Mac OS X...
321
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
6
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
7 Decoders still needing seek() method:
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
8 (If decoder can't seek, clean up the stub and report an error.)
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
9 - mikmod.c
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
10 - shn.c
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
11 - mpglib.c
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
12 - quicktime.c
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
13
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
14 General stuff TODO:
339
e3ac0d41668c Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 336
diff changeset
15 - Hack on the experimental audio conversion routines.
352
f0eb99670fa8 Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 345
diff changeset
16 - Handle compression and other chunks in WAV files.
f0eb99670fa8 Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 345
diff changeset
17 - Handle compression and other chunks in AIFF-C files.
321
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
18
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
19 Quicktime stuff that'd be cool, but isn't crucial:
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
20 - Integrate decoders/quicktime.c with build system (for OS X)?
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
21 - Make decoders/quicktime.c more robust.
182fdc76060d Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 256
diff changeset
22 - Make decoders/quicktime.c work on win32?
339
e3ac0d41668c Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 336
diff changeset
23 - There's no seek() method.
23
06a009a1ec9e Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 9
diff changeset
24
06a009a1ec9e Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 9
diff changeset
25 Ongoing:
06a009a1ec9e Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 9
diff changeset
26 - look for "FIXME"s in the code.
06a009a1ec9e Updated.
Ryan C. Gordon <icculus@icculus.org>
parents: 9
diff changeset
27
0
1078b3528e6f Initial revision
Ryan C. Gordon <icculus@icculus.org>
parents:
diff changeset
28 /* end of TODO ... */
1078b3528e6f Initial revision
Ryan C. Gordon <icculus@icculus.org>
parents:
diff changeset
29