Patch by me to fix crash described below. --ryan. To: sdl@libsdl.org From: Rainer Deyke <rainerd@eldwood.com> Date: Tue, 16 Aug 2005 01:08:18 -0600 Subject: [SDL] Bug report: SDL_CreateRGBSurface with SDL_HWSURFACE crashes If SDL is in full-screen mode with a hardware video surface on OS X, SDL_CreateRGBSurface with SDL_HWSURFACE crashes. The crash occurs on line 109 of SDL_Surface.c. This was tested on OS X 10.3.9 with both SDL 1.2.8 and the latest CVS. Here is a small C++ program that demonstrates the problem: #include "SDL.h" #include <stdio.h> namespace { void wait_for_key() { SDL_Event e; printf("%d\n", SDL_GetAppState()); while (SDL_WaitEvent(&e)) { if (e.type == SDL_KEYDOWN || e.type == SDL_QUIT) return; } } } int main(int, char *[]) { SDL_Init(SDL_INIT_VIDEO); SDL_Surface *screen = SDL_SetVideoMode(640, 480, 32, SDL_FULLSCREEN | SDL_HWSURFACE); SDL_Surface *s = SDL_CreateRGBSurface(SDL_HWSURFACE, 640, 480, 32, screen->format->Rmask, screen->format->Gmask, screen->format->Bmask, screen->format->Amask); wait_for_key(); if (s) SDL_FreeSurface(s); SDL_Quit(); printf("Success!\n"); return 0; }

# The input Makefile for SDL header files

# The directory where the include files will be installed
libSDLincludedir = $(includedir)/SDL

# Which header files to install
libSDLinclude_HEADERS =		\
	SDL.h			\
	SDL_active.h		\
	SDL_audio.h		\
	SDL_byteorder.h		\
	SDL_cdrom.h		\
	SDL_copying.h		\
	SDL_cpuinfo.h		\
	SDL_endian.h		\
	SDL_error.h		\
	SDL_events.h		\
	SDL_getenv.h		\
	SDL_joystick.h		\
	SDL_keyboard.h		\
	SDL_keysym.h		\
	SDL_loadso.h		\
	SDL_main.h		\
	SDL_mouse.h		\
	SDL_mutex.h		\
	SDL_name.h		\
	SDL_opengl.h		\
	SDL_quit.h		\
	SDL_rwops.h		\
	SDL_syswm.h		\
	SDL_thread.h		\
	SDL_timer.h		\
	SDL_types.h		\
	SDL_version.h		\
	SDL_video.h		\
	begin_code.h		\
	close_code.h