Mercurial > sdl-ios-xcode
view src/thread/linux/clone.S @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Mon, 28 Nov 2005 13:58:26 +0000 |
parents | 974ba6ae0fa3 |
children | c9b51268668f |
line wrap: on
line source
/* Taken with thanks from LinuxThreads 0.6 */ /* This is no longer necessary with glibc-2.1, which has its own clone() */ #ifdef linux /* Look to see if glibc is available, and if so, what version */ #include <features.h> #if (__GLIBC__ > 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 1)) #define HAVE_CLONE #endif /* glibc 2.1 or newer */ #endif /* linux */ #if defined(linux) && !defined(SDL_USE_PTHREADS) && !defined(HAVE_CLONE) #if defined(__i386__) /************************************************************************/ /* Copyright (C) 1996, 1997 Free Software Foundation, Inc. Contributed by Richard Henderson (rth@tamu.edu) The GNU C Library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. The GNU C Library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with the GNU C Library; see the file COPYING.LIB. If not, write to the Free Software Foundation, Inc., 675 Mass Ave, #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif Cambridge, MA 02139, USA. */ /* clone() is even more special than fork() as it mucks with stacks and invokes a function in the right context after its all over. */ #include <asm/errno.h> #include <asm/unistd.h> /* int clone(int (*fn)(void *arg), void *child_stack, int flags, void *arg); */ .text .align 4 .globl __clone .type __clone,@function .weak clone clone = __clone __clone: /* Sanity check arguments. */ movl $-EINVAL,%eax movl 4(%esp),%ecx /* no NULL function pointers */ testl %ecx,%ecx jz syscall_error movl 8(%esp),%ecx /* no NULL stack pointers */ testl %ecx,%ecx jz syscall_error /* Insert the argument onto the new stack. */ subl $8,%ecx movl 16(%esp),%eax movl %eax,4(%ecx) /* Save the function pointer as the zeroth argument. */ /* It will be popped off in the child in the ebx frobbing below. */ movl 4(%esp),%eax movl %eax,0(%ecx) /* Do the system call */ pushl %ebx movl 16(%esp),%ebx movl $__NR_clone,%eax int $0x80 popl %ebx test %eax,%eax jl syscall_error jz thread_start ret syscall_error: negl %eax pushl %eax #ifdef __PIC__ call __errno_location@PLT #else call __errno_location #endif popl 0(%eax) movl $-1, %eax ret thread_start: subl %ebp,%ebp /* terminate the stack frame */ call *%ebx pushl %eax #ifdef __PIC__ call _exit@PLT #else call _exit #endif /************************************************************************/ #elif defined(sparc) /************************************************************************/ /* Copyright (C) 1996, 1997 Free Software Foundation, Inc. Contributed by Miguel de Icaza (miguel@nuclecu.unam.mx) Based on code written for the Intel by Richard Henderson (rth@tamu.edu) The GNU C Library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. The GNU C Library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with the GNU C Library; see the file COPYING.LIB. If not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ /* clone() is even more special than fork() as it mucks with stacks and invokes a function in the right context after its all over. */ #include <asm/errno.h> #include <asm/unistd.h> /* int clone(int (*fn)(void *arg), void *child_stack, int flags, void *arg); */ .text .align 4 .globl __clone .type __clone,@function .weak clone clone = __clone __clone: save %sp,-96,%sp /* sanity check arguments */ tst %i0 be __clone_syscall_error tst %i1 be __clone_syscall_error nop /* Do the system call */ mov %i1,%o1 mov %i2,%o0 set __NR_clone,%g1 ta 0x10 bcs __clone_syscall_error tst %o1 bne __thread_start nop mov %o0,%i0 ret restore __clone_syscall_error: call __errno_location set EINVAL,%i0 st %i0,[%o0] mov -1,%i0 ret restore __thread_start: call %i0 mov %i3,%o0 call _exit,0 nop /************************************************************************/ #else #error "Unknown Linux architecture" #endif #endif /* Linux && ! SDL_USE_PTHREADS */