Mercurial > sdl-ios-xcode
annotate src/thread/linux/clone.S @ 1192:54aa9aa32327
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Fri, 18 Nov 2005 23:39:02 +0100
Subject: [SDL] Mouse position bugs on Mac OS X
The attached patch fixes a few bugs in SDL related to the mouse position
in windowed mode on Mac OS X, reproduced using the attached minimal test
program - at least here on 10.3.9, with SDL CVS from today. Could anyone
test whether the bugs exist and are fixed by the patch on 10.2 and 10.4?
1. When using OpenGL, the vertical mouse positions obtained through
events or SDL_GetMouseState() are off by one.
2. When using OpenGL, SDL_WarpMouse() inverts the y coordinate.
3. Clicks on the topmost pixel row of the window are not recognized.
1 and 2 do not occur in non-OpenGL mode, while 3 does. All three only
occur in windowed mode, not in fullscreen.
The cause for 1 and 3 is that in Cocoa, "the location of the mouse"
seems to be defined as "the location of the top left corner of the mouse
pointer's hot pixel" (this is not documented, it's just what I found out
here), which together with the fact that Cocoa's usual y coordinates
start at the bottom and increase upwards means that the y coordinate of
the mouse runs from 1 to h, not from 0 to h-1, in a window of height h.
If it does work on 10.2 and 10.4 (I'll try to test it as soon as I can,
but at the moment all I have at hand is 10.3.9), can this be applied to
the CVS?
-Christian
To: sdl@libsdl.org
From: Christian Walther <cwalther@gmx.ch>
Date: Mon, 28 Nov 2005 10:41:51 +0100
Subject: [SDL] Re: Mouse position bugs on Mac OS X
I wrote:
> I'll try to test it as soon as I can, but at the moment all I have at hand is 10.3.9
So, here are the results of my tests (with patched and unpatched
frameworks compiled with Xcode 1.5 (gcc 3.3) on 10.3.9):
On 10.1.5, my test program doesn't run because of "Undefined symbols:
SDL undefined reference to _CGMainDisplayID expected to be defined in
Carbon". I guess not supporting 10.1 was a deliberate decision then and
that's OK with me.
On 10.2.8, 10.3.9, and 10.4.0, the bugs exist as described in my
original post and are fixed by my patch. That is, there is no difference
between pre/post 10.3 and the patched version works correctly in all
combinations of GL/non-GL and windowed/fullscreen.
I therefore recommend the patch for inclusion.
-Christian
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Mon, 28 Nov 2005 13:58:26 +0000 |
| parents | 974ba6ae0fa3 |
| children | c9b51268668f |
| rev | line source |
|---|---|
| 0 | 1 |
| 2 /* Taken with thanks from LinuxThreads 0.6 */ | |
| 3 | |
|
1035
974ba6ae0fa3
Date: Wed, 26 Jan 2005 13:37:09 GMT
Sam Lantinga <slouken@libsdl.org>
parents:
0
diff
changeset
|
4 /* This is no longer necessary with glibc-2.1, which has its own clone() */ |
| 0 | 5 #ifdef linux |
| 6 /* Look to see if glibc is available, and if so, what version */ | |
| 7 #include <features.h> | |
| 8 | |
| 9 #if (__GLIBC__ > 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 1)) | |
| 10 #define HAVE_CLONE | |
| 11 #endif /* glibc 2.1 or newer */ | |
| 12 #endif /* linux */ | |
| 13 | |
| 14 #if defined(linux) && !defined(SDL_USE_PTHREADS) && !defined(HAVE_CLONE) | |
| 15 | |
| 16 #if defined(__i386__) | |
| 17 /************************************************************************/ | |
| 18 /* Copyright (C) 1996, 1997 Free Software Foundation, Inc. | |
| 19 Contributed by Richard Henderson (rth@tamu.edu) | |
| 20 | |
| 21 The GNU C Library is free software; you can redistribute it and/or | |
| 22 modify it under the terms of the GNU Library General Public License as | |
| 23 published by the Free Software Foundation; either version 2 of the | |
| 24 License, or (at your option) any later version. | |
| 25 | |
| 26 The GNU C Library is distributed in the hope that it will be useful, | |
| 27 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 28 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 29 Library General Public License for more details. | |
| 30 | |
| 31 You should have received a copy of the GNU Library General Public | |
| 32 License along with the GNU C Library; see the file COPYING.LIB. If | |
| 33 not, write to the Free Software Foundation, Inc., 675 Mass Ave, | |
| 34 | |
| 35 #ifdef SAVE_RCSID | |
| 36 static char rcsid = | |
| 37 "@(#) $Id$"; | |
| 38 #endif | |
| 39 Cambridge, MA 02139, USA. */ | |
| 40 | |
| 41 /* clone() is even more special than fork() as it mucks with stacks | |
| 42 and invokes a function in the right context after its all over. */ | |
| 43 | |
| 44 #include <asm/errno.h> | |
| 45 #include <asm/unistd.h> | |
| 46 | |
| 47 /* int clone(int (*fn)(void *arg), void *child_stack, int flags, void *arg); */ | |
| 48 | |
| 49 .text | |
| 50 .align 4 | |
| 51 .globl __clone | |
| 52 .type __clone,@function | |
| 53 .weak clone | |
| 54 clone = __clone | |
| 55 __clone: | |
| 56 /* Sanity check arguments. */ | |
| 57 movl $-EINVAL,%eax | |
| 58 movl 4(%esp),%ecx /* no NULL function pointers */ | |
| 59 testl %ecx,%ecx | |
| 60 jz syscall_error | |
| 61 movl 8(%esp),%ecx /* no NULL stack pointers */ | |
| 62 testl %ecx,%ecx | |
| 63 jz syscall_error | |
| 64 | |
| 65 /* Insert the argument onto the new stack. */ | |
| 66 subl $8,%ecx | |
| 67 movl 16(%esp),%eax | |
| 68 movl %eax,4(%ecx) | |
| 69 | |
| 70 /* Save the function pointer as the zeroth argument. */ | |
| 71 /* It will be popped off in the child in the ebx frobbing below. */ | |
| 72 movl 4(%esp),%eax | |
| 73 movl %eax,0(%ecx) | |
| 74 | |
| 75 /* Do the system call */ | |
| 76 pushl %ebx | |
| 77 movl 16(%esp),%ebx | |
| 78 movl $__NR_clone,%eax | |
| 79 int $0x80 | |
| 80 popl %ebx | |
| 81 | |
| 82 test %eax,%eax | |
| 83 jl syscall_error | |
| 84 jz thread_start | |
| 85 | |
| 86 ret | |
| 87 | |
| 88 syscall_error: | |
| 89 negl %eax | |
| 90 pushl %eax | |
| 91 #ifdef __PIC__ | |
| 92 call __errno_location@PLT | |
| 93 #else | |
| 94 call __errno_location | |
| 95 #endif | |
| 96 popl 0(%eax) | |
| 97 movl $-1, %eax | |
| 98 ret | |
| 99 | |
| 100 thread_start: | |
| 101 subl %ebp,%ebp /* terminate the stack frame */ | |
| 102 call *%ebx | |
| 103 pushl %eax | |
| 104 #ifdef __PIC__ | |
| 105 call _exit@PLT | |
| 106 #else | |
| 107 call _exit | |
| 108 #endif | |
| 109 /************************************************************************/ | |
| 110 #elif defined(sparc) | |
| 111 /************************************************************************/ | |
| 112 /* Copyright (C) 1996, 1997 Free Software Foundation, Inc. | |
| 113 Contributed by Miguel de Icaza (miguel@nuclecu.unam.mx) | |
| 114 Based on code written for the Intel by Richard | |
| 115 Henderson (rth@tamu.edu) | |
| 116 | |
| 117 The GNU C Library is free software; you can redistribute it and/or | |
| 118 modify it under the terms of the GNU Library General Public License as | |
| 119 published by the Free Software Foundation; either version 2 of the | |
| 120 License, or (at your option) any later version. | |
| 121 | |
| 122 The GNU C Library is distributed in the hope that it will be useful, | |
| 123 but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 124 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 125 Library General Public License for more details. | |
| 126 | |
| 127 You should have received a copy of the GNU Library General Public | |
| 128 License along with the GNU C Library; see the file COPYING.LIB. If | |
| 129 not, write to the Free Software Foundation, Inc., 675 Mass Ave, | |
| 130 Cambridge, MA 02139, USA. */ | |
| 131 | |
| 132 /* clone() is even more special than fork() as it mucks with stacks | |
| 133 and invokes a function in the right context after its all over. */ | |
| 134 | |
| 135 #include <asm/errno.h> | |
| 136 #include <asm/unistd.h> | |
| 137 | |
| 138 /* int clone(int (*fn)(void *arg), void *child_stack, int flags, void *arg); */ | |
| 139 | |
| 140 .text | |
| 141 .align 4 | |
| 142 .globl __clone | |
| 143 .type __clone,@function | |
| 144 .weak clone | |
| 145 clone = __clone | |
| 146 __clone: | |
| 147 save %sp,-96,%sp | |
| 148 /* sanity check arguments */ | |
| 149 tst %i0 | |
| 150 be __clone_syscall_error | |
| 151 tst %i1 | |
| 152 be __clone_syscall_error | |
| 153 nop | |
| 154 | |
| 155 /* Do the system call */ | |
| 156 mov %i1,%o1 | |
| 157 mov %i2,%o0 | |
| 158 set __NR_clone,%g1 | |
| 159 ta 0x10 | |
| 160 bcs __clone_syscall_error | |
| 161 tst %o1 | |
| 162 bne __thread_start | |
| 163 nop | |
| 164 mov %o0,%i0 | |
| 165 ret | |
| 166 restore | |
| 167 | |
| 168 __clone_syscall_error: | |
| 169 call __errno_location | |
| 170 set EINVAL,%i0 | |
| 171 st %i0,[%o0] | |
| 172 mov -1,%i0 | |
| 173 ret | |
| 174 restore | |
| 175 | |
| 176 __thread_start: | |
| 177 call %i0 | |
| 178 mov %i3,%o0 | |
| 179 call _exit,0 | |
| 180 nop | |
| 181 /************************************************************************/ | |
| 182 #else | |
| 183 #error "Unknown Linux architecture" | |
| 184 #endif | |
| 185 | |
| 186 #endif /* Linux && ! SDL_USE_PTHREADS */ |