comparison src/video/x11/SDL_x11modes.c @ 604:31d3af76488b

Date: Mon, 24 Feb 2003 16:31:25 -0500 From: Ragnvald "Despair" Maartmann-Moe IV Subject: SDL x11 video mode selection bug Hi, I've found an oddity with video mode selection. I recently added a bunch of oddball video modes to my XF86Config, to support weird resolutions xine & mplayer need if I don't want to beat my cpu up with video scaling. Since adding them, SDL started picking the biggest video mode it could find that matched the height constraint. Getting a narrow vertical strip of QuakeForge (I code for the project, so needless to say it's my favorite test) in the middle of an 800x480 screen, instead of the 640x480 I asked for annoys me tremendously. So here's a patch that tries a bit harder to get an exact match. I didn't touch the XiG section, since I can't test that, but I'd bet a similar patch would prevent similar problems there. --Ragnvald "Despair" Maartmann-Moe IV
author Sam Lantinga <slouken@libsdl.org>
date Thu, 06 Mar 2003 06:02:16 +0000
parents f480ecd70499
children f8710950cddc
comparison
equal deleted inserted replaced
603:2e726be3dc08 604:31d3af76488b
111 printf("Mode %d: %dx%d\n", i, 111 printf("Mode %d: %dx%d\n", i,
112 modes[i]->hdisplay, modes[i]->vdisplay); 112 modes[i]->hdisplay, modes[i]->vdisplay);
113 } 113 }
114 #endif 114 #endif
115 for ( i = nmodes-1; i > 0 ; --i ) { 115 for ( i = nmodes-1; i > 0 ; --i ) {
116 if ( (modes[i]->hdisplay == width) &&
117 (modes[i]->vdisplay == height) )
118 goto match;
119 }
120 for ( i = nmodes-1; i > 0 ; --i ) {
116 if ( (modes[i]->hdisplay >= width) && 121 if ( (modes[i]->hdisplay >= width) &&
117 (modes[i]->vdisplay >= height) ) 122 (modes[i]->vdisplay >= height) )
118 break; 123 break;
119 } 124 }
125 match:
120 if ( (modes[i]->hdisplay != mode.hdisplay) || 126 if ( (modes[i]->hdisplay != mode.hdisplay) ||
121 (modes[i]->vdisplay != mode.vdisplay) ) { 127 (modes[i]->vdisplay != mode.vdisplay) ) {
122 SDL_NAME(XF86VidModeSwitchToMode)(SDL_Display, SDL_Screen, modes[i]); 128 SDL_NAME(XF86VidModeSwitchToMode)(SDL_Display, SDL_Screen, modes[i]);
123 } 129 }
124 XFree(modes); 130 XFree(modes);