annotate TODO @ 1524:38a12fd1a2c1

Fixed bug #46 Date: Fri, 13 Jan 2006 18:09:45 -0500 From: mhall4400 vipmail kvcc edu Subject: Possible SDL bug Greetings I believe Ive come across a bug in your SDL product (1.2.9), in the CD-ROM control portion of the library. When calling the SDL_CDPlay() function to play the last track of a CD using the offset and length from an SDL_CD structure generated by SDL_CDOpen(), I get the following error from a call to SDL_Error(): mciSendCommand() error: The specified parameter is out of range for the specified command. The code returning the error is: SDL_CDPlay(g_playingDriveSDLCD, g_playingDriveSDLCD->track[trackNumberInt].offset, g_playingDriveSDLCD->track[trackNumberInt].length) Subtracting one from the length of the provided length seems to repair the problem: SDL_CDPlay(g_playingDriveSDLCD, g_playingDriveSDLCD->track[trackNumberInt].offset, (g_playingDriveSDLCD->track[trackNumberInt].length) - 1) Ive replicated this problem on Windows 98 SE (several months since last patch), fully-patched Window ME, seldom-patched Windows XP SP1, and fully-patched Windows XP SP2. While investigating the issue, I came across a line in your librarys win32 source code in file \src\cdrom\win32\SDL_syscdrom.c (source code zip archive from your download page), function: SDL_SYS_CDGetTOC(), line 226 where you add 1 to the value for length to fix MCI last track length bug. This may be the source of the issue (because subtracting 1 from the length seems to resolve the issue). Microsoft may have patched the referenced bug since you wrote that line. Mike Hall
author Sam Lantinga <slouken@libsdl.org>
date Tue, 14 Mar 2006 05:34:39 +0000
parents b9f034536fa0
children f02e673ffc5f
rev   line source
1361
19418e4422cb New configure-based build system. Still work in progress, but much improved
Sam Lantinga <slouken@libsdl.org>
parents: 150
diff changeset
1
19418e4422cb New configure-based build system. Still work in progress, but much improved
Sam Lantinga <slouken@libsdl.org>
parents: 150
diff changeset
2 Create stubs for all the disabled subsystems
19418e4422cb New configure-based build system. Still work in progress, but much improved
Sam Lantinga <slouken@libsdl.org>
parents: 150
diff changeset
3 Test all the platforms and drivers
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
4
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
5 Wish list for the 1.3 development branch:
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
6
2
836aaee3f39e *** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents: 0
diff changeset
7 * Use /etc/fb.modes, if available, like GGI does
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
8 * Add mousewheel events (new unified event architecture?)
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
9 * DirectInput joystick support needs to be implemented
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
10 * Be able to enumerate and select available audio and video drivers
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
11 * Fullscreen video mode support for MacOS X
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
12 * Explicit vertical retrace wait (maybe separate from SDL_Flip?)
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
13 * Shaped windows, windows without borders
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
14 * Multiple windows, multiple display support
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
15 * SDL_INIT_EVENTTHREAD on Windows and MacOS?
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
16 * Add a timestamp to events
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
17 * Use RDTSC for timer resolution on x86 hardware
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
18 * Add audio input API
2
836aaee3f39e *** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents: 0
diff changeset
19 * Add hardware accelerated scaled blit
836aaee3f39e *** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents: 0
diff changeset
20 * Add hardware accelerated alpha blits
836aaee3f39e *** empty log message ***
Sam Lantinga <slouken@lokigames.com>
parents: 0
diff changeset
21 * Redesign blitting architecture to allow blit plugins
0
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
22
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
23 In the jump from 1.2 to 1.3, we should change the SDL_Rect members to
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
24 int and evaluate all the rest of the datatypes. This is the only place
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
25 we should do it though, since the 1.2 series should not break binary
74212992fb08 Initial revision
Sam Lantinga <slouken@lokigames.com>
parents:
diff changeset
26 compatibility in this way.
150
df1d68818edb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 2
diff changeset
27
df1d68818edb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 2
diff changeset
28 Requests:
df1d68818edb *** empty log message ***
Sam Lantinga <slouken@libsdl.org>
parents: 2
diff changeset
29 * PCM and CDROM volume control (deprecated, but possible)