Mercurial > sdl-ios-xcode
view TODO @ 1524:38a12fd1a2c1
Fixed bug #46
Date: Fri, 13 Jan 2006 18:09:45 -0500
From: mhall4400 vipmail kvcc edu
Subject: Possible SDL bug
Greetings
I believe Ive come across a bug in your SDL product (1.2.9), in the CD-ROM
control portion of the library.
When calling the SDL_CDPlay() function to play the last track of a CD using the
offset and length from an SDL_CD structure generated by SDL_CDOpen(), I get the
following error from a call to SDL_Error():
mciSendCommand() error: The specified parameter is out of range for the
specified command.
The code returning the error is:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
g_playingDriveSDLCD->track[trackNumberInt].length)
Subtracting one from the length of the provided length seems to repair the
problem:
SDL_CDPlay(g_playingDriveSDLCD,
g_playingDriveSDLCD->track[trackNumberInt].offset,
(g_playingDriveSDLCD->track[trackNumberInt].length) - 1)
Ive replicated this problem on Windows 98 SE (several months since last
patch), fully-patched Window ME, seldom-patched Windows XP SP1, and
fully-patched Windows XP SP2.
While investigating the issue, I came across a line in your librarys win32
source code in file \src\cdrom\win32\SDL_syscdrom.c (source code zip archive
from your download page), function: SDL_SYS_CDGetTOC(), line 226 where you add
1 to the value for length to fix MCI last track length bug. This may be the
source of the issue (because subtracting 1 from the length seems to resolve the
issue). Microsoft may have patched the referenced bug since you wrote that
line.
Mike Hall
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 14 Mar 2006 05:34:39 +0000 |
parents | b9f034536fa0 |
children | f02e673ffc5f |
line wrap: on
line source
Create stubs for all the disabled subsystems Test all the platforms and drivers Wish list for the 1.3 development branch: * Use /etc/fb.modes, if available, like GGI does * Add mousewheel events (new unified event architecture?) * DirectInput joystick support needs to be implemented * Be able to enumerate and select available audio and video drivers * Fullscreen video mode support for MacOS X * Explicit vertical retrace wait (maybe separate from SDL_Flip?) * Shaped windows, windows without borders * Multiple windows, multiple display support * SDL_INIT_EVENTTHREAD on Windows and MacOS? * Add a timestamp to events * Use RDTSC for timer resolution on x86 hardware * Add audio input API * Add hardware accelerated scaled blit * Add hardware accelerated alpha blits * Redesign blitting architecture to allow blit plugins In the jump from 1.2 to 1.3, we should change the SDL_Rect members to int and evaluate all the rest of the datatypes. This is the only place we should do it though, since the 1.2 series should not break binary compatibility in this way. Requests: * PCM and CDROM volume control (deprecated, but possible)