Mercurial > pylearn

changeset 1384:b68f4d7e4df3

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
small old modif not commtited.
author Frederic Bastien <nouiz@nouiz.org>
date Tue, 14 Dec 2010 12:32:42 -0500
parents 0de66ab23dcc
children 8b857d141761
files doc/v2_planning/code_review.txt
diffstat 1 files changed, 23 insertions(+), 16 deletions(-) [+]
line wrap: on
line diff
--- a/doc/v2_planning/code_review.txt	Wed Dec 08 14:35:53 2010 -0500
+++ b/doc/v2_planning/code_review.txt	Tue Dec 14 12:32:42 2010 -0500
@@ -18,6 +18,25 @@
 Some system that we should check:
 ---------------------------------
 
+- `Review Board <http://www.reviewboard.org>`_
+    - Interesting, but some questions remain (how well it integrates with hg,
+      notably)
+    - Some advantages over Google code (comment on multi-line chunks, list of
+      unreviewed commits, more esthetics, handle many repo, keep assemble easily)
+    - Fred will install it so we can test it more thoroughly
+
+- `Google Code <http://code.google.com/p/support/wiki/CodeReviews>`_
+    - Test bench with a clone of Theano at
+      http://code.google.com/p/theanoclone/
+    - post-commit
+    - no list of not reviewed commit
+    - no python syntax highlight
+    - weird comment by line
+    - diff of merge seam bugged
+    - Maybe
+
+- `Kiln <http://fogcreek.com/Kiln/LearnMore.html?section=StartReviewsEffortlessly>`_
+
 - `rietveld <http://code.google.com/p/rietveld/>`_
     - Made by Guido van Rossum, seam basic and svn only
     - No, not enough features
@@ -26,13 +45,6 @@
     - git only
     - No
 
-- `Review Board <http://www.reviewboard.org>`_
-    - Interesting, but some questions remain (how well it integrates with hg,
-      notably)
-    - Some advantages over Google code (comment on multi-line chunks, list of
-      unreviewed commits, more esthetics, handle many repo, keep assemble easily)
-    - Fred will install it so we can test it more thoroughly
-
 - `Code Striker <http://codestriker.sourceforge.net/>`_
     - hg added? David told in May 2009 it can do it easily.
     - Seems less interesting than Review Board
@@ -45,21 +57,16 @@
     - Could be integrated with the current ticket system?, not maintained, review code in general, not commit.
     - No
 
+- `track CodeReviewPlugin <http://trac-hacks.org/wiki/CodeReviewPlugin/Concepts>`_
+
+- `track ExoWebCodeReviewPlugin <http://trac-hacks.org/wiki/ExoWebCodeReviewPlugin>`_
+
 - `feature request at assembla <http://feedback.assembla.com/forums/5433-feature-requests/suggestions/253297-add-a-code-review-tool-e-g-reviewboard->`_
     - No (we will not wait until the feature is added...)
 
 - `JCR <http://jcodereview.sourceforge.net/>`_
     - No
 
-- `Google Code <http://code.google.com/>`_
-    - Test bench with a clone of Theano at
-      http://code.google.com/p/theanoclone/
-    - post-commit
-    - no list of not reviewed commit
-    - no python syntax highlight
-    - weird comment by line
-    - diff of merge seam bugged
-    - Maybe
 
 What we could want from our code review
 ---------------------------------------