# HG changeset patch # User Frederic Bastien # Date 1292347962 18000 # Node ID b68f4d7e4df3330fef0f8c5fdb846ffe20922bc6 # Parent 0de66ab23dcc0c611c109fac7fdce77217fc4f1b small old modif not commtited. diff -r 0de66ab23dcc -r b68f4d7e4df3 doc/v2_planning/code_review.txt --- a/doc/v2_planning/code_review.txt Wed Dec 08 14:35:53 2010 -0500 +++ b/doc/v2_planning/code_review.txt Tue Dec 14 12:32:42 2010 -0500 @@ -18,6 +18,25 @@ Some system that we should check: --------------------------------- +- `Review Board `_ + - Interesting, but some questions remain (how well it integrates with hg, + notably) + - Some advantages over Google code (comment on multi-line chunks, list of + unreviewed commits, more esthetics, handle many repo, keep assemble easily) + - Fred will install it so we can test it more thoroughly + +- `Google Code `_ + - Test bench with a clone of Theano at + http://code.google.com/p/theanoclone/ + - post-commit + - no list of not reviewed commit + - no python syntax highlight + - weird comment by line + - diff of merge seam bugged + - Maybe + +- `Kiln `_ + - `rietveld `_ - Made by Guido van Rossum, seam basic and svn only - No, not enough features @@ -26,13 +45,6 @@ - git only - No -- `Review Board `_ - - Interesting, but some questions remain (how well it integrates with hg, - notably) - - Some advantages over Google code (comment on multi-line chunks, list of - unreviewed commits, more esthetics, handle many repo, keep assemble easily) - - Fred will install it so we can test it more thoroughly - - `Code Striker `_ - hg added? David told in May 2009 it can do it easily. - Seems less interesting than Review Board @@ -45,21 +57,16 @@ - Could be integrated with the current ticket system?, not maintained, review code in general, not commit. - No +- `track CodeReviewPlugin `_ + +- `track ExoWebCodeReviewPlugin `_ + - `feature request at assembla `_ - No (we will not wait until the feature is added...) - `JCR `_ - No -- `Google Code `_ - - Test bench with a clone of Theano at - http://code.google.com/p/theanoclone/ - - post-commit - - no list of not reviewed commit - - no python syntax highlight - - weird comment by line - - diff of merge seam bugged - - Maybe What we could want from our code review ---------------------------------------