log

age author description
Mon, 30 Sep 2013 23:38:28 +0600 Ritor1 DrawBuff_remaind_time_string and DrawShops_next_generation_time_string fix and cleared
Mon, 30 Sep 2013 18:25:14 +0600 Ritor1 UITransition.cpp cleared
Mon, 30 Sep 2013 18:06:01 +0600 Ritor1 Merge
Mon, 30 Sep 2013 18:05:50 +0600 Ritor1 m
Mon, 30 Sep 2013 17:29:27 +0600 Ritor1 UITransition.cpp cleaning(continue)
Mon, 30 Sep 2013 11:41:55 +0600 Ritor1 Слияние
Mon, 30 Sep 2013 11:41:36 +0600 Ritor1 MagicShop cleared
Mon, 30 Sep 2013 09:30:42 +0600 Ritor1 Слияние
Mon, 30 Sep 2013 09:30:31 +0600 Ritor1 m
Mon, 30 Sep 2013 06:09:29 +0200 Grumpy7 Finishing member struct renaming
Mon, 30 Sep 2013 05:59:06 +0200 Grumpy7 Merge
Mon, 30 Sep 2013 05:48:32 +0200 Grumpy7 Party_stru0 renamed to PartyTimeStruct, fixed its members, renamed Party::field_3C to Party::PartyTimes, started Player::SetVariable refactoring start
Sun, 29 Sep 2013 21:32:47 +0600 Ritor1 AlchemistDialog() cleared
Fri, 27 Sep 2013 18:58:48 +0600 Ritor1 Merge
Fri, 27 Sep 2013 18:58:25 +0600 Ritor1 m
Thu, 26 Sep 2013 23:42:25 +0600 Ritor1 Merge
Thu, 26 Sep 2013 23:42:06 +0600 Ritor1 fixing
Fri, 27 Sep 2013 17:33:05 +0600 Ritor1 ArmorShop cleaning(continue)
Fri, 27 Sep 2013 15:19:46 +0600 Ritor1 Слияние
Fri, 27 Sep 2013 15:19:32 +0600 Ritor1 WeaponShop cleared
Fri, 27 Sep 2013 10:08:01 +0200 Grumpy7 added small renaming note
Fri, 27 Sep 2013 10:05:25 +0200 Grumpy7 Merge
Fri, 27 Sep 2013 10:04:45 +0200 Grumpy7 Player::CompareVariable finished, renamed stru_5E4C90 to stru_5E4C90_MapPersistVars, party::field_4A0 to party::CounterEventValues
Thu, 26 Sep 2013 17:39:39 +0600 Ritor1 Draw SaveLoadWindow
Thu, 26 Sep 2013 14:17:34 +0600 Ritor1 Слияние
Thu, 26 Sep 2013 14:17:25 +0600 Ritor1 alchemy fix
Thu, 26 Sep 2013 08:09:05 +0200 Grumpy7 Merge
Thu, 26 Sep 2013 08:07:50 +0200 Grumpy7 Player::CompareVariable cleanup first round
Wed, 25 Sep 2013 17:31:39 +0600 Ritor1 m
Wed, 25 Sep 2013 17:29:14 +0600 Ritor1 pop-up window in character(paperdill) window, alchemy
Wed, 25 Sep 2013 12:54:34 +0600 Ritor1 Слияние
Wed, 25 Sep 2013 12:54:27 +0600 Ritor1 m
Wed, 25 Sep 2013 12:22:38 +0600 Ritor1 Слияние
Wed, 25 Sep 2013 12:22:32 +0600 Ritor1 m
Wed, 25 Sep 2013 11:13:16 +0600 Ritor1 Слияние
Wed, 25 Sep 2013 11:13:08 +0600 Ritor1 m
Wed, 25 Sep 2013 11:12:49 +0600 Ritor1 m
Wed, 25 Sep 2013 09:03:56 +0600 Ritor1 Слияние
Wed, 25 Sep 2013 08:59:01 +0600 Ritor1 m
Tue, 24 Sep 2013 09:44:03 +0600 Ritor1 Слияние
Tue, 24 Sep 2013 09:43:58 +0600 Ritor1 m
Wed, 25 Sep 2013 08:39:03 +0200 Grumpy7 fixing bugs introduced by me :)
Wed, 25 Sep 2013 08:13:09 +0200 Grumpy7 fixing itemequiptype instead of playerskilltype
Wed, 25 Sep 2013 07:11:43 +0200 Grumpy7 Merge
Wed, 25 Sep 2013 07:11:16 +0200 Grumpy7 Item getter functions to reduce the number of ugly array accesses, fixing a bug with Player::setrecoverytime
Tue, 24 Sep 2013 23:40:33 +0600 Ritor1 UIRest cleared
Tue, 24 Sep 2013 23:18:57 +0600 Ritor1 Merge
Tue, 24 Sep 2013 23:18:38 +0600 Ritor1 RestUI_Draw()
Tue, 24 Sep 2013 07:32:24 +0200 Grumpy7 Merge
Tue, 24 Sep 2013 07:29:55 +0200 Grumpy7 ITEM_ENCHANTED to ITEM_HARDENED, created helper functions to get params from itemtable for ItemGens
Mon, 23 Sep 2013 07:07:06 +0200 Grumpy7 Moving NZIArray to a separate class, fixing a few inventory bugs
Mon, 23 Sep 2013 23:00:07 +0200 Nomad Merge
Mon, 23 Sep 2013 22:58:32 +0200 Nomad Fixed window shrink due to menu
Mon, 23 Sep 2013 17:33:12 +0600 Ritor1 MonsterPopup
Mon, 23 Sep 2013 09:34:23 +0600 Ritor1 Слияние
Mon, 23 Sep 2013 09:33:13 +0600 Ritor1 m
Sun, 22 Sep 2013 19:48:02 +0200 Grumpy7 fixing paperdoll bug
Sun, 22 Sep 2013 18:10:35 +0200 Grumpy7 Merge
Sun, 22 Sep 2013 18:09:44 +0200 Grumpy7 adding comments
Sun, 22 Sep 2013 20:38:24 +0600 Ritor1 MonsterPopup_Draw
Sun, 22 Sep 2013 16:45:46 +0600 Ritor1 Merge
Sun, 22 Sep 2013 16:45:25 +0600 Ritor1 m
Sun, 22 Sep 2013 10:51:08 +0200 Grumpy7 Merge
Sun, 22 Sep 2013 10:44:42 +0200 Grumpy7 Player::ReceiveSpecialAttackEffect finishing cleanup, special attack type enum created
Sun, 22 Sep 2013 10:04:33 +0200 Grumpy7 Player::_48DCF6 renamed to Player::ReceiveSpecialAttackEffect second attempt
Sun, 22 Sep 2013 10:04:00 +0200 Grumpy7 Player::_48DCF6 renamed to Player::ReceiveSpecialAttackEffect, some case reordering, fixing getting only disease3 instead of disease1 and ignoring disease2 and 3, uSpecialAttack to uSpecialAttackType, uSpecialAttackType to uSpecialAttackLevel
Sun, 22 Sep 2013 09:36:38 +0200 Grumpy7 Player::_48DCF6 cycle and unused var cleanup
Sun, 22 Sep 2013 08:37:41 +0200 Grumpy7 Player::_48DCF6 substituted unnecessary vars by their values
Sun, 22 Sep 2013 07:57:16 +0200 Grumpy7 Player::_48DCF6 label removal
Sun, 22 Sep 2013 07:34:02 +0200 Grumpy7 Player::_48DCF6 fixing use of uninitialized vars
Sun, 22 Sep 2013 04:31:34 +0200 Grumpy7 Player::StealFromActor finishing cleanup
Sun, 22 Sep 2013 03:12:11 +0200 Grumpy7 Player::StealFromActor cleanup, renamed UIMSG_1B to UIMSG_STEALFROMACTOR
Sat, 21 Sep 2013 18:48:10 +0200 Grumpy7 Player::StealFromShop finishing cleanup
Sat, 21 Sep 2013 12:38:43 +0200 Grumpy7 Player::StealFromShop started cleanup, fixing a few errors caused by not commiting everything
Fri, 20 Sep 2013 10:51:42 +0200 Grumpy7 Fixing a few warnings in Players.cpp
Fri, 20 Sep 2013 10:34:07 +0200 Grumpy7 moving OnInventoryLeftClick to Player::
Fri, 20 Sep 2013 10:23:54 +0200 Grumpy7 OnInventoryLeftClick cleanup
Thu, 19 Sep 2013 08:26:28 +0200 Grumpy7 DamagePlayerFromMonster reducing variable scope
Fri, 20 Sep 2013 14:55:53 +0200 Nomad Merge
Fri, 20 Sep 2013 14:45:44 +0200 Nomad Cosmetics
Fri, 20 Sep 2013 17:31:37 +0600 Ritor1 DrawPopupWindow
Fri, 20 Sep 2013 14:31:42 +0600 Ritor1 PlayerCreationUI_Draw()
Thu, 19 Sep 2013 17:58:56 +0600 Ritor1 GameMenuUI_DrawKeyBindings() and GameMenuUI_DrawVideoOptions() cleared
Thu, 19 Sep 2013 16:45:21 +0600 Ritor1 MainMenuUI_Credits_Loop() and CreditsTextureScroll
Thu, 19 Sep 2013 09:29:30 +0600 Ritor1 Слияние
Thu, 19 Sep 2013 09:29:04 +0600 Ritor1 m
Wed, 18 Sep 2013 20:36:18 +0600 Ritor1 GameUI_DrawDialogue()
Wed, 18 Sep 2013 20:04:49 +0600 Ritor1 Merge
Wed, 18 Sep 2013 20:04:30 +0600 Ritor1 m
Tue, 17 Sep 2013 22:55:48 +0600 Ritor1 Merge
Tue, 17 Sep 2013 22:55:34 +0600 Ritor1 m
Wed, 18 Sep 2013 17:23:54 +0600 Ritor1 MainMenuUI_Credits_Loop() cleaning(continue)
Wed, 18 Sep 2013 16:20:15 +0600 Ritor1 MainMenuUI_Create() cleared
Wed, 18 Sep 2013 14:53:59 +0600 Ritor1 m
Wed, 18 Sep 2013 14:30:23 +0600 Ritor1 Слияние
Wed, 18 Sep 2013 14:29:52 +0600 Ritor1 m
Wed, 18 Sep 2013 14:20:00 +0600 Ritor1 Слияние
Wed, 18 Sep 2013 14:19:37 +0600 Ritor1 NPCTopics
Wed, 18 Sep 2013 11:24:03 +0200 Nomad Merge
Wed, 18 Sep 2013 11:23:41 +0200 Nomad .
Wed, 18 Sep 2013 10:23:47 +0200 Grumpy7 Merge
Wed, 18 Sep 2013 10:22:16 +0200 Grumpy7 DamagePlayerFromMonster continuing cleanup, part 3
Wed, 18 Sep 2013 09:06:28 +0200 Grumpy7 DamagePlayerFromMonster continuing cleanup, part 2
Wed, 18 Sep 2013 11:13:38 +0200 Nomad Window Resize (change arguments to MM7_Initialize)
Wed, 18 Sep 2013 11:05:06 +0600 Ritor1 Слияние
Wed, 18 Sep 2013 11:04:47 +0600 Ritor1 NPCGreetings
Wed, 18 Sep 2013 09:21:38 +0600 Ritor1 Слияние
Wed, 18 Sep 2013 09:21:32 +0600 Ritor1 m
Wed, 18 Sep 2013 06:32:15 +0200 Grumpy7 Merge
Wed, 18 Sep 2013 06:30:53 +0200 Grumpy7 DamagePlayerFromMonster continuing cleanup
Tue, 17 Sep 2013 07:30:41 +0200 Grumpy7 DamagePlayerFromMonster starting cleanup
Sun, 15 Sep 2013 03:08:12 +0200 Grumpy7 _43ED6F_check_party_races to IsDwarfPresentInParty
Tue, 17 Sep 2013 23:10:07 +0200 Nomad Merge
Tue, 17 Sep 2013 22:10:06 +0200 Nomad Scavenger Hunt dialogue crash fix.
Tue, 17 Sep 2013 21:41:39 +0200 Nomad Fixed Celestia sky a bit.
Tue, 17 Sep 2013 19:24:23 +0100 zipi fixpoint functions renaming
Tue, 17 Sep 2013 20:15:56 +0200 Nomad More camera unifications.
Tue, 17 Sep 2013 18:39:32 +0200 Nomad Excess wrapper (IndoorLocation_drawstru) removed.
Tue, 17 Sep 2013 17:40:59 +0200 Nomad Some common code from ODM and BLV RenderParams moved to IndoorCameraD3D
Tue, 17 Sep 2013 15:40:36 +0200 Nomad Merge
Tue, 17 Sep 2013 15:40:09 +0200 Nomad class IndoorCamera split into BLVRenderParams and ODMRenderParams
Tue, 17 Sep 2013 14:10:41 +0200 Nomad class OutdoorCamera -> ODMRenderParams
Tue, 17 Sep 2013 17:34:31 +0600 Ritor1 SimpleHouseDialog cleaning(continue)
Tue, 17 Sep 2013 16:30:43 +0600 Ritor1 Слияние
Tue, 17 Sep 2013 16:30:36 +0600 Ritor1 m
Tue, 17 Sep 2013 12:40:37 +0200 Nomad Merge
Tue, 17 Sep 2013 12:37:07 +0200 Nomad Out of bounds (id 65536) texture fixed.
Tue, 10 Sep 2013 21:17:00 +0200 Nomad operator new() -> malloc
Tue, 17 Sep 2013 13:20:58 +0600 Ritor1 TavernDialog cleared
Mon, 16 Sep 2013 09:37:30 +0600 Ritor1 Слияние
Mon, 16 Sep 2013 09:37:08 +0600 Ritor1 m
Fri, 13 Sep 2013 10:10:53 +0600 Ritor1 Слияние
Fri, 13 Sep 2013 10:10:44 +0600 Ritor1 m
Mon, 16 Sep 2013 01:14:17 +0600 Ritor1 TrainingDialog cleaning(continue)
Sun, 15 Sep 2013 19:19:43 +0600 Ritor1 TampleDialog() cleaning
Sun, 15 Sep 2013 19:12:41 +0600 Ritor1 Merge
Sun, 15 Sep 2013 19:12:34 +0600 Ritor1 m
Sun, 15 Sep 2013 02:21:26 +0200 Grumpy7 Merge
Sun, 15 Sep 2013 02:20:06 +0200 Grumpy7 sub_43EE77_ProbablyIfUnderwaterSuitIsEquipped to Player::HasUnderwaterSuitEquipped, sub_43EDB9_get_some_race_sex_relation_2 to ShouldLoadTexturesForRaceAndGender, Player_has_item to Player::HasItem
Sat, 14 Sep 2013 19:09:44 +0200 Grumpy7 Player::EquipBody cleaned up
Sat, 14 Sep 2013 07:21:56 +0200 Grumpy7 Player::UseItem_DrinkPotion_etc some minor edits(brace indentation, a few warnings), commented out 2 sections which never get used
Sat, 14 Sep 2013 06:56:05 +0200 Grumpy7 Player::GetRace cleaned up + removed a few unused vars
Sat, 14 Sep 2013 22:43:45 +0100 zipi mul <> sub0 difference
Sat, 14 Sep 2013 22:02:56 +0100 zipi AI visibility issue temporarily fixed
Sun, 15 Sep 2013 00:46:00 +0600 Ritor1 m
Sun, 15 Sep 2013 00:41:51 +0600 Ritor1 Слияние
Sun, 15 Sep 2013 00:41:34 +0600 Ritor1 TampleDialog(cleaning continue)
Sat, 14 Sep 2013 10:28:23 +0600 Ritor1 Слияние
Sat, 14 Sep 2013 10:28:13 +0600 Ritor1 m
Thu, 12 Sep 2013 11:55:16 +0600 Ritor1 Слияние
Thu, 12 Sep 2013 11:55:04 +0600 Ritor1 JailDialog
Wed, 11 Sep 2013 00:16:58 +0600 Ritor1 Слияние
Wed, 11 Sep 2013 00:16:49 +0600 Ritor1 m
Sat, 14 Sep 2013 06:46:12 +0200 Grumpy7 Player::GetMagicalBonus cleaned up, identified a few player only effect spells used in mm6
Sat, 14 Sep 2013 06:04:18 +0200 Grumpy7 Moved enchantment attribute bonus list to items.cpp/h, created static function that create the enchantments + helper functions to get the enchantment strength, moved the whole logic of Player::GetItemsBonus to a case
Thu, 12 Sep 2013 09:58:07 +0200 Grumpy7 Merge
Thu, 12 Sep 2013 09:55:20 +0200 Grumpy7 Merge
Thu, 12 Sep 2013 09:53:41 +0200 Grumpy7 started extracting enchantment effects to a helper class
Wed, 11 Sep 2013 04:27:36 +0200 Grumpy7 stru350::sub_451007_scale_image_bicubic - fixing a memory access bug
Tue, 10 Sep 2013 08:31:04 +0200 Grumpy7 Player::GetItemsBonus removed majority of labels
Tue, 10 Sep 2013 04:16:54 +0200 Grumpy7 _48EA46_calc_special_bonus_by_items renamed to GetSpecialItemBonus, forgot to commit actor.cpp
Tue, 10 Sep 2013 04:08:15 +0200 Grumpy7 Player::GetActualResistance cleaned up, some minor changes in Player::Recover, _48EA46_calc_special_bonus_by_items renamed to GetSpecialItemBonus
Tue, 10 Sep 2013 03:25:28 +0200 Grumpy7 Merge
Tue, 10 Sep 2013 03:25:15 +0200 Grumpy7 Player::GetBaseResistance cleanup, setting default parameter to Player::GetItemsBonus
Sun, 08 Sep 2013 08:10:09 +0200 Grumpy7 Player::GetMaxHealth, GetBaseAC, GetActualAC minor cleanups
Sun, 08 Sep 2013 08:01:05 +0200 Grumpy7 Player::GetAttackRecoveryTime removing label, fixing shield skill being ignored, fixing haste being ignored
Wed, 11 Sep 2013 18:01:30 +0600 Ritor1 Слияние
Wed, 11 Sep 2013 18:01:16 +0600 Ritor1 Boat dialogue
Wed, 11 Sep 2013 09:39:09 +0600 Ritor1 Слияние
Wed, 11 Sep 2013 09:23:41 +0600 Ritor1 m
Mon, 09 Sep 2013 09:13:40 +0600 Ritor1 Слияние
Mon, 09 Sep 2013 09:13:23 +0600 Ritor1 m
Wed, 11 Sep 2013 13:53:05 +0200 yoctozepto Replace minor Windows constants.
Tue, 10 Sep 2013 21:08:43 +0200 Nomad Merge
Tue, 10 Sep 2013 21:08:06 +0200 Nomad Merge
Tue, 10 Sep 2013 21:07:07 +0200 Nomad Allocator (CMemory) bye-bye
Wed, 11 Sep 2013 00:11:18 +0600 Ritor1 _4B3FE5_training_dialogue
Tue, 10 Sep 2013 23:45:55 +0600 Ritor1 Слияние
Tue, 10 Sep 2013 23:42:03 +0600 Ritor1 m
Tue, 10 Sep 2013 19:34:00 +0300 Beri Levi berilevi merge
Tue, 10 Sep 2013 19:33:21 +0300 Beri Levi berilevi workaround for crash on startup
Tue, 10 Sep 2013 18:43:52 +0200 Nomad OnInventoryItemRightClick logic restored
Tue, 10 Sep 2013 12:54:07 +0200 Nomad More OnInventoryItemRightClick (not finished)
Mon, 09 Sep 2013 20:09:01 +0200 Nomad OnInventoryItemRightClick
Mon, 09 Sep 2013 17:17:53 +0200 Nomad Here and there cleanings.
Sun, 08 Sep 2013 19:16:37 +0600 Ritor1 BankDialog() cleaned
Sun, 08 Sep 2013 17:07:58 +0600 Ritor1 Слияние
Sun, 08 Sep 2013 17:07:47 +0600 Ritor1 m
Mon, 02 Sep 2013 18:49:26 +0600 Ritor1 Слияние
Mon, 02 Sep 2013 18:49:18 +0600 Ritor1 m
Sun, 08 Sep 2013 07:28:20 +0200 Grumpy7 Fixing compiler warnings
Sun, 08 Sep 2013 05:22:33 +0200 Grumpy7 Player::ReceiveDamage, very small edits; prepended "Is" to item functions returning bool values (broken, indetified, stolen)
Sun, 08 Sep 2013 04:11:10 +0200 Grumpy7 undoing 1481
Sun, 08 Sep 2013 04:10:22 +0200 Grumpy7 fixing Player::GetMeleeDamageString and Player::CanTrainToNextLevel
Sun, 08 Sep 2013 03:27:10 +0200 Grumpy7 fixing compilation error
Sun, 08 Sep 2013 02:41:10 +0200 Grumpy7 splitting Player::WearsItem into two functions
Sun, 08 Sep 2013 01:23:37 +0200 Grumpy7 Merge
Sun, 08 Sep 2013 01:17:33 +0200 Grumpy7 Player::IsUnarmed fixing condition
Sun, 08 Sep 2013 01:03:04 +0200 Grumpy7 Player::CalculateIncommingDamage, liches shouldn't be immune to damage if above 200 resistance to it
Sun, 08 Sep 2013 00:35:03 +0200 Grumpy7 Player::CanTrainToNextLevel simplified, Player::GetExperienceDisplayColor shortened a bit Player::CalculateIncommingDamage + fixed resistances not working if no resistance bonus (ignored luck bonus)
Sat, 07 Sep 2013 23:06:13 +0200 Grumpy7 Changed the new Assert macro definition slightly, Party::AddItem (for some reason in players.cpp) renamed to Party::AddItemToParty, cleaned up; some unused variables in previous functions removed
Sat, 07 Sep 2013 22:46:18 +0200 Nomad Merge
Sat, 07 Sep 2013 22:38:53 +0200 Nomad Some more cleaning
Sat, 07 Sep 2013 21:17:47 +0200 Grumpy7 Minor assert fixes in players.cpp
Sat, 07 Sep 2013 21:14:48 +0200 Grumpy7 Merge
Sat, 07 Sep 2013 21:00:02 +0200 Grumpy7 Get(skillname) functions cleaned up, using GetMultiplierForSkillLevel instead of nested conditions
Sat, 07 Sep 2013 10:49:42 +0200 Grumpy7 Player::CanFitItem, AddItem, AddItem2 changed changed the retarded 2 dimensional array traversal, changed GetActualAttribute input parameters to get rid of the attrid case
Sat, 07 Sep 2013 10:04:37 +0200 Grumpy7 Player::CalculateRangedDamageTo, finishing cleanup accidentally commited in previous commit
Sat, 07 Sep 2013 09:45:09 +0200 Grumpy7 Player::CalculateMeleeDamageTo extracted 2 almost identical sections to a separate function, variable cleanup, changed parameter types
Sat, 07 Sep 2013 09:16:55 +0200 Grumpy7 Player::CalculateMeleeDamageTo removed labels, ifdowhile patterns changed to for cycles, magic numbers to enum values, fixing gibbet being only undead slaying
Sat, 07 Sep 2013 08:17:49 +0200 Grumpy7 added a few artifacts to enum ITEM_TYPE
Sat, 07 Sep 2013 06:51:56 +0200 Grumpy7 Player::GetRangedDamageString fix + some small chnages
Sat, 07 Sep 2013 21:55:02 +0200 Nomad stru141 & misc cleaning
Sat, 07 Sep 2013 20:05:20 +0200 Nomad assert, Abortf, AbortWithError -> Assert, Error
Sat, 07 Sep 2013 15:20:57 +0200 Nomad stru149
Sat, 07 Sep 2013 13:26:15 +0200 Nomad Merge2
Sat, 07 Sep 2013 13:03:18 +0200 Nomad Merge
Sat, 07 Sep 2013 12:51:06 +0200 Nomad mm8 icons
Sat, 07 Sep 2013 05:23:16 +0200 Grumpy7 Merge
Sat, 07 Sep 2013 05:18:32 +0200 Grumpy7 Player:GetSkillBonus cleanup, added back some brackets, because of var declarations, moved here CHARACTER_ATTRIBUTE_RANGED_DMG_BONUS from GetRangedDamageMin and GetRangedDamageMax
Sat, 07 Sep 2013 05:06:15 +0200 Grumpy7 Player:GetSkillBonus cleanup, minor edits
Sat, 07 Sep 2013 05:01:12 +0200 Grumpy7 Player:GetSkillBonus cleanup, multiplier evaluation moved to a separate function, variable clanup, renaming, scope reduction
Sat, 07 Sep 2013 04:15:06 +0200 Grumpy7 Player:GetSkillBonus cleanup, undoing part of previous changeset to better track file modifications
Sat, 07 Sep 2013 04:13:22 +0200 Grumpy7 Player::GetSkillBonus continuing cleanup