Mercurial > sdl-ios-xcode
changeset 4543:d7cdc25af9a2 SDL-1.2
Better fix for bug 936
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 18 Jul 2010 10:28:57 -0700 |
parents | abb56f7699ea |
children | 3f2d351d8274 |
files | src/video/SDL_stretch.c |
diffstat | 1 files changed, 8 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/src/video/SDL_stretch.c Sun Jul 18 10:08:06 2010 -0700 +++ b/src/video/SDL_stretch.c Sun Jul 18 10:28:57 2010 -0700 @@ -78,7 +78,7 @@ int i; int pos, inc; - unsigned char *eip, *end; + unsigned char *eip, *fence; unsigned char load, store; /* See if we need to regenerate the copy buffer */ @@ -115,15 +115,21 @@ pos = 0x10000; inc = (src_w << 16) / dst_w; eip = copy_row; - end = copy_row+sizeof(copy_row); + fence = copy_row+sizeof(copy_row)-2; for ( i=0; i<dst_w && eip < end; ++i ) { while ( pos >= 0x10000L ) { + if ( eip == fence ) { + return -1; + } if ( bpp == 2 ) { *eip++ = PREFIX16; } *eip++ = load; pos -= 0x10000L; } + if ( eip == fence ) { + return -1; + } if ( bpp == 2 ) { *eip++ = PREFIX16; } @@ -132,11 +138,6 @@ } *eip++ = RETURN; - /* Verify that we didn't overflow (too late!!!) */ - if ( i < dst_w ) { - SDL_SetError("Copy buffer too small"); - return(-1); - } #ifdef HAVE_MPROTECT /* Make the code executable but not writeable */ if ( mprotect(copy_row, sizeof(copy_row), PROT_READ|PROT_EXEC) < 0 ) {