Mercurial > sdl-ios-xcode
view src/thread/beos/SDL_systhread.c @ 5130:f2c2f0ecba5f
Fixed bug #1111
kwm@rainbow-runner.nl 2011-01-30 06:28:27 PST
Created attachment 562 [details]
Build fix with clang.
When building sdl 1.2.14 with the Clang compiler http://clang.llvm.org .
The build fails in src/video/mmx.h with the following error:
--------------------------------------------------
./src/video/SDL_RLEaccel.c:831:5: error: invalid operand for instruction
CHOOSE_BLIT(RLECLIPBLIT, alpha, fmt);
^
./src/video/SDL_RLEaccel.c:831:17: note: instantiated from:
CHOOSE_BLIT(RLECLIPBLIT, alpha, fmt);
^
./src/video/SDL_RLEaccel.c:831:5: note: instantiated from:
CHOOSE_BLIT(RLECLIPBLIT, alpha, fmt);
^
./src/video/SDL_RLEaccel.c:647:23: note: instantiated from:
blitter(2, Uint8, ALPHA_BLIT16_565MMX); \
^
./src/video/SDL_RLEaccel.c:282:4: note: instantiated from:
movq_r2m(mm3, *dstp); \
^
In file included from ./src/video/SDL_RLEaccel.c:99:
./src/video/mmx.h:379:28: note: instantiated from:
#define movq_r2m(reg, var) mmx_r2m(movq, reg, var)
^
<scratch space>:192:1: note: instantiated from:
"movq"
^
<inline asm>:1:2: note: instantiated into assembly here
movq %mm3, %dx
^
--------------------------------------------------
According to the clang developers this is a invalid inline assembly.
Using the attached patch from the last commit in the below bug report fixes the
compile.
More details from: http://llvm.org/bugs/show_bug.cgi?id=6730
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 30 Jan 2011 13:42:05 -0800 |
parents | f7b03b6838cb |
children | b530ef003506 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* BeOS thread management routines for SDL */ #include <stdio.h> #include <signal.h> #include <be/kernel/OS.h> #include "SDL_mutex.h" #include "SDL_thread.h" #include "../SDL_thread_c.h" #include "../SDL_systhread.h" static int sig_list[] = { SIGHUP, SIGINT, SIGQUIT, SIGPIPE, SIGALRM, SIGTERM, SIGWINCH, 0 }; void SDL_MaskSignals(sigset_t * omask) { sigset_t mask; int i; sigemptyset(&mask); for (i = 0; sig_list[i]; ++i) { sigaddset(&mask, sig_list[i]); } sigprocmask(SIG_BLOCK, &mask, omask); } void SDL_UnmaskSignals(sigset_t * omask) { sigprocmask(SIG_SETMASK, omask, NULL); } static int32 RunThread(void *data) { SDL_RunThread(data); return (0); } int SDL_SYS_CreateThread(SDL_Thread * thread, void *args) { /* Create the thread and go! */ thread->handle = spawn_thread(RunThread, "SDL", B_NORMAL_PRIORITY, args); if ((thread->handle == B_NO_MORE_THREADS) || (thread->handle == B_NO_MEMORY)) { SDL_SetError("Not enough resources to create thread"); return (-1); } resume_thread(thread->handle); return (0); } void SDL_SYS_SetupThread(void) { /* Mask asynchronous signals for this thread */ SDL_MaskSignals(NULL); } SDL_threadID SDL_ThreadID(void) { return ((SDL_threadID) find_thread(NULL)); } void SDL_SYS_WaitThread(SDL_Thread * thread) { status_t the_status; wait_for_thread(thread->handle, &the_status); } /* vi: set ts=4 sw=4 expandtab: */