view test/testmmousetablet.c @ 3539:f2846bf19360

Fixed bug #896 John Popplewell 2009-12-08 23:05:50 PST Originally reported by AKFoerster on the mailing list. Error decoding UTF8 Russian text to UTF-16LE on Windows, but specifically on platforms without iconv support (the default on Windows). Valid UTF8 characters are flagged as being overlong and then substituted by the UNKNOWN_UNICODE character. After studying the testiconv.c example program, reading the RFCs and putting some printf statements in SDL_iconv.c the problem is in a test for 'Maximum overlong sequences', specifically 4.2.1, which is carried out by the following code: } else if ( p[0] >= 0xC0 ) { if ( (p[0] & 0xE0) != 0xC0 ) { /* Skip illegal sequences return SDL_ICONV_EILSEQ; */ ch = UNKNOWN_UNICODE; } else { if ( (p[0] & 0xCE) == 0xC0 ) { <<<<<<<< here overlong = SDL_TRUE; } ch = (Uint32)(p[0] & 0x1F); left = 1; } } else { Here is the 2-byte encoding of a character in range 00000080 - 000007FF 110xxxxx 10xxxxxx The line in question is supposed to be checking for an overlong sequence which would be less than 11000001 10111111 which should be represented as a single byte. BUT, the mask value (0xCE) is wrong, it isn't checking the top-most bit: 11000001 value 11001110 mask (incorrect) ^ and should be (0xDE): 11000001 value 11011110 mask (correct) making the above code: } else if ( p[0] >= 0xC0 ) { if ( (p[0] & 0xE0) != 0xC0 ) { /* Skip illegal sequences return SDL_ICONV_EILSEQ; */ ch = UNKNOWN_UNICODE; } else { if ( (p[0] & 0xDE) == 0xC0 ) { <<<<<<<< here overlong = SDL_TRUE; } ch = (Uint32)(p[0] & 0x1F); left = 1; } } else { I can supply a test program and/or a patch if required, best regards, John Popplewell
author Sam Lantinga <slouken@libsdl.org>
date Fri, 11 Dec 2009 08:03:43 +0000
parents 975fd903466b
children
line wrap: on
line source

#include <stdio.h>
#include "SDL.h"

SDL_Surface *screen;
int quit = 0;

int
main(int argc, char *argv[])
{
    SDL_Event event;
    int mice;
    int i;
    printf("Initing...\n");
    if (SDL_Init(0) != 0) {
        return 1;
    }
    if (SDL_InitSubSystem(SDL_INIT_VIDEO) != 0) {
        return 1;
    } else {
        screen = SDL_SetVideoMode(640, 480, 32, SDL_DOUBLEBUF);
    }
    mice = SDL_GetNumMice();
    printf("%d pointing devices found\n", mice);
    for (i = 0; i < mice; ++i) {
        printf("device index: %d name:%s\n", i, SDL_GetMouseName(i));
    }
    while (quit != 1) {
        if (SDL_PollEvent(&event) == 0) {
        } else {
            switch (event.type) {
            case SDL_MOUSEMOTION:
                printf
                    ("Device id: %d x: %d y: %d relx: %d rely: %d pressure: %d\n \
					pressure_max: %d pressure_min: %d current cursor:%d\n",
                     event.motion.which, event.motion.x, event.motion.y, event.motion.xrel, event.motion.yrel,
                     event.motion.pressure, event.motion.pressure_max, event.motion.pressure_min,
                     event.motion.cursor);
                break;
            case SDL_PROXIMITYIN:
                printf("proximity in id: %d x: %d y: %d\n",
                       (int) event.proximity.which, event.proximity.x,
                       event.proximity.y);
                break;
            case SDL_PROXIMITYOUT:
                printf("proximity out id: %d x: %d y: %d\n",
                       (int) event.proximity.which, event.proximity.x,
                       event.proximity.y);
                break;
            case SDL_MOUSEBUTTONDOWN:
                printf("mouse button down id: %d button:%d\n",
                       event.button.which, event.button.button);
                break;
            case SDL_MOUSEBUTTONUP:
                printf("mouse button up id: %d button: %d\n",
                       event.button.which, event.button.button);
                break;
            case SDL_QUIT:
                printf("Quitting\n");
                SDL_QuitSubSystem(SDL_INIT_VIDEO);
                SDL_Quit();
                quit = 1;
                break;
            }
        }
    }
    return 0;
}