Mercurial > sdl-ios-xcode
view VisualCE/SDLMain/SDLmain.vcproj @ 3539:f2846bf19360
Fixed bug #896
John Popplewell 2009-12-08 23:05:50 PST
Originally reported by AKFoerster on the mailing list.
Error decoding UTF8 Russian text to UTF-16LE on Windows, but specifically on
platforms without iconv support (the default on Windows).
Valid UTF8 characters are flagged as being overlong and then substituted by the
UNKNOWN_UNICODE character.
After studying the testiconv.c example program, reading the RFCs and putting
some printf statements in SDL_iconv.c the problem is in a test for 'Maximum
overlong sequences', specifically 4.2.1, which is carried out by the following
code:
} else if ( p[0] >= 0xC0 ) {
if ( (p[0] & 0xE0) != 0xC0 ) {
/* Skip illegal sequences
return SDL_ICONV_EILSEQ;
*/
ch = UNKNOWN_UNICODE;
} else {
if ( (p[0] & 0xCE) == 0xC0 ) { <<<<<<<< here
overlong = SDL_TRUE;
}
ch = (Uint32)(p[0] & 0x1F);
left = 1;
}
} else {
Here is the 2-byte encoding of a character in range 00000080 - 000007FF
110xxxxx 10xxxxxx
The line in question is supposed to be checking for an overlong sequence which
would be less than
11000001 10111111
which should be represented as a single byte.
BUT, the mask value (0xCE) is wrong, it isn't checking the top-most bit:
11000001 value
11001110 mask (incorrect)
^
and should be (0xDE):
11000001 value
11011110 mask (correct)
making the above code:
} else if ( p[0] >= 0xC0 ) {
if ( (p[0] & 0xE0) != 0xC0 ) {
/* Skip illegal sequences
return SDL_ICONV_EILSEQ;
*/
ch = UNKNOWN_UNICODE;
} else {
if ( (p[0] & 0xDE) == 0xC0 ) { <<<<<<<< here
overlong = SDL_TRUE;
}
ch = (Uint32)(p[0] & 0x1F);
left = 1;
}
} else {
I can supply a test program and/or a patch if required,
best regards,
John Popplewell
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 11 Dec 2009 08:03:43 +0000 |
parents | d63e9f5944ae |
children | c2539ff054c8 |
line wrap: on
line source
<?xml version="1.0" encoding="windows-1251"?> <VisualStudioProject ProjectType="Visual C++" Version="8,00" Name="SDLmain" ProjectGUID="{5AC88B84-5EAA-4C1E-948D-332DA34227F6}" RootNamespace="SDLmain" > <Platforms> <Platform Name="Smartphone 2003 (ARMV4)" /> <Platform Name="Pocket PC 2003 (ARMV4)" /> <Platform Name="Windows Mobile 5.0 Pocket PC SDK (ARMV4I)" /> </Platforms> <ToolFiles> </ToolFiles> <Configurations> <Configuration Name="Debug|Smartphone 2003 (ARMV4)" OutputDirectory="$(PlatformName)\$(ConfigurationName)" IntermediateDirectory="$(PlatformName)\$(ConfigurationName)" ConfigurationType="4" InheritedPropertySheets="$(VCInstallDir)VCProjectDefaults\UpgradeFromVC60.vsprops" UseOfMFC="0" ATLMinimizesCRunTimeLibraryUsage="false" CharacterSet="1" > <Tool Name="VCPreBuildEventTool" /> <Tool Name="VCCustomBuildTool" /> <Tool Name="VCXMLDataGeneratorTool" /> <Tool Name="VCWebServiceProxyGeneratorTool" /> <Tool Name="VCMIDLTool" TypeLibraryName="$(PlatformName)\$(ConfigurationName)/SDLmain.tlb" HeaderFileName="" /> <Tool Name="VCCLCompilerTool" ExecutionBucket="7" Optimization="0" AdditionalIncludeDirectories="../../include" PreprocessorDefinitions="DEBUG;_WIN32_WCE=$(CEVER);$(CePlatform);ARM;_ARM_;ARMV4;UNDER_CE=$(CEVER);UNICODE;_LIB" RuntimeLibrary="1" UsePrecompiledHeader="0" PrecompiledHeaderFile="$(PlatformName)\$(ConfigurationName)/SDLmain.pch" AssemblerListingLocation="$(PlatformName)\$(ConfigurationName)/" ObjectFile="$(PlatformName)\$(ConfigurationName)/" ProgramDataBaseFileName="$(PlatformName)\$(ConfigurationName)/" WarningLevel="3" SuppressStartupBanner="true" DebugInformationFormat="3" /> <Tool Name="VCManagedResourceCompilerTool" /> <Tool Name="VCResourceCompilerTool" Culture="1049" /> <Tool Name="VCPreLinkEventTool" /> <Tool Name="VCLibrarianTool" OutputFile="$(PlatformName)\$(ConfigurationName)\SDLmain.lib" /> <Tool Name="VCALinkTool" /> <Tool Name="VCXDCMakeTool" /> <Tool Name="VCBscMakeTool" SuppressStartupBanner="true" OutputFile="$(PlatformName)\$(ConfigurationName)/SDLmain.bsc" /> <Tool Name="VCCodeSignTool" /> <Tool Name="VCPostBuildEventTool" /> <DeploymentTool ForceDirty="-1" RemoteDirectory="" RegisterOutput="0" AdditionalFiles="" /> <DebuggerTool /> </Configuration> <Configuration Name="Debug|Pocket PC 2003 (ARMV4)" OutputDirectory="$(PlatformName)\$(ConfigurationName)" IntermediateDirectory="$(PlatformName)\$(ConfigurationName)" ConfigurationType="4" InheritedPropertySheets="$(VCInstallDir)VCProjectDefaults\UpgradeFromVC60.vsprops" UseOfMFC="0" ATLMinimizesCRunTimeLibraryUsage="false" CharacterSet="1" > <Tool Name="VCPreBuildEventTool" /> <Tool Name="VCCustomBuildTool" /> <Tool Name="VCXMLDataGeneratorTool" /> <Tool Name="VCWebServiceProxyGeneratorTool" /> <Tool Name="VCMIDLTool" TypeLibraryName="$(PlatformName)\$(ConfigurationName)/SDLmain.tlb" HeaderFileName="" /> <Tool Name="VCCLCompilerTool" ExecutionBucket="7" Optimization="0" AdditionalIncludeDirectories="../../include" PreprocessorDefinitions="DEBUG;_WIN32_WCE=$(CEVER);$(CePlatform);ARM;_ARM_;ARMV4;UNDER_CE=$(CEVER);UNICODE;_LIB" RuntimeLibrary="1" UsePrecompiledHeader="0" PrecompiledHeaderFile="$(PlatformName)\$(ConfigurationName)/SDLmain.pch" AssemblerListingLocation="$(PlatformName)\$(ConfigurationName)/" ObjectFile="$(PlatformName)\$(ConfigurationName)/" ProgramDataBaseFileName="$(PlatformName)\$(ConfigurationName)/" WarningLevel="3" SuppressStartupBanner="true" DebugInformationFormat="3" /> <Tool Name="VCManagedResourceCompilerTool" /> <Tool Name="VCResourceCompilerTool" Culture="1049" /> <Tool Name="VCPreLinkEventTool" /> <Tool Name="VCLibrarianTool" OutputFile="$(PlatformName)\$(ConfigurationName)\SDLmain.lib" /> <Tool Name="VCALinkTool" /> <Tool Name="VCXDCMakeTool" /> <Tool Name="VCBscMakeTool" SuppressStartupBanner="true" OutputFile="$(PlatformName)\$(ConfigurationName)/SDLmain.bsc" /> <Tool Name="VCCodeSignTool" /> <Tool Name="VCPostBuildEventTool" /> <DeploymentTool ForceDirty="-1" RemoteDirectory="" RegisterOutput="0" AdditionalFiles="" /> <DebuggerTool /> </Configuration> <Configuration Name="Debug|Windows Mobile 5.0 Pocket PC SDK (ARMV4I)" OutputDirectory="$(PlatformName)\$(ConfigurationName)" IntermediateDirectory="$(PlatformName)\$(ConfigurationName)" ConfigurationType="4" InheritedPropertySheets="$(VCInstallDir)VCProjectDefaults\UpgradeFromVC60.vsprops" UseOfMFC="0" ATLMinimizesCRunTimeLibraryUsage="false" CharacterSet="1" > <Tool Name="VCPreBuildEventTool" /> <Tool Name="VCCustomBuildTool" /> <Tool Name="VCXMLDataGeneratorTool" /> <Tool Name="VCWebServiceProxyGeneratorTool" /> <Tool Name="VCMIDLTool" TypeLibraryName="$(PlatformName)\$(ConfigurationName)/SDLmain.tlb" HeaderFileName="" /> <Tool Name="VCCLCompilerTool" ExecutionBucket="7" Optimization="0" AdditionalIncludeDirectories="../../include" PreprocessorDefinitions="DEBUG;_WIN32_WCE=$(CEVER);ARM;_ARM_;$(CePlatform);THUMB;_THUMB_;ARMV4T;UNDER_CE=$(CEVER);UNICODE;_LIB" RuntimeLibrary="1" UsePrecompiledHeader="0" PrecompiledHeaderFile="$(PlatformName)\$(ConfigurationName)/SDLmain.pch" AssemblerListingLocation="$(PlatformName)\$(ConfigurationName)/" ObjectFile="$(PlatformName)\$(ConfigurationName)/" ProgramDataBaseFileName="$(PlatformName)\$(ConfigurationName)/" WarningLevel="3" SuppressStartupBanner="true" DebugInformationFormat="3" /> <Tool Name="VCManagedResourceCompilerTool" /> <Tool Name="VCResourceCompilerTool" Culture="1049" /> <Tool Name="VCPreLinkEventTool" /> <Tool Name="VCLibrarianTool" OutputFile="$(PlatformName)\$(ConfigurationName)\SDLmain.lib" /> <Tool Name="VCALinkTool" /> <Tool Name="VCXDCMakeTool" /> <Tool Name="VCBscMakeTool" SuppressStartupBanner="true" OutputFile="$(PlatformName)\$(ConfigurationName)/SDLmain.bsc" /> <Tool Name="VCCodeSignTool" /> <Tool Name="VCPostBuildEventTool" /> <DeploymentTool ForceDirty="-1" RemoteDirectory="" RegisterOutput="0" AdditionalFiles="" /> <DebuggerTool /> </Configuration> <Configuration Name="Release|Smartphone 2003 (ARMV4)" OutputDirectory="$(PlatformName)\$(ConfigurationName)" IntermediateDirectory="$(PlatformName)\$(ConfigurationName)" ConfigurationType="4" InheritedPropertySheets="$(VCInstallDir)VCProjectDefaults\UpgradeFromVC60.vsprops" UseOfMFC="0" ATLMinimizesCRunTimeLibraryUsage="false" CharacterSet="1" > <Tool Name="VCPreBuildEventTool" /> <Tool Name="VCCustomBuildTool" /> <Tool Name="VCXMLDataGeneratorTool" /> <Tool Name="VCWebServiceProxyGeneratorTool" /> <Tool Name="VCMIDLTool" TypeLibraryName="$(PlatformName)\$(ConfigurationName)/SDLmain.tlb" HeaderFileName="" /> <Tool Name="VCCLCompilerTool" ExecutionBucket="7" Optimization="4" InlineFunctionExpansion="2" AdditionalIncludeDirectories="../../include" PreprocessorDefinitions="_WIN32_WCE=$(CEVER);$(CePlatform);NDEBUG;ARM;_ARM_;ARMV4;UNDER_CE=$(CEVER);UNICODE;_LIB" RuntimeLibrary="0" UsePrecompiledHeader="0" PrecompiledHeaderFile="$(PlatformName)\$(ConfigurationName)/SDLmain.pch" AssemblerListingLocation="$(PlatformName)\$(ConfigurationName)/" ObjectFile="$(PlatformName)\$(ConfigurationName)/" ProgramDataBaseFileName="$(PlatformName)\$(ConfigurationName)/" WarningLevel="3" SuppressStartupBanner="true" /> <Tool Name="VCManagedResourceCompilerTool" /> <Tool Name="VCResourceCompilerTool" Culture="1049" /> <Tool Name="VCPreLinkEventTool" /> <Tool Name="VCLibrarianTool" OutputFile="$(PlatformName)\$(ConfigurationName)\SDLmain.lib" /> <Tool Name="VCALinkTool" /> <Tool Name="VCXDCMakeTool" /> <Tool Name="VCBscMakeTool" SuppressStartupBanner="true" OutputFile="$(PlatformName)\$(ConfigurationName)/SDLmain.bsc" /> <Tool Name="VCCodeSignTool" /> <Tool Name="VCPostBuildEventTool" /> <DeploymentTool ForceDirty="-1" RemoteDirectory="" RegisterOutput="0" AdditionalFiles="" /> <DebuggerTool /> </Configuration> <Configuration Name="Release|Pocket PC 2003 (ARMV4)" OutputDirectory="$(PlatformName)\$(ConfigurationName)" IntermediateDirectory="$(PlatformName)\$(ConfigurationName)" ConfigurationType="4" InheritedPropertySheets="$(VCInstallDir)VCProjectDefaults\UpgradeFromVC60.vsprops" UseOfMFC="0" ATLMinimizesCRunTimeLibraryUsage="false" CharacterSet="1" > <Tool Name="VCPreBuildEventTool" /> <Tool Name="VCCustomBuildTool" /> <Tool Name="VCXMLDataGeneratorTool" /> <Tool Name="VCWebServiceProxyGeneratorTool" /> <Tool Name="VCMIDLTool" TypeLibraryName="$(PlatformName)\$(ConfigurationName)/SDLmain.tlb" HeaderFileName="" /> <Tool Name="VCCLCompilerTool" ExecutionBucket="7" Optimization="4" InlineFunctionExpansion="2" AdditionalIncludeDirectories="../../include" PreprocessorDefinitions="_WIN32_WCE=$(CEVER);$(CePlatform);NDEBUG;ARM;_ARM_;ARMV4;UNDER_CE=$(CEVER);UNICODE;_LIB" RuntimeLibrary="0" UsePrecompiledHeader="0" PrecompiledHeaderFile="$(PlatformName)\$(ConfigurationName)/SDLmain.pch" AssemblerListingLocation="$(PlatformName)\$(ConfigurationName)/" ObjectFile="$(PlatformName)\$(ConfigurationName)/" ProgramDataBaseFileName="$(PlatformName)\$(ConfigurationName)/" WarningLevel="3" SuppressStartupBanner="true" /> <Tool Name="VCManagedResourceCompilerTool" /> <Tool Name="VCResourceCompilerTool" Culture="1049" /> <Tool Name="VCPreLinkEventTool" /> <Tool Name="VCLibrarianTool" OutputFile="$(PlatformName)\$(ConfigurationName)\SDLmain.lib" /> <Tool Name="VCALinkTool" /> <Tool Name="VCXDCMakeTool" /> <Tool Name="VCBscMakeTool" SuppressStartupBanner="true" OutputFile="$(PlatformName)\$(ConfigurationName)/SDLmain.bsc" /> <Tool Name="VCCodeSignTool" /> <Tool Name="VCPostBuildEventTool" /> <DeploymentTool ForceDirty="-1" RemoteDirectory="" RegisterOutput="0" AdditionalFiles="" /> <DebuggerTool /> </Configuration> <Configuration Name="Release|Windows Mobile 5.0 Pocket PC SDK (ARMV4I)" OutputDirectory="$(PlatformName)\$(ConfigurationName)" IntermediateDirectory="$(PlatformName)\$(ConfigurationName)" ConfigurationType="4" InheritedPropertySheets="$(VCInstallDir)VCProjectDefaults\UpgradeFromVC60.vsprops" UseOfMFC="0" ATLMinimizesCRunTimeLibraryUsage="false" CharacterSet="1" > <Tool Name="VCPreBuildEventTool" /> <Tool Name="VCCustomBuildTool" /> <Tool Name="VCXMLDataGeneratorTool" /> <Tool Name="VCWebServiceProxyGeneratorTool" /> <Tool Name="VCMIDLTool" TypeLibraryName="$(PlatformName)\$(ConfigurationName)/SDLmain.tlb" HeaderFileName="" /> <Tool Name="VCCLCompilerTool" ExecutionBucket="7" Optimization="2" InlineFunctionExpansion="2" EnableIntrinsicFunctions="true" FavorSizeOrSpeed="1" WholeProgramOptimization="true" AdditionalIncludeDirectories="../../include" PreprocessorDefinitions="_WIN32_WCE=$(CEVER);ARM;_ARM_;$(CePlatform);THUMB;_THUMB_;ARMV4T;UNDER_CE=$(CEVER);UNICODE;NDEBUG;_LIB" RuntimeLibrary="0" UsePrecompiledHeader="0" PrecompiledHeaderFile="$(PlatformName)\$(ConfigurationName)/SDLmain.pch" AssemblerListingLocation="$(PlatformName)\$(ConfigurationName)/" ObjectFile="$(PlatformName)\$(ConfigurationName)/" ProgramDataBaseFileName="$(PlatformName)\$(ConfigurationName)/" WarningLevel="3" SuppressStartupBanner="true" /> <Tool Name="VCManagedResourceCompilerTool" /> <Tool Name="VCResourceCompilerTool" Culture="1049" /> <Tool Name="VCPreLinkEventTool" /> <Tool Name="VCLibrarianTool" OutputFile="$(PlatformName)\$(ConfigurationName)\SDLmain.lib" /> <Tool Name="VCALinkTool" /> <Tool Name="VCXDCMakeTool" /> <Tool Name="VCBscMakeTool" SuppressStartupBanner="true" OutputFile="$(PlatformName)\$(ConfigurationName)/SDLmain.bsc" /> <Tool Name="VCCodeSignTool" /> <Tool Name="VCPostBuildEventTool" /> <DeploymentTool ForceDirty="-1" RemoteDirectory="" RegisterOutput="0" AdditionalFiles="" /> <DebuggerTool /> </Configuration> </Configurations> <References> </References> <Files> <Filter Name="Source Files" Filter="cpp;c;cxx;rc;def;r;odl;idl;hpj;bat" > <File RelativePath="..\..\src\main\win32\SDL_win32_main.c" > <FileConfiguration Name="Debug|Smartphone 2003 (ARMV4)" > <Tool Name="VCCLCompilerTool" AdditionalIncludeDirectories="" UsePrecompiledHeader="0" /> </FileConfiguration> <FileConfiguration Name="Debug|Pocket PC 2003 (ARMV4)" > <Tool Name="VCCLCompilerTool" AdditionalIncludeDirectories="" UsePrecompiledHeader="0" /> </FileConfiguration> <FileConfiguration Name="Debug|Windows Mobile 5.0 Pocket PC SDK (ARMV4I)" > <Tool Name="VCCLCompilerTool" AdditionalIncludeDirectories="" UsePrecompiledHeader="0" /> </FileConfiguration> <FileConfiguration Name="Release|Smartphone 2003 (ARMV4)" > <Tool Name="VCCLCompilerTool" AdditionalIncludeDirectories="" UsePrecompiledHeader="0" /> </FileConfiguration> <FileConfiguration Name="Release|Pocket PC 2003 (ARMV4)" > <Tool Name="VCCLCompilerTool" AdditionalIncludeDirectories="" UsePrecompiledHeader="0" /> </FileConfiguration> <FileConfiguration Name="Release|Windows Mobile 5.0 Pocket PC SDK (ARMV4I)" > <Tool Name="VCCLCompilerTool" AdditionalIncludeDirectories="" UsePrecompiledHeader="0" /> </FileConfiguration> </File> </Filter> <Filter Name="Header Files" Filter="h;hpp;hxx;hm;inl" > <File RelativePath="..\..\include\SDL_main.h" > </File> </Filter> </Files> <Globals> </Globals> </VisualStudioProject>