Mercurial > sdl-ios-xcode
view src/video/riscos/SDL_riscosASM.S @ 3485:e77a69aae239
Mason Wheeler to sdl
I updated SDL, and suddenly my SDL frames stopped working. They'd "initialize" full of gibberish, and I couldn't render anything to them. After a bit of digging, I found a problem: the renderer initialization routine in my SDL frame code wasn't getting called anymore.
procedure TSdlFrame.Paint;
begin
if SDL_SelectRenderer(FWindowID) = -1 then
CreateRenderer;
SDL_RenderPresent;
end;
function TSdlFrame.CreateRenderer: boolean;
const
pf: tagPIXELFORMATDESCRIPTOR = (nSize: sizeof(pf); nVersion: 1;
dwFlags: PFD_DRAW_TO_WINDOW or PFD_SUPPORT_OPENGL or PFD_DOUBLEBUFFER;
iPixelType: PFD_TYPE_RGBA; cColorBits: 24; cAlphaBits: 8;
iLayerType: PFD_MAIN_PLANE);
RENDERERS: array[TRendererType] of AnsiString = ('software', 'gdi', 'opengl', 'd3d');
var
pFormat: integer;
begin
if (SDL_SelectRenderer(FWindowID) = 0) then
begin
result := true;
Exit;
end;
if FRendererType = rtOpenGL then
begin
pFormat := ChoosePixelFormat(canvas.Handle, @pf);
if not SetPixelFormat(canvas.Handle, pFormat, @pf) then
outputDebugString(PChar(SysErrorMessage(GetLastError)));
if wglCreateContext(canvas.Handle) = 0 then
outputDebugString(PChar(SysErrorMessage(GetLastError)));
end;
if (SDL_CreateRenderer(FWindowID, SDL_RendererIndex(RENDERERS[FRendererType]), [sdlrPresentFlip3, sdlrAccelerated]) = 0) then
begin
SDL_ShowWindow(FWindowID);
assert(SDL_SetRenderDrawColor(0, 0, 0, 255) = 0);
FFlags := SDL_GetWindowFlags(FWindowID);
if assigned(FOnAvailable) then
FOnAvailable(self);
end
else outputDebugString(pChar(format('SDL_CreateRenderer failed: %s', [sdl_GetError])));
result := SDL_SelectRenderer(FWindowID) = 0;
end;
This is a critical issue. The Paint method gets called when the control receives a WM_PAINT message from Windows. I can't create the renderer before then, or it will fail and cause trouble. And when I do create it, it needs to be created with certain parameters. So imagine my surprise when I started debugging into the DLL and found that SDL_SelectRenderer was trying to be "helpful" by creating the renderer for me if it didn't already exist! Now not only does my initialization code not get called, I end up with the wrong renderer and so things don't render as expected when I try to use the window.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 24 Nov 2009 04:48:12 +0000 |
parents | 99210400e8b9 |
children |
line wrap: on
line source
; ; SDL - Simple DirectMedia Layer ; Copyright (C) 1997-2009 Sam Lantinga ; ; This library is free software; you can redistribute it and/or ; modify it under the terms of the GNU Library General Public ; License as published by the Free Software Foundation; either ; version 2 of the License, or (at your option) any later version. ; ; This library is distributed in the hope that it will be useful, ; but WITHOUT ANY WARRANTY; without even the implied warranty of ; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU ; Library General Public License for more details. ; ; You should have received a copy of the GNU Library General Public ; License along with this library; if not, write to the Free ; Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA ; ; Sam Lantinga ; slouken@libsdl.org ; ; Assembler routines for RISC OS display ; AREA |C$$CODE| EXPORT |RISCOS_Put32| ; Display 32bpp to 32bpp, 1:1 ; ; Code provided by Adrain Lees ; ; entry a1 -> destination ; a2 = dest width in pixels ; a3 = dest line length in bytes ; a4 = dest height in scanlines ; arg5 -> source ; arg6 = byte offset from end of source line to start of next Arg5 * 10*4 Arg6 * Arg5+4 RISCOS_Put32 ROUT STMFD sp!,{a2,v1-v6,sl,fp,lr} LDR ip,[sp,#Arg5] MOV lr,a1 B ucp64lp 00 ;tail strip of 1-15 pixels LDR v1,[ip],#4 01 SUBS a2,a2,#1 STR v1,[lr],#4 LDRHI v1,[ip],#4 BHI %01 B %02 ucp64end ADDS a2,a2,#16 BNE %00 02 SUBS a4,a4,#1 ;height-- LDRHI v1,[sp,#Arg6] LDRHI a2,[sp] ;reload width BLS %03 ;move to start of next scanline ADD lr,a1,a3 ADD a1,a1,a3 ADD ip,ip,v1 ucp64lp SUBS a2,a2,#16 BLO ucp64end PLD [ip,#64] LDR v1,[ip],#4 LDR v2,[ip],#4 LDR v3,[ip],#4 LDR v4,[ip],#4 LDR v5,[ip],#4 LDR v6,[ip],#4 LDR sl,[ip],#4 LDR fp,[ip],#4 STR v1,[lr],#4 STR v2,[lr],#4 STR v3,[lr],#4 STR v4,[lr],#4 STR v5,[lr],#4 STR v6,[lr],#4 STR sl,[lr],#4 STR fp,[lr],#4 PLD [ip,#64] LDR v1,[ip],#4 LDR v2,[ip],#4 LDR v3,[ip],#4 LDR v4,[ip],#4 LDR v5,[ip],#4 LDR v6,[ip],#4 LDR sl,[ip],#4 LDR fp,[ip],#4 STR v1,[lr],#4 STR v2,[lr],#4 STR v3,[lr],#4 STR v4,[lr],#4 STR v5,[lr],#4 STR v6,[lr],#4 STR sl,[lr],#4 STR fp,[lr],#4 B ucp64lp 03 LDMFD sp!,{a2,v1-v6,sl,fp,pc}