Mercurial > sdl-ios-xcode
view TODO @ 3485:e77a69aae239
Mason Wheeler to sdl
I updated SDL, and suddenly my SDL frames stopped working. They'd "initialize" full of gibberish, and I couldn't render anything to them. After a bit of digging, I found a problem: the renderer initialization routine in my SDL frame code wasn't getting called anymore.
procedure TSdlFrame.Paint;
begin
if SDL_SelectRenderer(FWindowID) = -1 then
CreateRenderer;
SDL_RenderPresent;
end;
function TSdlFrame.CreateRenderer: boolean;
const
pf: tagPIXELFORMATDESCRIPTOR = (nSize: sizeof(pf); nVersion: 1;
dwFlags: PFD_DRAW_TO_WINDOW or PFD_SUPPORT_OPENGL or PFD_DOUBLEBUFFER;
iPixelType: PFD_TYPE_RGBA; cColorBits: 24; cAlphaBits: 8;
iLayerType: PFD_MAIN_PLANE);
RENDERERS: array[TRendererType] of AnsiString = ('software', 'gdi', 'opengl', 'd3d');
var
pFormat: integer;
begin
if (SDL_SelectRenderer(FWindowID) = 0) then
begin
result := true;
Exit;
end;
if FRendererType = rtOpenGL then
begin
pFormat := ChoosePixelFormat(canvas.Handle, @pf);
if not SetPixelFormat(canvas.Handle, pFormat, @pf) then
outputDebugString(PChar(SysErrorMessage(GetLastError)));
if wglCreateContext(canvas.Handle) = 0 then
outputDebugString(PChar(SysErrorMessage(GetLastError)));
end;
if (SDL_CreateRenderer(FWindowID, SDL_RendererIndex(RENDERERS[FRendererType]), [sdlrPresentFlip3, sdlrAccelerated]) = 0) then
begin
SDL_ShowWindow(FWindowID);
assert(SDL_SetRenderDrawColor(0, 0, 0, 255) = 0);
FFlags := SDL_GetWindowFlags(FWindowID);
if assigned(FOnAvailable) then
FOnAvailable(self);
end
else outputDebugString(pChar(format('SDL_CreateRenderer failed: %s', [sdl_GetError])));
result := SDL_SelectRenderer(FWindowID) = 0;
end;
This is a critical issue. The Paint method gets called when the control receives a WM_PAINT message from Windows. I can't create the renderer before then, or it will fail and cause trouble. And when I do create it, it needs to be created with certain parameters. So imagine my surprise when I started debugging into the DLL and found that SDL_SelectRenderer was trying to be "helpful" by creating the renderer for me if it didn't already exist! Now not only does my initialization code not get called, I end up with the wrong renderer and so things don't render as expected when I try to use the window.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Tue, 24 Nov 2009 04:48:12 +0000 |
| parents | 15f661b279e7 |
| children | 71189305cd33 |
line wrap: on
line source
1.3 release checklist: * Create jobs@libsdl.org * Implement landscape mode for iPhone port * Add higher precision timers for profiling * Implement YUV texture support - in progress, software support is done, Ryan is working on OpenGL shaders * Implement desktop video mode change notification? * Add OpenGL 3.0 context support * Finish multiple display support * Open windows on display that is selected when creating a window * Create testing plan - becoming more and more important... - unit tests for each feature and combination with expected output and actual output comparison. * Public license for SDL_compat.c, tests, and SDL_main* * Verify mouse grab support * Properly handle mouse grab with Vista DPI scaling * Make sure the mouse is where it's supposed to be when un-grabbed * Plan how to handle events on foreign windows * Add keyboard enumeration / name query API * Implement NET_WM_PING and NET_WM_PID/WM_CLIENT_MACHINE (?) - http://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#KILLINGWINDOWS * Add a timeout parameter for SDL_WaitEvent() (?) - http://lists.libsdl.org/pipermail/sdl-libsdl.org/2008-May/thread.html#65067 * Implement key repeat at the driver level * Add name -> keysym and name -> scancode lookup functions * Fix building haptic system on win32 * Add always on top window styles * Add video modes that have an alpha channel? * Implement SDL_RenderReadPixels() for screenshots and automated testing * Create extended set of (negative) error codes and have the API functions document and return them. * Add clipboard support (from scrap demo) * Add support for desktop windows? * Add support for synchronizing 2D updates with vblank (bug #406) * Add support for real-time threads and/or adjusting thread priority? * Add support for querying the number of CPUs and binding threads to them? * Allow setting multiple icon sizes Wish list for the 1.3 development branch: http://bugzilla.libsdl.org/ * Add a way to register custom events * DirectInput joystick support needs to be implemented * Explicit vertical retrace wait (maybe separate from SDL_Flip?) * Shaped windows, windows without borders * Multiple display support * Add a timestamp to events * Add audio input API * Add modifier state to key and button events In the jump from 1.2 to 1.3, we should change the SDL_Rect members to int and evaluate all the rest of the datatypes. This is the only place we should do it though, since the 1.2 series should not break binary compatibility in this way. Requests: * PCM volume control (deprecated, but possible)