Mercurial > sdl-ios-xcode
view src/video/qnxgf/SDL_gf_pixelfmt.c @ 5082:de59e0218aa2
Fixed bug #1011
Daniel Ellis 2010-06-25 15:20:31 PDT
SDL based applications sometimes display the wrong application name in the
Sound Preferences dialog when using pulseaudio.
I can see from the code that the SDL pulse module is initiating a new pulse
audio context and passing an application name using the function
get_progname().
The get_progname() function returns the name of the current process. However,
the process name is often not a suitable name to use. For example, the OpenShot
video editor is a python application, and so "python" is displayed in the Sound
Preferences window (see Bug #596504), when it should be displaying "OpenShot".
PulseAudio allows applications to specify the application name, either at the
time the context is created (as SDL does currently), or by special environment
variables (see http://www.pulseaudio.org/wiki/ApplicationProperties). If no
name is specified, then pulseaudio will determine the name based on the
process.
If you specify the application name when initiating the pulseaudio context,
then that will override any application name specified using an environment
variable.
As libsdl is a library, I believe the solution is for libsdl to not specify any
application name when initiating a pulseaudio context, which will enable
applications to specify the application name using environment variables. In
the case that the applications do not specify anything, pulseaudio will fall
back to using the process name anyway.
The attached patch removes the get_progname() function and passes NULL as the
application name when creating the pulseaudio context, which fixes the issue.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 23 Jan 2011 21:55:04 -0800 |
parents | f7b03b6838cb |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org QNX Graphics Framework SDL driver Copyright (C) 2009 Mike Gorchak (mike@malva.ua, lestat@i.com.ua) */ #include "SDL_config.h" #include "SDL_gf_pixelfmt.h" gf_format_t qnxgf_sdl_to_gf_pixelformat(uint32_t pixelfmt) { switch (pixelfmt) { case SDL_PIXELFORMAT_INDEX8: { return GF_FORMAT_PAL8; } break; case SDL_PIXELFORMAT_ARGB1555: { return GF_FORMAT_PACK_ARGB1555; } break; case SDL_PIXELFORMAT_RGB555: { /* RGB555 is the same as ARGB1555, but alpha is ignored */ return GF_FORMAT_PACK_ARGB1555; } break; case SDL_PIXELFORMAT_RGB565: { return GF_FORMAT_PACK_RGB565; } break; case SDL_PIXELFORMAT_BGR565: { return GF_FORMAT_PKBE_RGB565; } break; case SDL_PIXELFORMAT_RGB24: { /* GF has wrong components order */ return GF_FORMAT_BGR888; } break; case SDL_PIXELFORMAT_RGB888: { /* The same format as ARGB8888, but with alpha ignored */ /* and GF has wrong components order */ return GF_FORMAT_BGRA8888; } break; case SDL_PIXELFORMAT_ARGB8888: { /* GF has wrong components order */ return GF_FORMAT_BGRA8888; } break; case SDL_PIXELFORMAT_BGRA8888: { /* GF has wrong components order */ return GF_FORMAT_ARGB8888; } break; case SDL_PIXELFORMAT_YV12: { return GF_FORMAT_PLANAR_YUV_YV12; } break; case SDL_PIXELFORMAT_YUY2: { return GF_FORMAT_PACK_YUV_YUY2; } break; case SDL_PIXELFORMAT_UYVY: { return GF_FORMAT_PACK_YUV_UYVY; } break; case SDL_PIXELFORMAT_YVYU: { return GF_FORMAT_PACK_YUV_YVYU; } break; } return GF_FORMAT_INVALID; } uint32_t qnxgf_gf_to_sdl_pixelformat(gf_format_t pixelfmt) { switch (pixelfmt) { case GF_FORMAT_PAL8: { return SDL_PIXELFORMAT_INDEX8; } break; case GF_FORMAT_PKLE_ARGB1555: { return SDL_PIXELFORMAT_ARGB1555; } break; case GF_FORMAT_PACK_ARGB1555: { return SDL_PIXELFORMAT_ARGB1555; } break; case GF_FORMAT_PKBE_RGB565: { return SDL_PIXELFORMAT_BGR565; } break; case GF_FORMAT_PKLE_RGB565: { return SDL_PIXELFORMAT_RGB565; } break; case GF_FORMAT_PACK_RGB565: { return SDL_PIXELFORMAT_RGB565; } break; case GF_FORMAT_BGR888: { /* GF has wrong components order */ return SDL_PIXELFORMAT_RGB24; } break; case GF_FORMAT_BGRA8888: { /* GF has wrong components order */ return SDL_PIXELFORMAT_ARGB8888; } break; case GF_FORMAT_ARGB8888: { /* GF has wrong components order */ return SDL_PIXELFORMAT_BGRA8888; } break; case GF_FORMAT_PLANAR_YUV_YV12: { return SDL_PIXELFORMAT_YV12; } break; case GF_FORMAT_PACK_YUV_YUY2: { return SDL_PIXELFORMAT_YUY2; } break; case GF_FORMAT_PACK_YUV_UYVY: { return SDL_PIXELFORMAT_UYVY; } break; case GF_FORMAT_PACK_YUV_YVYU: { return SDL_PIXELFORMAT_YVYU; } break; } return SDL_PIXELFORMAT_UNKNOWN; } /* vi: set ts=4 sw=4 expandtab: */