Mercurial > sdl-ios-xcode
view src/video/Xext/XmuStdCmap/Distinct.c @ 5082:de59e0218aa2
Fixed bug #1011
Daniel Ellis 2010-06-25 15:20:31 PDT
SDL based applications sometimes display the wrong application name in the
Sound Preferences dialog when using pulseaudio.
I can see from the code that the SDL pulse module is initiating a new pulse
audio context and passing an application name using the function
get_progname().
The get_progname() function returns the name of the current process. However,
the process name is often not a suitable name to use. For example, the OpenShot
video editor is a python application, and so "python" is displayed in the Sound
Preferences window (see Bug #596504), when it should be displaying "OpenShot".
PulseAudio allows applications to specify the application name, either at the
time the context is created (as SDL does currently), or by special environment
variables (see http://www.pulseaudio.org/wiki/ApplicationProperties). If no
name is specified, then pulseaudio will determine the name based on the
process.
If you specify the application name when initiating the pulseaudio context,
then that will override any application name specified using an environment
variable.
As libsdl is a library, I believe the solution is for libsdl to not specify any
application name when initiating a pulseaudio context, which will enable
applications to specify the application name using environment variables. In
the case that the applications do not specify anything, pulseaudio will fall
back to using the process name anyway.
The attached patch removes the get_progname() function and passes NULL as the
application name when creating the pulseaudio context, which fixes the issue.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sun, 23 Jan 2011 21:55:04 -0800 |
parents | 2032348afed1 |
children |
line wrap: on
line source
/* $Xorg: Distinct.c,v 1.4 2001/02/09 02:03:52 xorgcvs Exp $ */ /* Copyright 1990, 1998 The Open Group Permission to use, copy, modify, distribute, and sell this software and its documentation for any purpose is hereby granted without fee, provided that the above copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation. The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE OPEN GROUP BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. Except as contained in this notice, the name of The Open Group shall not be used in advertising or otherwise to promote the sale, use or other dealings in this Software without prior written authorization from The Open Group. */ /* $XFree86: xc/lib/Xmu/Distinct.c,v 3.5 2001/07/25 15:04:50 dawes Exp $ */ /* * Author: Keith Packard, MIT X Consortium */ #ifdef HAVE_CONFIG_H #include <config.h> #endif #include <X11/Xlib.h> #include <stdlib.h> #include <X11/Xutil.h> #include "../extensions/StdCmap.h" /* * Distinguishable colors routine. Determines if two colors are * distinguishable or not. Somewhat arbitrary meaning. */ #define MIN_DISTINGUISH 10000.0 Bool XmuDistinguishableColors(XColor * colors, int count) { double deltaRed, deltaGreen, deltaBlue; double dist; int i, j; for (i = 0; i < count - 1; i++) for (j = i + 1; j < count; j++) { deltaRed = (double) colors[i].red - (double) colors[j].red; deltaGreen = (double) colors[i].green - (double) colors[j].green; deltaBlue = (double) colors[i].blue - (double) colors[j].blue; dist = deltaRed * deltaRed + deltaGreen * deltaGreen + deltaBlue * deltaBlue; if (dist <= MIN_DISTINGUISH * MIN_DISTINGUISH) return False; } return True; } Bool XmuDistinguishablePixels(Display * dpy, Colormap cmap, unsigned long *pixels, int count) { XColor *defs; int i, j; Bool ret; for (i = 0; i < count - 1; i++) for (j = i + 1; j < count; j++) if (pixels[i] == pixels[j]) return False; defs = (XColor *) malloc(count * sizeof(XColor)); if (!defs) return False; for (i = 0; i < count; i++) defs[i].pixel = pixels[i]; XQueryColors(dpy, cmap, defs, count); ret = XmuDistinguishableColors(defs, count); free((char *) defs); return ret; }