Mercurial > sdl-ios-xcode
view src/video/cybergfx/SDL_cgxgl.c @ 1176:dd2a8deeb26d
Date: Mon, 17 Oct 2005 20:09:03 -0400
From: Mark Schreiber <mark7@alumni.cmu.edu>
To: ryan@clutteredmind.org
Subject: [PATCH]SDL mprotect() crash fix
(I'm going to throw this patch your way at the suggestion of #SDL --
for some reason, I had some difficulty sending it to the main list
last time, and I go bonkers subscribing to send each email or
patch...)
Currently, when I run SDL applications as non-root using
SDL_VIDEODRIVER=dga, the fbdev fallback mprotect()s read/write the
proper size of mmapped /dev/fb0 (7.5MB), but on framebuffer release
mprotect()s read-only the range by the entire size of my video memory
(128MB), which causes a segfault:
#0 0x002a9a27 in ?? () from /lib/libc.so.6
#1 0x04a63eb6 in SDL_XDGAUnmapFramebuffer (screen=3D0) at XF86DGA2.c:978
#2 0x04a63efc in SDL_XDGACloseFramebuffer (dpy=3D0x9d3f008, screen=3D0)
at XF86DGA2.c:268
#3 0x04a68b57 in DGA_Available () at SDL_dgavideo.c:98
#4 0x04a53677 in SDL_VideoInit (driver_name=3D0xbfb0bfc7 "dga", flags=3D0)
at SDL_video.c:180
#5 0x04a2613f in SDL_InitSubSystem (flags=3D32) at SDL.c:74
#6 0x04a2617c in SDL_Init (flags=3D32) at SDL.c:166
#7 0x08049722 in main (argc=3D1, argv=3D0x0) at testwin.c:32
This is SDL 1.2.8 on Fedora Core 4, radeon driver for a Radeon 9250,
xorg-x11-6.8.2-37.
I've attached a one-line patch against SDL CVS that updates the size
of the framebuffer at framebuffer map time so that the mprotect() on
unmap will be the same size. I'm not sure if this is the best
approach (i.e. one might want to retain the original value), but it
does make my SDL applications work without segfaulting.
-- Best of luck, Mark Schreiber
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Sat, 19 Nov 2005 18:57:00 +0000 |
parents | b8d311d90021 |
children | c9b51268668f |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif /* StormMesa implementation of SDL OpenGL support */ #include "SDL_error.h" #include "SDL_cgxgl_c.h" #include "SDL_cgxvideo.h" #ifdef HAVE_OPENGL AmigaMesaContext glcont=NULL; #endif /* Init OpenGL */ int CGX_GL_Init(_THIS) { #ifdef HAVE_OPENGL int i = 0; struct TagItem attributes [ 14 ]; /* 14 should be more than enough :) */ struct Window *win = (struct Window *)SDL_Window; // default config. Always used... attributes[i].ti_Tag = AMA_Window; attributes[i++].ti_Data = (unsigned long)win; attributes[i].ti_Tag = AMA_Left; attributes[i++].ti_Data = 0; attributes[i].ti_Tag = AMA_Bottom; attributes[i++].ti_Data = 0; attributes[i].ti_Tag = AMA_Width; attributes[i++].ti_Data = win->Width-win->BorderLeft-win->BorderRight; attributes[i].ti_Tag = AMA_Height; attributes[i++].ti_Data = win->Height-win->BorderBottom-win->BorderTop; attributes[i].ti_Tag = AMA_DirectRender; attributes[i++].ti_Data = GL_TRUE; // double buffer ? attributes[i].ti_Tag = AMA_DoubleBuf; if ( this->gl_config.double_buffer ) { attributes[i++].ti_Data = GL_TRUE; } else { attributes[i++].ti_Data = GL_FALSE; } // RGB(A) Mode ? attributes[i].ti_Tag = AMA_RGBMode; if ( this->gl_config.red_size != 0 && this->gl_config.blue_size != 0 && this->gl_config.green_size != 0 ) { attributes[i++].ti_Data = GL_TRUE; } else { attributes[i++].ti_Data = GL_FALSE; } // no depth buffer ? if ( this->gl_config.depth_size == 0 ) { attributes[i].ti_Tag = AMA_NoDepth; attributes[i++].ti_Data = GL_TRUE; } // no stencil buffer ? if ( this->gl_config.stencil_size == 0 ) { attributes[i].ti_Tag = AMA_NoStencil; attributes[i++].ti_Data = GL_TRUE; } // no accum buffer ? if ( this->gl_config.accum_red_size != 0 && this->gl_config.accum_blue_size != 0 && this->gl_config.accum_green_size != 0 ) { attributes[i].ti_Tag = AMA_NoAccum; attributes[i++].ti_Data = GL_TRUE; } // done... attributes[i].ti_Tag = TAG_DONE; glcont = AmigaMesaCreateContext(attributes); if ( glcont == NULL ) { SDL_SetError("Couldn't create OpenGL context"); return(-1); } this->gl_data->gl_active = 1; this->gl_config.driver_loaded = 1; return(0); #else SDL_SetError("OpenGL support not configured"); return(-1); #endif } /* Quit OpenGL */ void CGX_GL_Quit(_THIS) { #ifdef HAVE_OPENGL if ( glcont != NULL ) { AmigaMesaDestroyContext(glcont); glcont = NULL; this->gl_data->gl_active = 0; this->gl_config.driver_loaded = 0; } #endif } /* Attach context to another window */ int CGX_GL_Update(_THIS) { #ifdef HAVE_OPENGL struct TagItem tags[2]; struct Window *win = (struct Window*)SDL_Window; if(glcont == NULL) { return -1; //should never happen } tags[0].ti_Tag = AMA_Window; tags[0].ti_Data = (unsigned long)win; tags[1].ti_Tag = TAG_DONE; AmigaMesaSetRast(glcont, tags); return 0; #else SDL_SetError("OpenGL support not configured"); return -1; #endif } #ifdef HAVE_OPENGL /* Make the current context active */ int CGX_GL_MakeCurrent(_THIS) { if(glcont == NULL) return -1; AmigaMesaMakeCurrent(glcont, glcont->buffer); return 0; } void CGX_GL_SwapBuffers(_THIS) { AmigaMesaSwapBuffers(glcont); } int CGX_GL_GetAttribute(_THIS, SDL_GLattr attrib, int* value) { GLenum mesa_attrib; switch(attrib) { case SDL_GL_RED_SIZE: mesa_attrib = GL_RED_BITS; break; case SDL_GL_GREEN_SIZE: mesa_attrib = GL_GREEN_BITS; break; case SDL_GL_BLUE_SIZE: mesa_attrib = GL_BLUE_BITS; break; case SDL_GL_ALPHA_SIZE: mesa_attrib = GL_ALPHA_BITS; break; case SDL_GL_DOUBLEBUFFER: mesa_attrib = GL_DOUBLEBUFFER; break; case SDL_GL_DEPTH_SIZE: mesa_attrib = GL_DEPTH_BITS; break; case SDL_GL_STENCIL_SIZE: mesa_attrib = GL_STENCIL_BITS; break; case SDL_GL_ACCUM_RED_SIZE: mesa_attrib = GL_ACCUM_RED_BITS; break; case SDL_GL_ACCUM_GREEN_SIZE: mesa_attrib = GL_ACCUM_GREEN_BITS; break; case SDL_GL_ACCUM_BLUE_SIZE: mesa_attrib = GL_ACCUM_BLUE_BITS; break; case SDL_GL_ACCUM_ALPHA_SIZE: mesa_attrib = GL_ACCUM_ALPHA_BITS; break; default : return -1; } AmigaMesaGetConfig(glcont->visual, mesa_attrib, value); return 0; } void *CGX_GL_GetProcAddress(_THIS, const char *proc) { void *func = NULL; func = AmiGetGLProc(proc); return func; } int CGX_GL_LoadLibrary(_THIS, const char *path) { /* Library is always open */ this->gl_config.driver_loaded = 1; return 0; } #endif /* HAVE_OPENGL */