Mercurial > sdl-ios-xcode
view src/audio/mint/SDL_mintaudio_stfa.h @ 1176:dd2a8deeb26d
Date: Mon, 17 Oct 2005 20:09:03 -0400
From: Mark Schreiber <mark7@alumni.cmu.edu>
To: ryan@clutteredmind.org
Subject: [PATCH]SDL mprotect() crash fix
(I'm going to throw this patch your way at the suggestion of #SDL --
for some reason, I had some difficulty sending it to the main list
last time, and I go bonkers subscribing to send each email or
patch...)
Currently, when I run SDL applications as non-root using
SDL_VIDEODRIVER=dga, the fbdev fallback mprotect()s read/write the
proper size of mmapped /dev/fb0 (7.5MB), but on framebuffer release
mprotect()s read-only the range by the entire size of my video memory
(128MB), which causes a segfault:
#0 0x002a9a27 in ?? () from /lib/libc.so.6
#1 0x04a63eb6 in SDL_XDGAUnmapFramebuffer (screen=3D0) at XF86DGA2.c:978
#2 0x04a63efc in SDL_XDGACloseFramebuffer (dpy=3D0x9d3f008, screen=3D0)
at XF86DGA2.c:268
#3 0x04a68b57 in DGA_Available () at SDL_dgavideo.c:98
#4 0x04a53677 in SDL_VideoInit (driver_name=3D0xbfb0bfc7 "dga", flags=3D0)
at SDL_video.c:180
#5 0x04a2613f in SDL_InitSubSystem (flags=3D32) at SDL.c:74
#6 0x04a2617c in SDL_Init (flags=3D32) at SDL.c:166
#7 0x08049722 in main (argc=3D1, argv=3D0x0) at testwin.c:32
This is SDL 1.2.8 on Fedora Core 4, radeon driver for a Radeon 9250,
xorg-x11-6.8.2-37.
I've attached a one-line patch against SDL CVS that updates the size
of the framebuffer at framebuffer map time so that the mprotect() on
unmap will be the same size. I'm not sure if this is the best
approach (i.e. one might want to retain the original value), but it
does make my SDL applications work without segfaulting.
-- Best of luck, Mark Schreiber
| author | Ryan C. Gordon <icculus@icculus.org> |
|---|---|
| date | Sat, 19 Nov 2005 18:57:00 +0000 |
| parents | b8d311d90021 |
| children | d910939febfa |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ /* STFA control structure Patrice Mandin */ #ifndef _SDL_mintaudio_stfa_h #define _SDL_mintaudio_stfa_h /*--- Defines ---*/ #define C_STFA 0x53544641L /* Sound treiber für atari (seb/The removers) */ #define STFA_PLAY_ENABLE (1<<0) #define STFA_PLAY_DISABLE (0<<0) #define STFA_PLAY_REPEAT (1<<1) #define STFA_PLAY_SINGLE (0<<1) #define STFA_FORMAT_SIGNED (1<<15) #define STFA_FORMAT_UNSIGNED (0<<15) #define STFA_FORMAT_STEREO (1<<14) #define STFA_FORMAT_MONO (0<<14) #define STFA_FORMAT_16BIT (1<<13) #define STFA_FORMAT_8BIT (0<<13) #define STFA_FORMAT_LITENDIAN (1<<9) #define STFA_FORMAT_BIGENDIAN (0<<9) #define STFA_FORMAT_FREQ_MASK 0x0f enum { STFA_FORMAT_F4995=0, STFA_FORMAT_F6269, STFA_FORMAT_F7493, STFA_FORMAT_F8192, STFA_FORMAT_F9830, STFA_FORMAT_F10971, STFA_FORMAT_F12538, STFA_FORMAT_F14985, STFA_FORMAT_F16384, STFA_FORMAT_F19819, STFA_FORMAT_F21943, STFA_FORMAT_F24576, STFA_FORMAT_F30720, STFA_FORMAT_F32336, STFA_FORMAT_F43885, STFA_FORMAT_F49152 }; /*--- Types ---*/ typedef struct { unsigned short sound_enable; unsigned short sound_control; unsigned short sound_output; unsigned long sound_start; unsigned long sound_current; unsigned long sound_end; unsigned short version; void *old_vbl; void *old_timera; unsigned long old_mfp_status; void *new_vbl; void *drivers_list; void *play_stop; unsigned short frequency; void *set_frequency; unsigned short frequency_threshold; unsigned short *custom_freq_table; unsigned short stfa_on_off; void *new_drivers_list; unsigned long old_bit_2_of_cookie_snd; void (*stfa_it)(void); } cookie_stfa_t __attribute__((packed)); #endif /* _SDL_mintaudio_stfa_h */