Mercurial > sdl-ios-xcode
view CREDITS @ 773:da0a2ad35bf4
Date: Sun, 4 Jan 2004 23:48:19 +0100
From: Max Horn
Subject: Re: Again Audio CD patch
Am 04.01.2004 um 22:38 schrieb Sam Lantinga:
>
> Okay, I fixed the buffering problems by simply using a 4 second buffer
> instead of a 1 second buffer. However, using your code I can't play an
> entire CD - the playback stops after the first song.
>
Found the problem: FSReadFork returns eofErr when the file is finished.
However, we check its return value for errors, and if anything but
noErr occurs, the reader thread aborts its current iteration. That is
bad, because it aborts before it can ever set the flag which tells that
the file is over (also, any remaining data which FSRead did return is
lost - so you'd not hear about to 4 seconds from the end of the file.
Furthermore, the computed data size was 8 bytes to high (I forgot to
account for the fact that the size of an (A)IFF chunk always contains
the chunk header & size fields, too). This is enough to make it work.
However, the end condition is rather fragile, so I tuned some other
things to be pessimistic (check for <= 0 instead of == 0, when eofErr
is encountered enforce mReadFilePosition == mFileLength). You never
know...
The attached patch fixes the issue for me.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Mon, 05 Jan 2004 00:57:51 +0000 |
| parents | 877b992f2d0c |
| children | b10aeac509ea |
line wrap: on
line source
Simple DirectMedia Layer CREDITS Thanks to everyone who made this possible, including: * Cliff Matthews, for giving me a reason to start this project. :) -- Executor rocks! *grin* * Scott Call, for making a home for SDL on the 'Net... Thanks! :) * The Linux Fund, C Magazine, and Gareth Noyce for financial contributions * Gaëtan de Menten for writing the PHP and SQL behind the SDL website * Martin Donlon for his work on the SDL Documentation Project * Ryan Gordon for helping everybody out and keeping the dream alive. :) * Mattias Engdegård, for help with the Solaris port and lots of other help * Max Watson, Matt Slot, and Kyle for help with the MacOS Classic port * Stan Shebs, for the initial MacOS X port * Max Horn and Darrell Walisser for unflagging work on the MacOS X port * Patrick Trainor, Jim Boucher, and Mike Gorchak for the QNX Neutrino port * Carsten Griwodz for the AIX port * Gabriele Greco, for the Amiga port * Patrice Mandin, for the Atari port * Hannu Viitala for the EPOC port * Peter Valchev for nagging me about the OpenBSD port until I got it right. :) * Kent B Mein, for a place to do the IRIX port * Ash, for a place to do the OSF/1 Alpha port * David Sowsy, for help with the BeOS port * Eugenia Loli, for endless work on porting SDL games to BeOS * Jon Taylor for the GGI front-end * Paulus Esterhazy, for the Visual C++ testing and libraries * Brenda Tantzen, for Metrowerks CodeWarrior on MacOS * Chris Nentwich, for the Hermes assembly blitters * Michael Vance and Jim Kutter for the X11 OpenGL support * Stephane Peter, for the AAlib front-end and multi-threaded timer idea. * Jon Atkins for great SDL_net and SDL_mixer documentation * Peter Wiklund, for the 1998 winning SDL logo, and Arto Hamara, Steven Wong, and Kent Mein for other logo entries. * Everybody at Loki Software, Inc. for their great contributions! And a big hand to everyone else who gave me appreciation, advice, and suggestions, especially the good folks on the SDL mailing list. THANKS! :) -- Sam Lantinga <slouken@libsdl.org>