Mercurial > sdl-ios-xcode
view test/testnativex11.c @ 5126:d79ff339d1f2
Fixed bug #1056 (Frequent crashes in Touch events by simply touching the screen)
Joseba GarcĂa Echebarria 2010-12-15 01:55:22 PST
I believe the crash is caused by a check not being performed on wether an
SDL_Touch element is NULL before using it in the SDL_SendTouchMotion function
in src/events/SDL_touch.c around line 400.
Judging from the rest of the code, there's a missing
if (!touch) {
return 0;
}
before using "touch" as SDL_GetFinger(), SDL_GetFingerIndexId() use
touch->num_fingers without checking.
I can attach a patch if you like. It seems pretty straightforward, though.
I have yet to discover why touch is being returned as NULL as this error is
only triggered when an actual gesture has been performed, maybe something
related to SDL_AddTouch()?
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 28 Jan 2011 10:21:58 -0800 |
parents | 089a77aebb7d |
children |
line wrap: on
line source
#include "testnative.h" #ifdef TEST_NATIVE_X11 static void *CreateWindowX11(int w, int h); static void DestroyWindowX11(void *window); NativeWindowFactory X11WindowFactory = { "x11", CreateWindowX11, DestroyWindowX11 }; static Display *dpy; static void * CreateWindowX11(int w, int h) { Window window = 0; dpy = XOpenDisplay(NULL); if (dpy) { window = XCreateSimpleWindow(dpy, DefaultRootWindow(dpy), 0, 0, w, h, 0, 0, 0); XMapRaised(dpy, window); XSync(dpy, False); } return (void *) window; } static void DestroyWindowX11(void *window) { if (dpy) { XDestroyWindow(dpy, (Window) window); XCloseDisplay(dpy); } } #endif