Mercurial > sdl-ios-xcode
view src/video/qnxgf/SDL_gf_render.h @ 5126:d79ff339d1f2
Fixed bug #1056 (Frequent crashes in Touch events by simply touching the screen)
Joseba GarcĂa Echebarria 2010-12-15 01:55:22 PST
I believe the crash is caused by a check not being performed on wether an
SDL_Touch element is NULL before using it in the SDL_SendTouchMotion function
in src/events/SDL_touch.c around line 400.
Judging from the rest of the code, there's a missing
if (!touch) {
return 0;
}
before using "touch" as SDL_GetFinger(), SDL_GetFingerIndexId() use
touch->num_fingers without checking.
I can attach a patch if you like. It seems pretty straightforward, though.
I have yet to discover why touch is being returned as NULL as this error is
only triggered when an actual gesture has been performed, maybe something
related to SDL_AddTouch()?
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 28 Jan 2011 10:21:58 -0800 |
parents | f7b03b6838cb |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org QNX Graphics Framework SDL driver Copyright (C) 2009 Mike Gorchak (mike@malva.ua, lestat@i.com.ua) */ #ifndef __SDL_GF_RENDER_H__ #define __SDL_GF_RENDER_H__ #include "../SDL_sysvideo.h" #include <gf/gf.h> #define SDL_GF_MAX_SURFACES 3 typedef struct SDL_RenderData { SDL_Window *window; /* SDL window type */ SDL_bool enable_vsync; /* VSYNC flip synchronization enable */ gf_surface_t surface[SDL_GF_MAX_SURFACES]; /* Surface handles */ gf_surface_info_t surface_info[SDL_GF_MAX_SURFACES]; /* Surface info */ uint32_t surface_visible_idx; /* Index of visible surface */ uint32_t surface_render_idx; /* Index of render surface */ uint32_t surfaces_count; /* Amount of allocated surfaces */ } SDL_RenderData; typedef struct SDL_TextureData { gf_surface_t surface; gf_surface_info_t surface_info; } SDL_TextureData; extern void gf_addrenderdriver(_THIS); #endif /* __SDL_GF_RENDER_H__ */ /* vi: set ts=4 sw=4 expandtab: */