Mercurial > sdl-ios-xcode
view src/video/Xext/extensions/Xv.h @ 5126:d79ff339d1f2
Fixed bug #1056 (Frequent crashes in Touch events by simply touching the screen)
Joseba GarcĂa Echebarria 2010-12-15 01:55:22 PST
I believe the crash is caused by a check not being performed on wether an
SDL_Touch element is NULL before using it in the SDL_SendTouchMotion function
in src/events/SDL_touch.c around line 400.
Judging from the rest of the code, there's a missing
if (!touch) {
return 0;
}
before using "touch" as SDL_GetFinger(), SDL_GetFingerIndexId() use
touch->num_fingers without checking.
I can attach a patch if you like. It seems pretty straightforward, though.
I have yet to discover why touch is being returned as NULL as this error is
only triggered when an actual gesture has been performed, maybe something
related to SDL_AddTouch()?
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 28 Jan 2011 10:21:58 -0800 |
parents | c121d94672cb |
children |
line wrap: on
line source
/*********************************************************** Copyright 1991 by Digital Equipment Corporation, Maynard, Massachusetts, and the Massachusetts Institute of Technology, Cambridge, Massachusetts. All Rights Reserved Permission to use, copy, modify, and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the above copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation, and that the names of Digital or MIT not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. DIGITAL DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO EVENT SHALL DIGITAL BE LIABLE FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. ******************************************************************/ /* $XFree86: xc/include/extensions/Xv.h,v 1.5 1999/12/11 19:28:48 mvojkovi Exp $ */ #ifndef XV_H #define XV_H /* ** File: ** ** Xv.h --- Xv shared library and server header file ** ** Author: ** ** David Carver (Digital Workstation Engineering/Project Athena) ** ** Revisions: ** ** 05.15.91 Carver ** - version 2.0 upgrade ** ** 01.24.91 Carver ** - version 1.4 upgrade ** */ #include <X11/X.h> #define XvName "XVideo" #define XvVersion 2 #define XvRevision 2 /* Symbols */ typedef XID XvPortID; typedef XID XvEncodingID; #define XvNone 0 #define XvInput 0 #define XvOutput 1 #define XvInputMask (1L<<XvInput) #define XvOutputMask (1L<<XvOutput) #define XvVideoMask 0x00000004 #define XvStillMask 0x00000008 #define XvImageMask 0x00000010 /* These two are not client viewable */ #define XvPixmapMask 0x00010000 #define XvWindowMask 0x00020000 #define XvGettable 0x01 #define XvSettable 0x02 #define XvRGB 0 #define XvYUV 1 #define XvPacked 0 #define XvPlanar 1 #define XvTopToBottom 0 #define XvBottomToTop 1 /* Events */ #define XvVideoNotify 0 #define XvPortNotify 1 #define XvNumEvents 2 /* Video Notify Reasons */ #define XvStarted 0 #define XvStopped 1 #define XvBusy 2 #define XvPreempted 3 #define XvHardError 4 #define XvLastReason 4 #define XvNumReasons (XvLastReason + 1) #define XvStartedMask (1L<<XvStarted) #define XvStoppedMask (1L<<XvStopped) #define XvBusyMask (1L<<XvBusy) #define XvPreemptedMask (1L<<XvPreempted) #define XvHardErrorMask (1L<<XvHardError) #define XvAnyReasonMask ((1L<<XvNumReasons) - 1) #define XvNoReasonMask 0 /* Errors */ #define XvBadPort 0 #define XvBadEncoding 1 #define XvBadControl 2 #define XvNumErrors 3 /* Status */ #define XvBadExtension 1 #define XvAlreadyGrabbed 2 #define XvInvalidTime 3 #define XvBadReply 4 #define XvBadAlloc 5 #endif /* XV_H */ /* vi: set ts=4 sw=4 expandtab: */