Mercurial > sdl-ios-xcode
view src/video/Xext/extensions/Xinerama.h @ 5126:d79ff339d1f2
Fixed bug #1056 (Frequent crashes in Touch events by simply touching the screen)
Joseba GarcĂa Echebarria 2010-12-15 01:55:22 PST
I believe the crash is caused by a check not being performed on wether an
SDL_Touch element is NULL before using it in the SDL_SendTouchMotion function
in src/events/SDL_touch.c around line 400.
Judging from the rest of the code, there's a missing
if (!touch) {
return 0;
}
before using "touch" as SDL_GetFinger(), SDL_GetFingerIndexId() use
touch->num_fingers without checking.
I can attach a patch if you like. It seems pretty straightforward, though.
I have yet to discover why touch is being returned as NULL as this error is
only triggered when an actual gesture has been performed, maybe something
related to SDL_AddTouch()?
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 28 Jan 2011 10:21:58 -0800 |
parents | c121d94672cb |
children |
line wrap: on
line source
/* $XFree86: xc/include/extensions/Xinerama.h,v 3.2 2000/03/01 01:04:20 dawes Exp $ */ #ifndef _Xinerama_h #define _Xinerama_h #include "SDL_name.h" typedef struct { int screen_number; short x_org; short y_org; short width; short height; } SDL_NAME(XineramaScreenInfo); Bool SDL_NAME(XineramaQueryExtension) (Display * dpy, int *event_base, int *error_base); Status SDL_NAME(XineramaQueryVersion) (Display * dpy, int *major, int *minor); Bool SDL_NAME(XineramaIsActive) (Display * dpy); /* Returns the number of heads and a pointer to an array of structures describing the position and size of the individual heads. Returns NULL and number = 0 if Xinerama is not active. Returned array should be freed with XFree(). */ SDL_NAME(XineramaScreenInfo) * SDL_NAME(XineramaQueryScreens) (Display * dpy, int *number); #endif /* _Xinerama_h */ /* vi: set ts=4 sw=4 expandtab: */