view .DISABLED-hgeol @ 5126:d79ff339d1f2

Fixed bug #1056 (Frequent crashes in Touch events by simply touching the screen) Joseba GarcĂ­a Echebarria 2010-12-15 01:55:22 PST I believe the crash is caused by a check not being performed on wether an SDL_Touch element is NULL before using it in the SDL_SendTouchMotion function in src/events/SDL_touch.c around line 400. Judging from the rest of the code, there's a missing if (!touch) { return 0; } before using "touch" as SDL_GetFinger(), SDL_GetFingerIndexId() use touch->num_fingers without checking. I can attach a patch if you like. It seems pretty straightforward, though. I have yet to discover why touch is being returned as NULL as this error is only triggered when an actual gesture has been performed, maybe something related to SDL_AddTouch()?
author Sam Lantinga <slouken@libsdl.org>
date Fri, 28 Jan 2011 10:21:58 -0800
parents 2936fc46b015
children
line wrap: on
line source

[patterns]
.hgeol = native
.hgignore = native
BUGS = native
CREDITS = native
INSTALL = native
NOTES = native
TODO = native
WhatsNew = native
**COPYING = native
**README = native
**doxyfile = native
**Doxyfile = native
**install-sh = LF
**mkinstalldirs = LF
**Makefile = LF
**Makefile.* = LF
test/automated/rwops/read = LF
**README.* = native
**.S = native
**.bmp = BIN
**.c = native
**.cc = native
**.cpp = native
**.csh = LF
**.dat = BIN
**.gdbinit = LF
build-scripts/config.guess = LF
**.h = native
**.htm = native
**.html = native
**.icns = BIN
**.in = LF
**.java = native
**.m = native
**.m4 = native
**.mk = LF
**.nib = BIN
**.pch = BIN
**.pdf = BIN
**.pl = native
**.plist = native
**.png = BIN
.indent.pro = LF
**.rc = native
**.rtf = BIN
**.sh = LF
**.sln = native
**.txt = native
**.vcp = native
**.vcproj = native
**.vcw = native
**.vcxproj = native
**.wav = BIN
**.xbm = BIN
**.xml = native
**.zip = BIN