Mercurial > sdl-ios-xcode
view docs/html/sdlfillrect.html @ 3069:caefe2344f65
Date: Thu, 27 Dec 2007 07:38:25 +0000
From: John Bartholomew
Subject: [SDL] SDL Semaphore implementation broken on Windows?
Hi,
Over the past couple of days, I've been battling with SDL, SDL_Mixer and SMPEG to try to find an audio hang bug. I believe I've found the problem, which I think is a race condition inside SDL's semaphore implementation (at least the Windows implementation). The semaphore code uses Windows' built in semaphore functions, but it also maintains a separate count value. This count value is updated with bare increment and decrement operations in SemPost and SemWaitTimeout - no locking primitives to protect them.
In tracking down the apparent audio bug, I found that at some point a semaphore's count value was being decremented to -1, which is clearly not a valid value for it to take.
I'm still not certain exactly what sequence of operations is occuring for this to happen, but I believe that overall it's a race condition between a thread calling SemPost (which increments the count) and the thread on the other end calling SemWait (which decrements it).
I will try to make a test case to verify this, but I'm not sure if I'll be able to (threading errors being difficult to reproduce even in the best circumstances).
However, assuming this is the cause of my problems, there is a very
simple fix:
Windows provides InterlockedIncrement() and InterlockedDecrement()
functions to perform increments and decrements which are guaranteed to be atomic. So the fix is in thread/win32/SDL_syssem.c: replace occurrences of --sem->count with InterlockedDecrement(&sem->count); and replace occurrences of ++sem->count with InterlockedIncrement(&sem->count);
This is using SDL v1.2.12, built with VC++ 2008 Express, running on a
Core 2 duo processor.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 17 Feb 2009 05:39:18 +0000 |
parents | 355632dca928 |
children |
line wrap: on
line source
<HTML ><HEAD ><TITLE >SDL_FillRect</TITLE ><META NAME="GENERATOR" CONTENT="Modular DocBook HTML Stylesheet Version 1.76b+ "><LINK REL="HOME" TITLE="SDL Library Documentation" HREF="index.html"><LINK REL="UP" TITLE="Video" HREF="video.html"><LINK REL="PREVIOUS" TITLE="SDL_BlitSurface" HREF="sdlblitsurface.html"><LINK REL="NEXT" TITLE="SDL_DisplayFormat" HREF="sdldisplayformat.html"></HEAD ><BODY CLASS="REFENTRY" BGCOLOR="#FFF8DC" TEXT="#000000" LINK="#0000ee" VLINK="#551a8b" ALINK="#ff0000" ><DIV CLASS="NAVHEADER" ><TABLE SUMMARY="Header navigation table" WIDTH="100%" BORDER="0" CELLPADDING="0" CELLSPACING="0" ><TR ><TH COLSPAN="3" ALIGN="center" >SDL Library Documentation</TH ></TR ><TR ><TD WIDTH="10%" ALIGN="left" VALIGN="bottom" ><A HREF="sdlblitsurface.html" ACCESSKEY="P" >Prev</A ></TD ><TD WIDTH="80%" ALIGN="center" VALIGN="bottom" ></TD ><TD WIDTH="10%" ALIGN="right" VALIGN="bottom" ><A HREF="sdldisplayformat.html" ACCESSKEY="N" >Next</A ></TD ></TR ></TABLE ><HR ALIGN="LEFT" WIDTH="100%"></DIV ><H1 ><A NAME="SDLFILLRECT" ></A >SDL_FillRect</H1 ><DIV CLASS="REFNAMEDIV" ><A NAME="AEN2351" ></A ><H2 >Name</H2 >SDL_FillRect -- This function performs a fast fill of the given rectangle with some color</DIV ><DIV CLASS="REFSYNOPSISDIV" ><A NAME="AEN2354" ></A ><H2 >Synopsis</H2 ><DIV CLASS="FUNCSYNOPSIS" ><A NAME="AEN2355" ></A ><P ></P ><PRE CLASS="FUNCSYNOPSISINFO" >#include "SDL.h"</PRE ><P ><CODE ><CODE CLASS="FUNCDEF" >int <B CLASS="FSFUNC" >SDL_FillRect</B ></CODE >(SDL_Surface *dst, SDL_Rect *dstrect, Uint32 color);</CODE ></P ><P ></P ></DIV ></DIV ><DIV CLASS="REFSECT1" ><A NAME="AEN2361" ></A ><H2 >Description</H2 ><P >This function performs a fast fill of the given rectangle with <TT CLASS="PARAMETER" ><I >color</I ></TT >. If <TT CLASS="PARAMETER" ><I >dstrect</I ></TT > is <TT CLASS="LITERAL" >NULL</TT >, the whole surface will be filled with <TT CLASS="PARAMETER" ><I >color</I ></TT >.</P ><P >The color should be a pixel of the format used by the surface, and can be generated by the <A HREF="sdlmaprgb.html" >SDL_MapRGB</A > or <A HREF="sdlmaprgba.html" >SDL_MapRGBA</A > functions. If the color value contains an alpha value then the destination is simply "filled" with that alpha information, no blending takes place.</P ><P >If there is a clip rectangle set on the destination (set via <A HREF="sdlsetcliprect.html" >SDL_SetClipRect</A >) then this function will clip based on the intersection of the clip rectangle and the <TT CLASS="PARAMETER" ><I >dstrect</I ></TT > rectangle and the dstrect rectangle will be modified to represent the area actually filled.</P ></DIV ><DIV CLASS="REFSECT1" ><A NAME="AEN2374" ></A ><H2 >Return Value</H2 ><P >This function returns <SPAN CLASS="RETURNVALUE" >0</SPAN > on success, or <SPAN CLASS="RETURNVALUE" >-1</SPAN > on error.</P ></DIV ><DIV CLASS="REFSECT1" ><A NAME="AEN2379" ></A ><H2 >See Also</H2 ><P ><A HREF="sdlmaprgb.html" ><TT CLASS="FUNCTION" >SDL_MapRGB</TT ></A >, <A HREF="sdlmaprgb.html" ><TT CLASS="FUNCTION" >SDL_MapRGBA</TT ></A >, <A HREF="sdlblitsurface.html" ><TT CLASS="FUNCTION" >SDL_BlitSurface</TT ></A >, <A HREF="sdlrect.html" ><SPAN CLASS="STRUCTNAME" >SDL_Rect</SPAN ></A ></P ></DIV ><DIV CLASS="NAVFOOTER" ><HR ALIGN="LEFT" WIDTH="100%"><TABLE SUMMARY="Footer navigation table" WIDTH="100%" BORDER="0" CELLPADDING="0" CELLSPACING="0" ><TR ><TD WIDTH="33%" ALIGN="left" VALIGN="top" ><A HREF="sdlblitsurface.html" ACCESSKEY="P" >Prev</A ></TD ><TD WIDTH="34%" ALIGN="center" VALIGN="top" ><A HREF="index.html" ACCESSKEY="H" >Home</A ></TD ><TD WIDTH="33%" ALIGN="right" VALIGN="top" ><A HREF="sdldisplayformat.html" ACCESSKEY="N" >Next</A ></TD ></TR ><TR ><TD WIDTH="33%" ALIGN="left" VALIGN="top" >SDL_BlitSurface</TD ><TD WIDTH="34%" ALIGN="center" VALIGN="top" ><A HREF="video.html" ACCESSKEY="U" >Up</A ></TD ><TD WIDTH="33%" ALIGN="right" VALIGN="top" >SDL_DisplayFormat</TD ></TR ></TABLE ></DIV ></BODY ></HTML >