Mercurial > sdl-ios-xcode
view CREDITS @ 3069:caefe2344f65
Date: Thu, 27 Dec 2007 07:38:25 +0000
From: John Bartholomew
Subject: [SDL] SDL Semaphore implementation broken on Windows?
Hi,
Over the past couple of days, I've been battling with SDL, SDL_Mixer and SMPEG to try to find an audio hang bug. I believe I've found the problem, which I think is a race condition inside SDL's semaphore implementation (at least the Windows implementation). The semaphore code uses Windows' built in semaphore functions, but it also maintains a separate count value. This count value is updated with bare increment and decrement operations in SemPost and SemWaitTimeout - no locking primitives to protect them.
In tracking down the apparent audio bug, I found that at some point a semaphore's count value was being decremented to -1, which is clearly not a valid value for it to take.
I'm still not certain exactly what sequence of operations is occuring for this to happen, but I believe that overall it's a race condition between a thread calling SemPost (which increments the count) and the thread on the other end calling SemWait (which decrements it).
I will try to make a test case to verify this, but I'm not sure if I'll be able to (threading errors being difficult to reproduce even in the best circumstances).
However, assuming this is the cause of my problems, there is a very
simple fix:
Windows provides InterlockedIncrement() and InterlockedDecrement()
functions to perform increments and decrements which are guaranteed to be atomic. So the fix is in thread/win32/SDL_syssem.c: replace occurrences of --sem->count with InterlockedDecrement(&sem->count); and replace occurrences of ++sem->count with InterlockedIncrement(&sem->count);
This is using SDL v1.2.12, built with VC++ 2008 Express, running on a
Core 2 duo processor.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Tue, 17 Feb 2009 05:39:18 +0000 |
| parents | 20d65430e63c |
| children | 7b1da3f37f97 |
line wrap: on
line source
Simple DirectMedia Layer CREDITS Thanks to everyone who made this possible, including: * Cliff Matthews, for giving me a reason to start this project. :) -- Executor rocks! *grin* * The Linux Fund, C Magazine, Educational Technology Resources Inc., Gareth Noyce, Jesse Pavel, Keith Kitchin, Jeremy Horvath, Thomas Nicholson, Hans-Peter Gygax, the Eternal Lands Development Team, Lars Brubaker, and Phoenix Kokido for financial contributions * Edgar "bobbens" Simo for his force feedback API development during the Google Summer of Code 2008 * Aaron Wishnick for his work on audio resampling and pitch shifting during the Google Summer of Code 2008 * Holmes Futrell for port of SDL to the iPhone and iPod Touch during the Google Summer of Code 2008 * Darren Alton for port of SDL to the Nintendo DS during the Google Summer of Code 2008 * Szymon "Wilku" Wilczek for adding support for multiple mice and tablets during the Google Summer of Code 2008 * Marty Leisner, Andrew, Will, Edgar Simo, Donny Viszneki, Andrea Mazzoleni, Dmytro Bogovych, and Couriersud for helping find SDL 1.3 bugs in the great SDL Bug Hunt of January 2009! * Donny Viszneki for helping fix SDL 1.3 bugs in the great SDL Bug Hunt of January 2009! * Gaëtan de Menten for writing the PHP and SQL behind the SDL website * Tim Jones for the new look of the SDL website * Ryan Gordon for helping everybody out and keeping the dream alive. :) * Mattias Engdegård, for help with the Solaris port and lots of other help * Eric Wing, Max Horn, and Darrell Walisser for unflagging work on the Mac OS X port * Couriersud for the DirectFB driver * Patrice Mandin, for the Atari port * Jon Atkins for SDL_image, SDL_mixer and SDL_net documentation * Arne Claus, for the 2004 winning SDL logo, and Shandy Brown, Jac, Alex Lyman, Mikkel Gjoel, #Guy, Jonas Hartmann, Daniel Liljeberg, Ronald Sowa, DocD, Pekka Jaervinen, Patrick Avella, Erkki Kontilla, Levon Gavalian, Hal Emerich, David Wiktorsson, S. Schury and F. Hufsky, Ciska de Ruyver, Shredweat, Tyler Montbriand, Martin Andersson, Merlyn Wysard, Fernando Ibanez, David Miller, Andre Bommele, lovesby.com, Francisco Camenforte Torres, and David Igreja for other logo entries. * Bob Pendleton and David Olofson for being long time contributors to the SDL mailing list. * Everybody at Loki Software, Inc. for their great contributions! And a big hand to everyone else who gave me appreciation, advice, and suggestions, especially the good folks on the SDL mailing list. THANKS! :) -- Sam Lantinga <slouken@libsdl.org>