Mercurial > sdl-ios-xcode
view src/video/maccommon/Makefile.am @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 12 Aug 2003 15:17:20 +0000 |
parents | 74212992fb08 |
children |
line wrap: on
line source
## Makefile.am for SDL using the MacOS toolbox noinst_LTLIBRARIES = libvideo_maccommon.la libvideo_maccommon_la_SOURCES = $(COMMON_SRCS) # The SDL Mac toolbox driver sources COMMON_SRCS = \ SDL_lowvideo.h \ SDL_macevents.c \ SDL_macevents_c.h \ SDL_macgl.c \ SDL_macgl_c.h \ SDL_mackeys.h \ SDL_macmouse.c \ SDL_macmouse_c.h \ SDL_macwm.c \ SDL_macwm_c.h