Mercurial > sdl-ios-xcode
view src/video/gem/Makefile.am @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 12 Aug 2003 15:17:20 +0000 |
parents | c5010ab8ba35 |
children |
line wrap: on
line source
## Makefile.am for SDL using the GEM video driver noinst_LTLIBRARIES = libvideo_gem.la libvideo_gem_la_SOURCES = $(GEM_SRCS) # The SDL GEM video driver sources GEM_SRCS = \ SDL_gemvideo.h \ SDL_gemvideo.c \ SDL_gemevents_c.h \ SDL_gemevents.c \ SDL_gemmouse_c.h \ SDL_gemmouse.c \ SDL_gemwm_c.h \ SDL_gemwm.c