Mercurial > sdl-ios-xcode
view src/hermes/Makefile.am @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 12 Aug 2003 15:17:20 +0000 |
parents | b98f732b4322 |
children | dac996d69abb |
line wrap: on
line source
########################################################################### # # Some consistent rules for building asm files: STRIP_FPIC = sh $(top_srcdir)/strip_fPIC.sh SUFFIXES = .asm .asm.lo: $(LIBTOOL) --mode=compile $(STRIP_FPIC) $(NASM) @NASMFLAGS@ $< -o $*.o ########################################################################### # The hermes library target noinst_LTLIBRARIES = libhermes.la libhermes_la_SOURCES = $(PORTABLE_SRCS) am_libhermes_la_OBJECTS = \ mmx_main.lo \ mmxp2_32.lo \ x86_main.lo \ x86p_16.lo \ x86p_32.lo # The hermes library sources PORTABLE_SRCS = \ mmx_main.asm \ mmxp2_32.asm \ x86_main.asm \ x86p_16.asm \ x86p_32.asm \ \ HeadMMX.h \ HeadX86.h EXTRA_DIST = \ COPYING.LIB \ README