Mercurial > sdl-ios-xcode
view src/cdrom/macosx/CDPlayer.h @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 12 Aug 2003 15:17:20 +0000 |
parents | 9c6717a1c66f |
children | 4bb432a0f6e0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997, 1998, 1999, 2000, 2001, 2002 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifndef __CDPlayer__H__ #define __CDPlayer__H__ 1 #include <CoreFoundation/CoreFoundation.h> #include <Carbon/Carbon.h> #include <AudioUnit/AudioUnit.h> #include <AudioToolbox/AudioToolbox.h> #include <SDL.h> #include <string.h> #include <unistd.h> // for usleep #ifdef __cplusplus extern "C" { #endif typedef void (*CDPlayerCompletionProc)(SDL_CD *cdrom) ; void Lock (); void Unlock(); int LoadFile (const FSRef *ref, int startFrame, int endFrame); // pass -1 to do nothing int ReleaseFile (); int PlayFile (); int PauseFile (); void SetCompletionProc (CDPlayerCompletionProc proc, SDL_CD *cdrom); int ReadTOCData (FSVolumeRefNum theVolume, SDL_CD *theCD); int ListTrackFiles (FSVolumeRefNum theVolume, FSRef *trackFiles, int numTracks); int DetectAudioCDVolumes (FSVolumeRefNum *volumes, int numVolumes); int GetCurrentFrame (); #ifdef __cplusplus }; #endif #endif /* __CD_Player__H__ */