Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST) From: "Mattias Engdeg?rd" Subject: bug in SDL_GetRGB/GetRGBA There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there for years. It incorrectly converts colours with < 8 bits/channel. It came to my attention today in #sdl. What it does now is (for each channel): rv = (pixel & fmt->Rmask) >> fmt->Rshift; *r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss)); which is wrong; the last line should be *r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));

## Makefile.am for the SDL cdrom library

noinst_LTLIBRARIES = libcdrom.la

# Define which subdirectories need to be built
SUBDIRS = @CDROM_SUBDIRS@
DIST_SUBDIRS =	\
	aix	\
	beos	\
	bsdi	\
	dc	\
	dummy	\
	freebsd	\
	linux	\
	macos	\
	macosx	\
	openbsd	\
	osf	\
	qnx	\
	win32

DRIVERS = @CDROM_DRIVERS@

# Include the architecture-independent sources
COMMON_SRCS =			\
	SDL_cdrom.c		\
	SDL_syscdrom.h

libcdrom_la_SOURCES = $(COMMON_SRCS)
libcdrom_la_LIBADD = $(DRIVERS)
libcdrom_la_DEPENDENCIES = $(DRIVERS)