Mercurial > sdl-ios-xcode
view docs/html/sdlcolor.html @ 688:c0522010bb6d
Date: Tue, 12 Aug 2003 14:26:19 +0200 (MEST)
From: "Mattias Engdeg?rd"
Subject: bug in SDL_GetRGB/GetRGBA
There's an embarrassing bug in GetRGB/GetRGBA which apparently has been there
for years. It incorrectly converts colours with < 8 bits/channel.
It came to my attention today in #sdl.
What it does now is (for each channel):
rv = (pixel & fmt->Rmask) >> fmt->Rshift;
*r = (rv << fmt->Rloss) + (rv >> (8 - fmt->Rloss));
which is wrong; the last line should be
*r = (rv << fmt->Rloss) + (rv >> (8 - (fmt->Rloss << 1)));
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Tue, 12 Aug 2003 15:17:20 +0000 |
parents | e5bc29de3f0a |
children | 355632dca928 |
line wrap: on
line source
<HTML ><HEAD ><TITLE >SDL_Color</TITLE ><META NAME="GENERATOR" CONTENT="Modular DocBook HTML Stylesheet Version 1.64 "><LINK REL="HOME" TITLE="SDL Library Documentation" HREF="index.html"><LINK REL="UP" TITLE="Video" HREF="video.html"><LINK REL="PREVIOUS" TITLE="SDL_Rect" HREF="sdlrect.html"><LINK REL="NEXT" TITLE="SDL_Palette" HREF="sdlpalette.html"></HEAD ><BODY CLASS="REFENTRY" BGCOLOR="#FFF8DC" TEXT="#000000" LINK="#0000ee" VLINK="#551a8b" ALINK="#ff0000" ><DIV CLASS="NAVHEADER" ><TABLE WIDTH="100%" BORDER="0" CELLPADDING="0" CELLSPACING="0" ><TR ><TH COLSPAN="3" ALIGN="center" >SDL Library Documentation</TH ></TR ><TR ><TD WIDTH="10%" ALIGN="left" VALIGN="bottom" ><A HREF="sdlrect.html" >Prev</A ></TD ><TD WIDTH="80%" ALIGN="center" VALIGN="bottom" ></TD ><TD WIDTH="10%" ALIGN="right" VALIGN="bottom" ><A HREF="sdlpalette.html" >Next</A ></TD ></TR ></TABLE ><HR ALIGN="LEFT" WIDTH="100%"></DIV ><H1 ><A NAME="SDLCOLOR" >SDL_Color</A ></H1 ><DIV CLASS="REFNAMEDIV" ><A NAME="AEN2698" ></A ><H2 >Name</H2 >SDL_Color -- Format independent color description</DIV ><DIV CLASS="REFSECT1" ><A NAME="AEN2701" ></A ><H2 >Structure Definition</H2 ><PRE CLASS="PROGRAMLISTING" >typedef struct{ Uint8 r; Uint8 g; Uint8 b; Uint8 unused; } SDL_Color;</PRE ></DIV ><DIV CLASS="REFSECT1" ><A NAME="AEN2704" ></A ><H2 >Structure Data</H2 ><DIV CLASS="INFORMALTABLE" ><A NAME="AEN2706" ></A ><P ></P ><TABLE BORDER="0" CLASS="CALSTABLE" ><TBODY ><TR ><TD ALIGN="LEFT" VALIGN="TOP" ><TT CLASS="STRUCTFIELD" ><I >r</I ></TT ></TD ><TD ALIGN="LEFT" VALIGN="TOP" >Red intensity</TD ></TR ><TR ><TD ALIGN="LEFT" VALIGN="TOP" ><TT CLASS="STRUCTFIELD" ><I >g</I ></TT ></TD ><TD ALIGN="LEFT" VALIGN="TOP" >Green intensity</TD ></TR ><TR ><TD ALIGN="LEFT" VALIGN="TOP" ><TT CLASS="STRUCTFIELD" ><I >b</I ></TT ></TD ><TD ALIGN="LEFT" VALIGN="TOP" >Blue intensity</TD ></TR ><TR ><TD ALIGN="LEFT" VALIGN="TOP" ><TT CLASS="STRUCTFIELD" ><I >unused</I ></TT ></TD ><TD ALIGN="LEFT" VALIGN="TOP" >Unused</TD ></TR ></TBODY ></TABLE ><P ></P ></DIV ></DIV ><DIV CLASS="REFSECT1" ><A NAME="AEN2725" ></A ><H2 >Description</H2 ><P ><SPAN CLASS="STRUCTNAME" >SDL_Color</SPAN > describes a color in a format independent way. You can convert a <SPAN CLASS="STRUCTNAME" >SDL_Color</SPAN > to a pixel value for a certain pixel format using <A HREF="sdlmaprgb.html" ><TT CLASS="FUNCTION" >SDL_MapRGB</TT ></A >.</P ></DIV ><DIV CLASS="REFSECT1" ><A NAME="AEN2732" ></A ><H2 >See Also</H2 ><P ><A HREF="sdlpixelformat.html" ><SPAN CLASS="STRUCTNAME" >SDL_PixelFormat</SPAN ></A >, <A HREF="sdlsetcolors.html" ><TT CLASS="FUNCTION" >SDL_SetColors</TT ></A >, <A HREF="sdlpalette.html" ><TT CLASS="FUNCTION" >SDL_Palette</TT ></A ></P ></DIV ><DIV CLASS="NAVFOOTER" ><HR ALIGN="LEFT" WIDTH="100%"><TABLE WIDTH="100%" BORDER="0" CELLPADDING="0" CELLSPACING="0" ><TR ><TD WIDTH="33%" ALIGN="left" VALIGN="top" ><A HREF="sdlrect.html" >Prev</A ></TD ><TD WIDTH="34%" ALIGN="center" VALIGN="top" ><A HREF="index.html" >Home</A ></TD ><TD WIDTH="33%" ALIGN="right" VALIGN="top" ><A HREF="sdlpalette.html" >Next</A ></TD ></TR ><TR ><TD WIDTH="33%" ALIGN="left" VALIGN="top" >SDL_Rect</TD ><TD WIDTH="34%" ALIGN="center" VALIGN="top" ><A HREF="video.html" >Up</A ></TD ><TD WIDTH="33%" ALIGN="right" VALIGN="top" >SDL_Palette</TD ></TR ></TABLE ></DIV ></BODY ></HTML >