Mercurial > sdl-ios-xcode
view src/video/nds/SDL_ndsvideo.h @ 4137:be12463f31ea SDL-1.2
Date: Sat, 2 Feb 2008 22:08:05 +0100
From: Marcus von Appen
To: sdl@lists.libsdl.org
Subject: [SDL] [Patch] SDL-1.2 SDL_revcpy() asm patch for the cld flag
Hi,
as reported through the FreeBSD bug tracking system in SDL 1.2.13 (and
in the 1.2 branch, if I see that correctly) the SDL_revcpy() macro sets
the direction flag (std), but does not clear it afterwards (cld), which
is wrong according to the GCC and SYS V specs. This can cause some
weird side effects, which in turn can lead to memory corruption.
You can read the full report with a detailed description and test
program at http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/120052
Attached is the submitted patch, which fixes the issue.
Regards
Marcus
author | Ryan C. Gordon <icculus@icculus.org> |
---|---|
date | Mon, 04 Feb 2008 17:22:56 +0000 |
parents | 8582c6a5ca16 |
children | a1b03ba2fcd0 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2006 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifndef _SDL_ndsvideo_h #define _SDL_ndsvideo_h #include "SDL_mouse.h" #include "../SDL_sysvideo.h" /* Hidden "this" pointer for the video functions */ #define _THIS SDL_VideoDevice *this /* Private display data */ struct SDL_PrivateVideoData { int w, h; void *buffer; short ndsmode; short secondbufferallocd; }; /* #define NDS_VIDC_BASE 0x4000000 #define NDS_DISPCNT (*(volatile Uint32*)(NDS_VIDC_BASE)) #define NDS_VIDC_SCANLINE (NDS_VIDC_BASE+6) #define NDS_SCANLINE (*(volatile Uint8*)(NDS_VIDC_SCANLINE)) #define NDS_DISP_MODE(n) (n&7) #define NDS_DISP_BG2 0x400 #define NDS_DISP_FB 0x10 #define NDS_PAL_BASE 0x5000000 #define NDS_BGPAL ((volatile Uint16*)(NDS_PAL_BASE)) #define NDS_OBJPAL ((volatile Uint16*)(NDS_PAL_BASE+0x200)) #define NDS_VRAM_BASE 0x6000000 #define NDS_VRAM_2NDBUF 0x600a000 #define NDS_VRAM = ((volatile Uint16* )NDS_VRAM_BASE) */ #endif /* _SDL_ndsvideo_h */