Mercurial > sdl-ios-xcode
view src/video/bwindow/SDL_sysmouse.cc @ 5053:b5b42be9333c
Fixed bug #1026
Vittorio Giovara 2010-07-16 19:09:28 PDT
i was reading SDL_renderer_gles and i noticed that every time we there
is some gl call the gl state is modified with a couple of
glEnableClientState()/glDisableClientState.
While this is completely fine for desktops systems, this is a major
performace kill on mobile devices, right where opengles is
implemented.
Normal practice in this case is to update the glstate once, keep it
always the same and disable/enable other states only in very special
occasions.
On the web there's plenty of documentation (on the top of my head
http://developer.apple.com/iphone/library/documentation/3DDrawing/Conceptual/OpenGLES_ProgrammingGuide/Performance/Performance.html#//apple_ref/doc/uid/TP40008793-CH105-SW5
) and i personally tried this.
I modified my code and got a 10 fps boost, then modified SDL_render_gles and
shifted from 40 fps to 50 fps alone -- considering that i started from ~30fps i
got an 80% performance increase with this technique.
I have attached a dif of my changes, hope that it will be included in
mainstream.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 19 Jan 2011 23:56:16 -0800 |
parents | 99210400e8b9 |
children | b530ef003506 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2009 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #include <AppKit.h> #include <GameKit.h> #include "SDL_BWin.h" extern "C" { #include "SDL_sysmouse_c.h" /* Convert bits to padded bytes */ #define PADDED_BITS(bits) ((bits+7)/8) /* The implementation dependent data for the window manager cursor */ struct WMcursor { char *bits; }; /* Can this be done in the BeOS? */ WMcursor *BE_CreateWMCursor(_THIS, Uint8 * data, Uint8 * mask, int w, int h, int hot_x, int hot_y) { WMcursor *cursor; int allowed_x; int allowed_y; int run, pad, i; char *cptr; allowed_x = 16; /* BeOS limitation */ allowed_y = 16; /* BeOS limitation */ if ((w > allowed_x) || (h > allowed_y)) { SDL_SetError("Only cursors of dimension (%dx%d) are allowed", allowed_x, allowed_y); return (NULL); } /* Allocate the cursor */ cursor = (WMcursor *) SDL_malloc(sizeof(WMcursor)); if (cursor == NULL) { SDL_OutOfMemory(); return (NULL); } cursor->bits = (char *) SDL_malloc(4 + 2 * ((allowed_x / 8) * allowed_y)); if (cursor->bits == NULL) { SDL_free(cursor); SDL_OutOfMemory(); return (NULL); } cursor->bits[0] = allowed_y; /* Size of the cursor */ cursor->bits[1] = 1; /* Bit depth of cursor */ cursor->bits[2] = hot_y; cursor->bits[3] = hot_x; cptr = &cursor->bits[4]; /* Pad out to the normal cursor size */ run = PADDED_BITS(w); pad = PADDED_BITS(allowed_x) - run; for (i = 0; i < h; ++i) { SDL_memcpy(cptr, data, run); SDL_memset(cptr + run, 0, pad); data += run; cptr += (run + pad); } for (; i < allowed_y; ++i) { SDL_memset(cptr, 0, run + pad); cptr += (run + pad); } for (i = 0; i < h; ++i) { /* FIXME: The mask should be OR'd with the data to turn inverted color pixels black, since inverted color pixels aren't supported under BeOS. */ SDL_memcpy(cptr, mask, run); SDL_memset(cptr + run, 0, pad); mask += run; cptr += (run + pad); } for (; i < allowed_y; ++i) { SDL_memset(cptr, 0, run + pad); cptr += (run + pad); } return (cursor); } int BE_ShowWMCursor(_THIS, WMcursor * cursor) { if (be_app->Lock()) { if (cursor == NULL) { if (SDL_BlankCursor != NULL) { be_app->SetCursor(SDL_BlankCursor->bits); } } else { be_app->SetCursor(cursor->bits); } be_app->Unlock(); } return (1); } void BE_FreeWMCursor(_THIS, WMcursor * cursor) { SDL_free(cursor->bits); SDL_free(cursor); } /* Implementation by Christian Bauer <cbauer@student.physik.uni-mainz.de> */ void BE_WarpWMCursor(_THIS, Uint16 x, Uint16 y) { BPoint pt(x, y); SDL_Win->Lock(); SDL_Win->ConvertToScreen(&pt); SDL_Win->Unlock(); set_mouse_position((int32) pt.x, (int32) pt.y); } }; /* Extern C */ /* vi: set ts=4 sw=4 expandtab: */