Mercurial > sdl-ios-xcode
view src/power/uikit/SDL_syspower.m @ 5053:b5b42be9333c
Fixed bug #1026
Vittorio Giovara 2010-07-16 19:09:28 PDT
i was reading SDL_renderer_gles and i noticed that every time we there
is some gl call the gl state is modified with a couple of
glEnableClientState()/glDisableClientState.
While this is completely fine for desktops systems, this is a major
performace kill on mobile devices, right where opengles is
implemented.
Normal practice in this case is to update the glstate once, keep it
always the same and disable/enable other states only in very special
occasions.
On the web there's plenty of documentation (on the top of my head
http://developer.apple.com/iphone/library/documentation/3DDrawing/Conceptual/OpenGLES_ProgrammingGuide/Performance/Performance.html#//apple_ref/doc/uid/TP40008793-CH105-SW5
) and i personally tried this.
I modified my code and got a 10 fps boost, then modified SDL_render_gles and
shifted from 40 fps to 50 fps alone -- considering that i started from ~30fps i
got an 80% performance increase with this technique.
I have attached a dif of my changes, hope that it will be included in
mainstream.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Wed, 19 Jan 2011 23:56:16 -0800 |
parents | 42e1092225f9 |
children | b530ef003506 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifndef SDL_POWER_DISABLED #ifdef SDL_POWER_UIKIT #import <UIKit/UIKit.h> #include "SDL_power.h" #include "SDL_timer.h" #include "SDL_assert.h" // turn off the battery monitor if it's been more than X ms since last check. static const int BATTERY_MONITORING_TIMEOUT = 3000; static Uint32 SDL_UIKitLastPowerInfoQuery = 0; void SDL_UIKit_UpdateBatteryMonitoring(void) { if (SDL_UIKitLastPowerInfoQuery) { const Uint32 prev = SDL_UIKitLastPowerInfoQuery; const UInt32 now = SDL_GetTicks(); const UInt32 ticks = now - prev; // if timer wrapped (now < prev), shut down, too. if ((now < prev) || (ticks >= BATTERY_MONITORING_TIMEOUT)) { UIDevice *uidev = [UIDevice currentDevice]; SDL_assert([uidev isBatteryMonitoringEnabled] == YES); [uidev setBatteryMonitoringEnabled:NO]; SDL_UIKitLastPowerInfoQuery = 0; } } } SDL_bool SDL_GetPowerInfo_UIKit(SDL_PowerState * state, int *seconds, int *percent) { UIDevice *uidev = [UIDevice currentDevice]; if (!SDL_UIKitLastPowerInfoQuery) { SDL_assert([uidev isBatteryMonitoringEnabled] == NO); [uidev setBatteryMonitoringEnabled:YES]; } // UIKit_GL_SwapWindow() (etc) will check this and disable the battery // monitoring if the app hasn't queried it in the last X seconds. // Apparently monitoring the battery burns battery life. :) // Apple's docs say not to monitor the battery unless you need it. SDL_UIKitLastPowerInfoQuery = SDL_GetTicks(); *seconds = -1; // no API to estimate this in UIKit. switch ([uidev batteryState]) { case UIDeviceBatteryStateCharging: *state = SDL_POWERSTATE_CHARGING; break; case UIDeviceBatteryStateFull: *state = SDL_POWERSTATE_CHARGED; break; case UIDeviceBatteryStateUnplugged: *state = SDL_POWERSTATE_ON_BATTERY; break; case UIDeviceBatteryStateUnknown: default: *state = SDL_POWERSTATE_UNKNOWN; break; } const float level = [uidev batteryLevel]; *percent = ( (level < 0.0f) ? -1 : (((int) (level + 0.5f)) * 100) ); return SDL_TRUE; /* always the definitive answer on iPhoneOS. */ } #endif /* SDL_POWER_UIKIT */ #endif /* SDL_POWER_DISABLED */ /* vi: set ts=4 sw=4 expandtab: */