Mercurial > sdl-ios-xcode
view src/video/xbios/SDL_xbios_sb3.h @ 1258:b2283b0ded26
Date: Thu, 19 Jan 2006 20:02:29 +0200
From: Vassilis Virvilis <vasvir@iit.demokritos.gr>
Subject: [SDL] Request: Please reconsider adding tag in SDL_Event
Hi,
Patch in question:
--- include/SDL_events.h 20 Aug 2004 18:57:01 -0000 1.11
+++ include/SDL_events.h 19 Jan 2006 17:35:09 -0000
@@ -214,7 +214,7 @@
} SDL_SysWMEvent;
/* General event structure */
-typedef union {
+typedef union SDL_Event {
Uint8 type;
SDL_ActiveEvent active;
SDL_KeyboardEvent key;
Reasoning:
----------
1) Allows forward declaration of the SDL_Event union in C++. Please
note that in plain C it is possible to forward declare it.
2) Forward declaration is good because it allows encapsulation. It hides
the specific implementation and does not necessarily exposes SDL staff
to my appication's namespace
3) It can't harm plain C because tags are living in a different namespace
than typenames
4) It is already done like this in other places in SDL. Check for example
SDL_KeySym, and SDL_.*Event structures.
5) Right now I have to include SDL/event.h from a C++ header file. See 2)
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Fri, 20 Jan 2006 13:07:25 +0000 |
| parents | c6ed27c7d47d |
| children | d910939febfa |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ /* ScreenBlaster 3 definitions Patrice Mandin */ #ifndef _SDL_xbios_sb3_h_ #define _SDL_xbios_sb3_h_ /*--- Defines ---*/ #ifndef C_SCPN #define C_SCPN 0x5343504EL #endif #define SCPN_DEV_1BPP 0 #define SCPN_DEV_2BPP 1 #define SCPN_DEV_4BPP 2 #define SCPN_DEV_8BPP 3 #define SCPN_DEV_16BPP 4 extern const int SDL_XBIOS_scpn_planes_device[]; /*--- Types ---*/ typedef struct { unsigned short virtual_width; /* Virtual screen width */ unsigned short virtual_height; /* Virtual screen height */ unsigned short visible_width; /* Visible width */ unsigned short visible_height; /* Visible height */ unsigned short h_pos; /* Horizontal position in virtual screen */ unsigned short v_pos; /* Vertical position in virtual screen */ unsigned short dummy; unsigned long size; /* Size of screen in bytes */ unsigned short device; /* Device number to find planes = getRez() */ /* = Index in scpn_planes_device[] */ } __attribute__((packed)) scpn_screeninfo_t; typedef struct { unsigned long magic; /* just a BRA assembler jump */ unsigned short version; void *dummy1; unsigned short ptsout0_1; unsigned short ptsout0_2; unsigned short dummy3; unsigned char date[8]; /* Date of program build */ unsigned char asm_string[30]; /* 10 times the 'ASM' string */ unsigned short dummy4; scpn_screeninfo_t *screen_info; unsigned short dummy6; } __attribute__((packed)) scpn_cookie_t; /*--- Function prototypes ---*/ int SDL_XBIOS_SB3Usable(scpn_cookie_t *cookie_scpn); void SDL_XBIOS_SB3Init(_THIS, scpn_cookie_t *cookie_scpn); #endif /* _SDL_xbios_sb3_h_ */