Mercurial > sdl-ios-xcode
view src/video/ps2gs/SDL_gsvideo.h @ 1258:b2283b0ded26
Date: Thu, 19 Jan 2006 20:02:29 +0200
From: Vassilis Virvilis <vasvir@iit.demokritos.gr>
Subject: [SDL] Request: Please reconsider adding tag in SDL_Event
Hi,
Patch in question:
--- include/SDL_events.h 20 Aug 2004 18:57:01 -0000 1.11
+++ include/SDL_events.h 19 Jan 2006 17:35:09 -0000
@@ -214,7 +214,7 @@
} SDL_SysWMEvent;
/* General event structure */
-typedef union {
+typedef union SDL_Event {
Uint8 type;
SDL_ActiveEvent active;
SDL_KeyboardEvent key;
Reasoning:
----------
1) Allows forward declaration of the SDL_Event union in C++. Please
note that in plain C it is possible to forward declare it.
2) Forward declaration is good because it allows encapsulation. It hides
the specific implementation and does not necessarily exposes SDL staff
to my appication's namespace
3) It can't harm plain C because tags are living in a different namespace
than typenames
4) It is already done like this in other places in SDL. Check for example
SDL_KeySym, and SDL_.*Event structures.
5) Right now I have to include SDL/event.h from a C++ header file. See 2)
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Fri, 20 Jan 2006 13:07:25 +0000 |
| parents | e8157fcb3114 |
| children | c9b51268668f |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997, 1998, 1999, 2000 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif #ifndef _SDL_gsvideo_h #define _SDL_gsvideo_h #include <sys/types.h> #include <termios.h> #include <linux/ps2/dev.h> #include <linux/ps2/gs.h> #include "SDL_mouse.h" #include "SDL_mutex.h" #include "SDL_sysvideo.h" /* Hidden "this" pointer for the video functions */ #define _THIS SDL_VideoDevice *this /* Private display data */ struct SDL_PrivateVideoData { /* Gotta love that simple PS2 graphics interface. :) */ int console_fd; int memory_fd; struct ps2_screeninfo saved_vinfo; /* Ye olde linux keyboard code */ int current_vt; int saved_vt; int keyboard_fd; int saved_kbd_mode; struct termios saved_kbd_termios; /* Ye olde linux mouse code */ int mouse_fd; int cursor_drawn; /* The memory mapped DMA area and associated variables */ caddr_t mapped_mem; int pixels_len; int mapped_len; struct ps2_image screen_image; int screen_image_size; unsigned long long *head_tags_mem; unsigned long long *image_tags_mem; unsigned long long *tex_tags_mem; unsigned long long *scale_tags_mem; int dma_pending; }; /* Old variable names */ #define console_fd (this->hidden->console_fd) #define memory_fd (this->hidden->memory_fd) #define saved_vinfo (this->hidden->saved_vinfo) #define current_vt (this->hidden->current_vt) #define saved_vt (this->hidden->saved_vt) #define keyboard_fd (this->hidden->keyboard_fd) #define saved_kbd_mode (this->hidden->saved_kbd_mode) #define saved_kbd_termios (this->hidden->saved_kbd_termios) #define mouse_fd (this->hidden->mouse_fd) #define cursor_drawn (this->hidden->cursor_drawn) #define mapped_mem (this->hidden->mapped_mem) #define pixels_len (this->hidden->pixels_len) #define mapped_len (this->hidden->mapped_len) #define screen_image (this->hidden->screen_image) #define screen_image_size (this->hidden->screen_image_size) #define head_tags_mem (this->hidden->head_tags_mem) #define image_tags_mem (this->hidden->image_tags_mem) #define tex_tags_mem (this->hidden->tex_tags_mem) #define scale_tags_mem (this->hidden->scale_tags_mem) #define dma_pending (this->hidden->dma_pending) /* Shared between the mouse and video code for screen update scaling */ extern int scaleimage_nonblock(int fd, unsigned long long *tm, unsigned long long *sm); #endif /* _SDL_gsvideo_h */