Mercurial > sdl-ios-xcode
view src/video/Xext/extensions/xf86dga1.h @ 1258:b2283b0ded26
Date: Thu, 19 Jan 2006 20:02:29 +0200
From: Vassilis Virvilis <vasvir@iit.demokritos.gr>
Subject: [SDL] Request: Please reconsider adding tag in SDL_Event
Hi,
Patch in question:
--- include/SDL_events.h 20 Aug 2004 18:57:01 -0000 1.11
+++ include/SDL_events.h 19 Jan 2006 17:35:09 -0000
@@ -214,7 +214,7 @@
} SDL_SysWMEvent;
/* General event structure */
-typedef union {
+typedef union SDL_Event {
Uint8 type;
SDL_ActiveEvent active;
SDL_KeyboardEvent key;
Reasoning:
----------
1) Allows forward declaration of the SDL_Event union in C++. Please
note that in plain C it is possible to forward declare it.
2) Forward declaration is good because it allows encapsulation. It hides
the specific implementation and does not necessarily exposes SDL staff
to my appication's namespace
3) It can't harm plain C because tags are living in a different namespace
than typenames
4) It is already done like this in other places in SDL. Check for example
SDL_KeySym, and SDL_.*Event structures.
5) Right now I have to include SDL/event.h from a C++ header file. See 2)
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 20 Jan 2006 13:07:25 +0000 (2006-01-20) |
parents | 585a7e1285ae |
children | 782fd950bd46 c121d94672cb |
line wrap: on
line source
/* $XFree86: xc/include/extensions/xf86dga1.h,v 1.2 1999/04/17 07:05:41 dawes Exp $ */ /* Copyright (c) 1995 Jon Tombs Copyright (c) 1995 XFree86 Inc */ /************************************************************************ THIS IS THE OLD DGA API AND IS OBSOLETE. PLEASE DO NOT USE IT ANYMORE ************************************************************************/ #ifndef _XF86DGA1_H_ #define _XF86DGA1_H_ #include <X11/Xfuncproto.h> #include "SDL_name.h" #define X_XF86DGAQueryVersion 0 #define X_XF86DGAGetVideoLL 1 #define X_XF86DGADirectVideo 2 #define X_XF86DGAGetViewPortSize 3 #define X_XF86DGASetViewPort 4 #define X_XF86DGAGetVidPage 5 #define X_XF86DGASetVidPage 6 #define X_XF86DGAInstallColormap 7 #define X_XF86DGAQueryDirectVideo 8 #define X_XF86DGAViewPortChanged 9 #define XF86DGADirectPresent 0x0001 #define XF86DGADirectGraphics 0x0002 #define XF86DGADirectMouse 0x0004 #define XF86DGADirectKeyb 0x0008 #define XF86DGAHasColormap 0x0100 #define XF86DGADirectColormap 0x0200 #ifndef _XF86DGA_SERVER_ _XFUNCPROTOBEGIN Bool SDL_NAME(XF86DGAQueryVersion)( #if NeedFunctionPrototypes Display* /* dpy */, int* /* majorVersion */, int* /* minorVersion */ #endif ); Bool SDL_NAME(XF86DGAQueryExtension)( #if NeedFunctionPrototypes Display* /* dpy */, int* /* event_base */, int* /* error_base */ #endif ); Status SDL_NAME(XF86DGAGetVideoLL)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int * /* base addr */, int * /* width */, int * /* bank_size */, int * /* ram_size */ #endif ); Status SDL_NAME(XF86DGAGetVideo)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, char ** /* base addr */, int * /* width */, int * /* bank_size */, int * /* ram_size */ #endif ); Status SDL_NAME(XF86DGADirectVideo)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int /* enable */ #endif ); Status SDL_NAME(XF86DGADirectVideoLL)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int /* enable */ #endif ); Status SDL_NAME(XF86DGAGetViewPortSize)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int * /* width */, int * /* height */ #endif ); Status SDL_NAME(XF86DGASetViewPort)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int x /* X */, int y /* Y */ #endif ); Status SDL_NAME(XF86DGAGetVidPage)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int * /* vid page */ #endif ); Status SDL_NAME(XF86DGASetVidPage)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, int /* vid page */ #endif ); Status SDL_NAME(XF86DGAInstallColormap)( #if NeedFunctionPrototypes Display* /* dpy */, int /* screen */, Colormap /*Colormap */ #endif ); int SDL_NAME(XF86DGAForkApp)( #if NeedFunctionPrototypes int screen #endif ); Status SDL_NAME(XF86DGAQueryDirectVideo)( #if NeedFunctionPrototypes Display * /* dpy */, int /* screen */, int * /* flags */ #endif ); Bool SDL_NAME(XF86DGAViewPortChanged)( #if NeedFunctionPrototypes Display * /* dpy */, int /* screen */, int /* n */ #endif ); _XFUNCPROTOEND #endif /* _XF86DGA_SERVER_ */ #endif /* _XF86DGA1_H_ */