Mercurial > sdl-ios-xcode
view src/cdrom/SDL_syscdrom.h @ 1258:b2283b0ded26
Date: Thu, 19 Jan 2006 20:02:29 +0200
From: Vassilis Virvilis <vasvir@iit.demokritos.gr>
Subject: [SDL] Request: Please reconsider adding tag in SDL_Event
Hi,
Patch in question:
--- include/SDL_events.h 20 Aug 2004 18:57:01 -0000 1.11
+++ include/SDL_events.h 19 Jan 2006 17:35:09 -0000
@@ -214,7 +214,7 @@
} SDL_SysWMEvent;
/* General event structure */
-typedef union {
+typedef union SDL_Event {
Uint8 type;
SDL_ActiveEvent active;
SDL_KeyboardEvent key;
Reasoning:
----------
1) Allows forward declaration of the SDL_Event union in C++. Please
note that in plain C it is possible to forward declare it.
2) Forward declaration is good because it allows encapsulation. It hides
the specific implementation and does not necessarily exposes SDL staff
to my appication's namespace
3) It can't harm plain C because tags are living in a different namespace
than typenames
4) It is already done like this in other places in SDL. Check for example
SDL_KeySym, and SDL_.*Event structures.
5) Right now I have to include SDL/event.h from a C++ header file. See 2)
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Fri, 20 Jan 2006 13:07:25 +0000 |
parents | b8d311d90021 |
children | c9b51268668f |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2004 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public License for more details. You should have received a copy of the GNU Library General Public License along with this library; if not, write to the Free Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA Sam Lantinga slouken@libsdl.org */ #ifdef SAVE_RCSID static char rcsid = "@(#) $Id$"; #endif /* This is the system specific header for the SDL CD-ROM API */ /* Structure of CD audio control functions */ extern struct CDcaps { /* Get the name of the specified drive */ const char *(*Name)(int drive); /* Open the specified drive, returning a drive id, or -1 on error */ int (*Open)(int drive); /* Get table-of-contents (number of tracks + track info) for disk. The TOC information should be stored in the cdrom structure. This function should return 0 on success, or -1 on error. */ int (*GetTOC)(SDL_CD *cdrom); /* Return the current status and play position, in frames, of the drive. 'position' may be NULL, and if so, should be ignored. */ CDstatus (*Status)(SDL_CD *cdrom, int *position); /* Play from frame 'start' to 'start+len' */ int (*Play)(SDL_CD *cdrom, int start, int len); /* Pause play */ int (*Pause)(SDL_CD *cdrom); /* Resume play */ int (*Resume)(SDL_CD *cdrom); /* Stop play */ int (*Stop)(SDL_CD *cdrom); /* Eject the current disk */ int (*Eject)(SDL_CD *cdrom); /* Close the specified drive */ void (*Close)(SDL_CD *cdrom); } SDL_CDcaps; /* The number of available CD-ROM drives on the system */ extern int SDL_numcds; /* Function to scan the system for CD-ROM drives and fill SDL_CDcaps. * This function should set SDL_numcds to the number of available CD * drives. Drive 0 should be the system default CD-ROM. * It should return 0, or -1 on an unrecoverable fatal error. */ extern int SDL_SYS_CDInit(void); /* Function to perform any system-specific CD-ROM related cleanup */ extern void SDL_SYS_CDQuit(void);