Date: Thu, 19 Jan 2006 20:02:29 +0200 From: Vassilis Virvilis <vasvir@iit.demokritos.gr> Subject: [SDL] Request: Please reconsider adding tag in SDL_Event Hi, Patch in question: --- include/SDL_events.h 20 Aug 2004 18:57:01 -0000 1.11 +++ include/SDL_events.h 19 Jan 2006 17:35:09 -0000 @@ -214,7 +214,7 @@ } SDL_SysWMEvent; /* General event structure */ -typedef union { +typedef union SDL_Event { Uint8 type; SDL_ActiveEvent active; SDL_KeyboardEvent key; Reasoning: ---------- 1) Allows forward declaration of the SDL_Event union in C++. Please note that in plain C it is possible to forward declare it. 2) Forward declaration is good because it allows encapsulation. It hides the specific implementation and does not necessarily exposes SDL staff to my appication's namespace 3) It can't harm plain C because tags are living in a different namespace than typenames 4) It is already done like this in other places in SDL. Check for example SDL_KeySym, and SDL_.*Event structures. 5) Right now I have to include SDL/event.h from a C++ header file. See 2)

## Makefile.am for the main SDL library

# These are the subdirectories that are always built
CORE_SUBDIRS =			\
	main

# These are the subdirectories which may be built
EXTRA_SUBDIRS =			\
	 audio video events joystick cdrom thread timer endian file cpuinfo hermes

# These are the subdirectories which will be built now
SUBDIRS = $(CORE_SUBDIRS) @SDL_EXTRADIRS@

# These are the subdirectories which will be distributed with "make dist"
DIST_SUBDIRS = $(CORE_SUBDIRS) $(EXTRA_SUBDIRS)

# The SDL library target
lib_LTLIBRARIES = libSDL.la

libSDL_la_SOURCES = $(GENERAL_SRCS)
libSDL_la_LDFLAGS = 		\
	-no-undefined		\
        -release $(LT_RELEASE)	\
	-version-info $(LT_CURRENT):$(LT_REVISION):$(LT_AGE)
libSDL_la_LIBADD =		\
	main/libarch.la		\
	@SDL_EXTRALIBS@		\
	@SYSTEM_LIBS@
libSDL_la_DEPENDENCIES =	\
	main/libarch.la		\
	@SDL_EXTRALIBS@

# The SDL library sources
GENERAL_SRCS = 		\
	SDL.c			\
	SDL_error.c		\
	SDL_error_c.h		\
	SDL_fatal.c		\
	SDL_fatal.h		\
	SDL_getenv.c		\
	SDL_loadso.c