Mercurial > sdl-ios-xcode
view src/hermes/HeadMMX.h @ 638:b0108e9dea53
Date: Sun, 11 May 2003 19:59:06 +0300
From: Pasi K?rkk?inen
Subject: [PATCH] fix SDL OpenGL segfault with DRI/Mesa drivers and Glew
Hello!
The attached patch fixes a bug in SDL which causes SDL to crash in
X11_GL_Shutdown() if you are using DRI/Mesa drivers AND glew
(http://glew.sf.net).
The bug is caused by a namespace collision affecting dlsym() to fetch wrong
pointer for glXReleaseBuffersMESA() (uninitialized pointer from glew because
the extension is NOT supported by the driver) and then SDL calling it in
X11_GL_Shutdown().
SDL should check if the glXReleaseBuffersMESA() is really supported by the
driver (from the extensions string) before calling it.
Attached patch adds extension string parsing to check if
glXReleaseBuffersMESA() is really supported (and this way
prevents the segfault).
Availability of the extensions should be _always_ checked from the
extensions string rather than using dlsym()!
Please add it to the next version of SDL.
Thanks to gltron and author of glew to help fixing this.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Sat, 28 Jun 2003 17:27:33 +0000 |
parents | 74212992fb08 |
children | bb5ace455586 |
line wrap: on
line source
/* Header definitions for the MMX routines for the HERMES library Copyright (c) 1998 Christian Nentwich (c.nentwich@cs.ucl.ac.uk) This source code is licensed under the GNU LGPL Please refer to the file COPYING.LIB contained in the distribution for licensing conditions */ #ifndef __HERMES_HEAD_MMX__ #define __HERMES_HEAD_MMX__ /* If you cannot stand ifdefs, then please do not look into this file, it's going to end your life :) */ #ifdef X86_ASSEMBLER #ifdef __cplusplus extern "C" { #endif void STACKCALL ConvertMMX(HermesConverterInterface *); void STACKCALL ClearMMX_32(HermesClearInterface *); void STACKCALL ClearMMX_24(HermesClearInterface *); void STACKCALL ClearMMX_16(HermesClearInterface *); void STACKCALL ClearMMX_8(HermesClearInterface *); void ConvertMMXpII32_24RGB888(); void ConvertMMXpII32_16RGB565(); void ConvertMMXpII32_16BGR565(); void ConvertMMXpII32_16RGB555(); void ConvertMMXpII32_16BGR565(); void ConvertMMXpII32_16BGR555(); void ConvertMMXp32_16RGB555(); #ifdef __cplusplus } #endif /* Fix the underscore business with ELF compilers */ #if defined(__ELF__) && defined(__GNUC__) #ifdef __cplusplus extern "C" { #endif void ConvertMMX(HermesConverterInterface *) __attribute__ ((alias ("_ConvertMMX"))); #if 0 void ClearMMX_32(HermesClearInterface *) __attribute__ ((alias ("_ClearMMX_32"))); void ClearMMX_24(HermesClearInterface *) __attribute__ ((alias ("_ClearMMX_24"))); void ClearMMX_16(HermesClearInterface *) __attribute__ ((alias ("_ClearMMX_16"))); void ClearMMX_8(HermesClearInterface *) __attribute__ ((alias ("_ClearMMX_8"))); void ConvertMMXp32_16RGB555() __attribute__ ((alias ("_ConvertMMXp32_16RGB555"))); #endif void ConvertMMXpII32_24RGB888() __attribute__ ((alias ("_ConvertMMXpII32_24RGB888"))); void ConvertMMXpII32_16RGB565() __attribute__ ((alias ("_ConvertMMXpII32_16RGB565"))); void ConvertMMXpII32_16BGR565() __attribute__ ((alias ("_ConvertMMXpII32_16BGR565"))); void ConvertMMXpII32_16RGB555() __attribute__ ((alias ("_ConvertMMXpII32_16RGB555"))); void ConvertMMXpII32_16BGR555() __attribute__ ((alias ("_ConvertMMXpII32_16BGR555"))); #ifdef __cplusplus } #endif #endif /* ELF and GNUC */ /* Make it work with Watcom */ #ifdef __WATCOMC__ #pragma warning 601 9 #pragma aux ConvertMMX "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_32 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_24 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_16 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ClearMMX_8 "_*" modify [EAX EBX ECX EDX ESI EDI] #pragma aux ConvertMMXpII32_24RGB888 "_*" #pragma aux ConvertMMXpII32_16RGB565 "_*" #pragma aux ConvertMMXpII32_16BGR565 "_*" #pragma aux ConvertMMXpII32_16RGB555 "_*" #pragma aux ConvertMMXpII32_16BGR555 "_*" #pragma aux ConvertMMXp32_16RGB555 "_*" #endif /* WATCOM */ #endif /* X86_ASSEMBLER */ #endif