Mercurial > sdl-ios-xcode
view test/testnative.h @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | 94dd49f6b005 |
children | e8916fe9cfc8 |
line wrap: on
line source
/* Definitions for platform dependent windowing functions to test SDL integration with native windows */ #include "SDL.h" /* This header includes all the necessary system headers for native windows */ #include "SDL_syswm.h" typedef struct { const char *tag; void *(*CreateNativeWindow) (int w, int h); void (*DestroyNativeWindow) (void *window); } NativeWindowFactory; #ifdef SDL_VIDEO_DRIVER_WIN32 #define TEST_NATIVE_WIN32 extern NativeWindowFactory Win32WindowFactory; #endif #ifdef SDL_VIDEO_DRIVER_X11 #define TEST_NATIVE_X11 extern NativeWindowFactory X11WindowFactory; #endif #ifdef SDL_VIDEO_DRIVER_COCOA /* Actually, we don't really do this, since it involves adding Objective C support to the build system, which is a little tricky. You can uncomment it manually though and link testnativecocoa.m into the test application. */ #if 1 #define TEST_NATIVE_COCOA extern NativeWindowFactory CocoaWindowFactory; #endif #endif