Mercurial > sdl-ios-xcode
view src/video/qnxgf/SDL_gf_render.h @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | f7b03b6838cb |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org QNX Graphics Framework SDL driver Copyright (C) 2009 Mike Gorchak (mike@malva.ua, lestat@i.com.ua) */ #ifndef __SDL_GF_RENDER_H__ #define __SDL_GF_RENDER_H__ #include "../SDL_sysvideo.h" #include <gf/gf.h> #define SDL_GF_MAX_SURFACES 3 typedef struct SDL_RenderData { SDL_Window *window; /* SDL window type */ SDL_bool enable_vsync; /* VSYNC flip synchronization enable */ gf_surface_t surface[SDL_GF_MAX_SURFACES]; /* Surface handles */ gf_surface_info_t surface_info[SDL_GF_MAX_SURFACES]; /* Surface info */ uint32_t surface_visible_idx; /* Index of visible surface */ uint32_t surface_render_idx; /* Index of render surface */ uint32_t surfaces_count; /* Amount of allocated surfaces */ } SDL_RenderData; typedef struct SDL_TextureData { gf_surface_t surface; gf_surface_info_t surface_info; } SDL_TextureData; extern void gf_addrenderdriver(_THIS); #endif /* __SDL_GF_RENDER_H__ */ /* vi: set ts=4 sw=4 expandtab: */