Mercurial > sdl-ios-xcode
view src/video/fbcon/3dfx_mmio.h @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | f7b03b6838cb |
children |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" /* 3Dfx register definitions */ #include "3dfx_regs.h" /* 3Dfx control macros */ #define tdfx_in8(reg) *(volatile Uint8 *)(mapped_io + (reg)) #define tdfx_in32(reg) *(volatile Uint32 *)(mapped_io + (reg)) #define tdfx_out8(reg,v) *(volatile Uint8 *)(mapped_io + (reg)) = v; #define tdfx_out32(reg,v) *(volatile Uint32 *)(mapped_io + (reg)) = v; /* Wait for fifo space */ #define tdfx_wait(space) \ { \ while ( (tdfx_in8(TDFX_STATUS) & 0x1F) < space ) \ ; \ } /* Wait for idle accelerator */ #define tdfx_waitidle() \ { \ int i = 0; \ \ tdfx_wait(1); \ tdfx_out32(COMMAND_3D, COMMAND_3D_NOP); \ do { \ i = (tdfx_in32(TDFX_STATUS) & STATUS_BUSY) ? 0 : i + 1; \ } while ( i != 3 ); \ } /* vi: set ts=4 sw=4 expandtab: */