Mercurial > sdl-ios-xcode
view src/video/SDL_blendrect.c @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | f7b03b6838cb |
children | aa8888658021 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #include "SDL_video.h" int SDL_BlendRect(SDL_Surface * dst, const SDL_Rect * rect, int blendMode, Uint8 r, Uint8 g, Uint8 b, Uint8 a) { SDL_Rect full_rect; SDL_Point points[5]; if (!dst) { SDL_SetError("Passed NULL destination surface"); return -1; } /* If 'rect' == NULL, then outline the whole surface */ if (!rect) { full_rect.x = 0; full_rect.y = 0; full_rect.w = dst->w; full_rect.h = dst->h; rect = &full_rect; } points[0].x = rect->x; points[0].y = rect->y; points[1].x = rect->x+rect->w-1; points[1].y = rect->y; points[2].x = rect->x+rect->w-1; points[2].y = rect->y+rect->h-1; points[3].x = rect->x; points[3].y = rect->y+rect->h-1; points[4].x = rect->x; points[4].y = rect->y; return SDL_BlendLines(dst, points, 5, blendMode, r, g, b, a); } int SDL_BlendRects(SDL_Surface * dst, const SDL_Rect ** rects, int count, int blendMode, Uint8 r, Uint8 g, Uint8 b, Uint8 a) { int i; for (i = 0; i < count; ++i) { if (SDL_BlendRect(dst, rects[i], blendMode, r, g, b, a) < 0) { return -1; } } return 0; } /* vi: set ts=4 sw=4 expandtab: */