Mercurial > sdl-ios-xcode
view src/loadso/beos/SDL_sysloadso.c @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
author | Sam Lantinga <slouken@libsdl.org> |
---|---|
date | Mon, 12 Jul 2010 22:08:50 -0700 |
parents | f7b03b6838cb |
children | b530ef003506 |
line wrap: on
line source
/* SDL - Simple DirectMedia Layer Copyright (C) 1997-2010 Sam Lantinga This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This library is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details. You should have received a copy of the GNU Lesser General Public License along with this library; if not, write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA Sam Lantinga slouken@libsdl.org */ #include "SDL_config.h" #ifdef SDL_LOADSO_BEOS /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ /* System dependent library loading routines */ #include <stdio.h> #include <be/kernel/image.h> #include "SDL_loadso.h" void * SDL_LoadObject(const char *sofile) { void *handle = NULL; image_id library_id = load_add_on(sofile); if (library_id < 0) { SDL_SetError(strerror((int) library_id)); } else { handle = (void *) (library_id); } return (handle); } void * SDL_LoadFunction(void *handle, const char *name) { void *sym = NULL; image_id library_id = (image_id) handle; status_t rc = get_image_symbol(library_id, name, B_SYMBOL_TYPE_TEXT, &sym); if (rc != B_NO_ERROR) { SDL_SetError(strerror(rc)); } return (sym); } void SDL_UnloadObject(void *handle) { image_id library_id; if (handle != NULL) { library_id = (image_id) handle; unload_add_on(library_id); } } #endif /* SDL_LOADSO_BEOS */ /* vi: set ts=4 sw=4 expandtab: */