Mercurial > sdl-ios-xcode
view src/libm/s_copysign.c @ 4511:ae7799d16c87
Daniel Wyatt 2010-03-26 14:52:53 PDT
If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).
In other words, something like this:
test.exe [non-quoted args] "" [...]
The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.
You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3
These will not cause a crash:
"program" [...]
program "arg1" ""
When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.
I've tested this on Windows XP SP3 and Windows 7.
| author | Sam Lantinga <slouken@libsdl.org> |
|---|---|
| date | Mon, 12 Jul 2010 22:08:50 -0700 |
| parents | dc1eb82ffdaa |
| children |
line wrap: on
line source
/* @(#)s_copysign.c 5.1 93/09/24 */ /* * ==================================================== * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. * * Developed at SunPro, a Sun Microsystems, Inc. business. * Permission to use, copy, modify, and distribute this * software is freely granted, provided that this notice * is preserved. * ==================================================== */ #if defined(LIBM_SCCS) && !defined(lint) static const char rcsid[] = "$NetBSD: s_copysign.c,v 1.8 1995/05/10 20:46:57 jtc Exp $"; #endif /* * copysign(double x, double y) * copysign(x,y) returns a value with the magnitude of x and * with the sign bit of y. */ #include "math.h" #include "math_private.h" libm_hidden_proto(copysign) #ifdef __STDC__ double copysign(double x, double y) #else double copysign(x, y) double x, y; #endif { u_int32_t hx, hy; GET_HIGH_WORD(hx, x); GET_HIGH_WORD(hy, y); SET_HIGH_WORD(x, (hx & 0x7fffffff) | (hy & 0x80000000)); return x; } libm_hidden_def(copysign)